Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_0_X] Update FG HF thresholds to 2022 PbPb #41250

Merged

Conversation

stahlleiton
Copy link
Contributor

PR description:

This PR updates the values of the HF thresholds in the HCAL TP emulator with those used during the 2022 PbPb run (as documented in https://its.cern.ch/jira/browse/CMSLITDPG-1078 ).

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #41239

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2023

A new Pull Request was created by @stahlleiton (Andre Stahl) for CMSSW_13_0_X.

It involves the following packages:

  • SimCalorimetry/HcalTrigPrimProducers (l1)

@epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please review it and eventually sign? Thanks.
@missirol, @sameasy, @abdoulline, @rovere, @bsunanda this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@aloeliger
Copy link
Contributor

Backport of #41239

@aloeliger
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22d724/31725/summary.html
COMMIT: be5d17b
CMSSW: CMSSW_13_0_X_2023-03-31-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41250/31725/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 17 lines from the logs
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3553952
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3553923
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor

@stahlleiton Please implement the changes seen in #41239 here as well.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2023

Pull request #41250 was updated. @epalencia, @cmsbuild, @saumyaphor4252, @aloeliger, @francescobrivio, @cecilecaillol, @tvami can you please check and sign again.

@tvami
Copy link
Contributor

tvami commented Apr 4, 2023

test parameters:

  • workflows = 160.1

@tvami
Copy link
Contributor

tvami commented Apr 4, 2023

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2023

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22d724/31793/summary.html
COMMIT: 37d89d3
CMSSW: CMSSW_13_0_X_2023-04-03-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41250/31793/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

ValueError: Undefined workflows: 160.1

@tvami
Copy link
Contributor

tvami commented Apr 4, 2023

test parameters:

@tvami
Copy link
Contributor

tvami commented Apr 4, 2023

@cmsbuild , please test

@tvami
Copy link
Contributor

tvami commented Apr 4, 2023

  • workflows = 160.1

oh well I guess this wf was not backported

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22d724/31801/summary.html
COMMIT: 37d89d3
CMSSW: CMSSW_13_0_X_2023-04-03-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41250/31801/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 6 lines to the logs
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3553952
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3553925
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Apr 4, 2023

+alca

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Apr 5, 2023

+1

@cmsbuild cmsbuild merged commit a897f09 into cms-sw:CMSSW_13_0_X Apr 5, 2023
@stahlleiton stahlleiton deleted the FH_HF_Update_CMSSW_13_0_2 branch April 5, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants