Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GEM geometry in 2023 MC GTs and L1 HI menu tag in 2022/2023 MC GTs #41202

Merged

Conversation

saumyaphor4252
Copy link
Contributor

@saumyaphor4252 saumyaphor4252 commented Mar 27, 2023

PR description:

This PR updates the 2023 MC Global Tags in autoCond with the GEM geometry tags requested in this CMS Talk post [1]. In addition, the 2022 and 2023 HI MC GTs are also updated with the L1 menu tag L1Menu_CollisionsHeavyIons2022_v1_1_0-d1_xml requested in [2]

[1] https://cms-talk.web.cern.ch/t/update-of-gem-geometry-for-2023-data-and-mc/21887
[2] https://cms-talk.web.cern.ch/t/request-to-include-the-hi-l1-menu-in-the-run3-hi-mc-gt/21665

The difference with the last GTs in autoCond is here:

PR validation:

GTs tested locally with runTheMatrix.py -l 160.1, 12434.0 --ibeos -j 16 which consume auto:phase1_2023_realistic_hi and auto:phase1_2023_realistic respectively

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but the GEM geometry updates will be backported in 130X GTs, which is the baseline release for 2023 MC production

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41202/34899

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @saumyaphor4252 (Saumya Phor) for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@saumyaphor4252
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b100d/31628/summary.html
COMMIT: 1c2f01f
CMSSW: CMSSW_13_1_X_2023-03-27-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41202/31628/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 28-Mar-2023 00:17:25 CEST-----------------------
An exception of category 'StdException' occurred while
   [0] Processing global begin Run run: 1
   [1] Prefetching for module OscarMTProducer/'g4SimHits'
   [2] Prefetching for EventSetup module MuonOffsetESProducer/'muonOffsetESProducer'
   [3] Prefetching for EventSetup module DDCompactViewESProducer/''
   [4] Calling method for EventSetup module DDDetectorESProducer/'DDDetectorESProducerFromDB'
Exception Message:
A std::exception was thrown.
An exception of category 'DD4CMS' occurred.
Exception Message:
Composite material "trackermaterial:T_Barium_Titanate" or "trackermaterial:T_Barium_Titanate" not yet defined.

dd4hep: Error interpreting XML nodes of type <CompositeMaterial/>
dd4hep: Error interpreting XML nodes of type <MaterialSection/>
dd4hep: with plugin:DD4hep_XMLProcessor
----- End Fatal Exception -------------------------------------------------

RelVals-INPUT

  • 12634.9912634.99_TTbar_14TeV+2023PU_PMXS1S2/step2_TTbar_14TeV+2023PU_PMXS1S2.log

AddOn Tests

----- Begin Fatal Exception 28-Mar-2023 00:01:59 CEST-----------------------
An exception of category 'StdException' occurred while
   [0] Processing global begin Run run: 1
   [1] Prefetching for module OscarMTProducer/'g4SimHits'
   [2] Prefetching for EventSetup module MuonOffsetESProducer/'muonOffsetESProducer'
   [3] Prefetching for EventSetup module DDCompactViewESProducer/''
   [4] Calling method for EventSetup module DDDetectorESProducer/'DDDetectorESProducerFromDB'
Exception Message:
A std::exception was thrown.
An exception of category 'DD4CMS' occurred.
Exception Message:
Composite material "trackermaterial:T_Barium_Titanate" or "trackermaterial:T_Barium_Titanate" not yet defined.

dd4hep: Error interpreting XML nodes of type <CompositeMaterial/>
dd4hep: Error interpreting XML nodes of type <MaterialSection/>
dd4hep: with plugin:DD4hep_XMLProcessor
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 28-Mar-2023 00:01:59 CEST-----------------------
An exception of category 'StdException' occurred while
   [0] Processing global begin Run run: 1
   [1] Prefetching for module OscarMTProducer/'g4SimHits'
   [2] Prefetching for EventSetup module MuonOffsetESProducer/'muonOffsetESProducer'
   [3] Prefetching for EventSetup module DDCompactViewESProducer/''
   [4] Calling method for EventSetup module DDDetectorESProducer/'DDDetectorESProducerFromDB'
Exception Message:
A std::exception was thrown.
An exception of category 'DD4CMS' occurred.
Exception Message:
Composite material "trackermaterial:T_Barium_Titanate" or "trackermaterial:T_Barium_Titanate" not yet defined.

dd4hep: Error interpreting XML nodes of type <CompositeMaterial/>
dd4hep: Error interpreting XML nodes of type <MaterialSection/>
dd4hep: with plugin:DD4hep_XMLProcessor
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 28-Mar-2023 00:01:59 CEST-----------------------
An exception of category 'StdException' occurred while
   [0] Processing global begin Run run: 1
   [1] Prefetching for module OscarMTProducer/'g4SimHits'
   [2] Prefetching for EventSetup module MuonOffsetESProducer/'muonOffsetESProducer'
   [3] Prefetching for EventSetup module DDCompactViewESProducer/''
   [4] Calling method for EventSetup module DDDetectorESProducer/'DDDetectorESProducerFromDB'
Exception Message:
A std::exception was thrown.
An exception of category 'DD4CMS' occurred.
Exception Message:
Composite material "trackermaterial:T_Barium_Titanate" or "trackermaterial:T_Barium_Titanate" not yet defined.

dd4hep: Error interpreting XML nodes of type <CompositeMaterial/>
dd4hep: Error interpreting XML nodes of type <MaterialSection/>
dd4hep: with plugin:DD4hep_XMLProcessor
----- End Fatal Exception -------------------------------------------------
Expand to see more addon errors ...

@tvami
Copy link
Contributor

tvami commented Mar 28, 2023

@bsunanda can you chime in?

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41202/34908

@cmsbuild
Copy link
Contributor

Pull request #41202 was updated. @cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please check and sign again.

@saumyaphor4252
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b100d/31638/summary.html
COMMIT: ad65b26
CMSSW: CMSSW_13_1_X_2023-03-27-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41202/31638/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 69 lines to the logs
  • Reco comparison results: 2246 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3554236
  • DQMHistoTests: Total failures: 3041
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3551173
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -1.805 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -1.805 KiB L1T/L1TStage2uGT
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 1 / 47 workflows

@tvami
Copy link
Contributor

tvami commented Mar 28, 2023

+alca

  • widespread changes 12434.0_TTbar_14TeV+2023 as expected
  • dedicated PdmV validation campaign is planned

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@tvami
Copy link
Contributor

tvami commented Mar 28, 2023

urgent

  • the backport is urgent

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8674203 into cms-sw:master Mar 28, 2023
@saumyaphor4252 saumyaphor4252 deleted the alca-update_2023_GEM_geometry_in_MC_GTs branch October 13, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants