Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_0_X] Update GEM geometry in 2023 MC GTs and the HI beamspot in 2023 MC GT #41203

Conversation

saumyaphor4252
Copy link
Contributor

@saumyaphor4252 saumyaphor4252 commented Mar 27, 2023

PR description:

Backport of #41202
This PR updates the 130X 2023 MC Global Tags in autoCond with the GEM geometry tags requested in this CMS Talk post [1]. Also, the 2023 Heavy Ion MC GT is updated with the beamspot tag BeamSpotObjects_Realistic2022PbPbCollision_v5_mc as requested in [2].

[1] https://cms-talk.web.cern.ch/t/update-of-gem-geometry-for-2023-data-and-mc/21887
[2] https://cms-talk.web.cern.ch/t/request-for-new-run3-hi-mc-gt-realistic-bs-for-13-0-x/21912

The difference with the last GTs in autoCond is here:

PR validation:

GTs tested locally with runTheMatrix.py -l 160.1, 12434.0 --ibeos -j 16 which consume auto:phase1_2023_realistic_hi and auto:phase1_2023_realistic respectively

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Partial backport of #41202. No other backport foreseen.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 27, 2023

A new Pull Request was created by @saumyaphor4252 (Saumya Phor) for CMSSW_13_0_X.

It involves the following packages:

  • Configuration/AlCa (alca)

@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@saumyaphor4252
Copy link
Contributor Author

@cmsbuild, please test

@saumyaphor4252
Copy link
Contributor Author

@cmsbuild, please abort

@saumyaphor4252 saumyaphor4252 force-pushed the alca-130X_update_2023_GEM_geometry_in_MC_GTs branch from 1a247d5 to 1db7f4d Compare March 27, 2023 22:03
@cmsbuild
Copy link
Contributor

Pull request #41203 was updated. @cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please check and sign again.

@saumyaphor4252 saumyaphor4252 changed the title [13_0_X] Update GEM geometry in 2023 MC GTs [13_0_X] Update GEM geometry in 2023 MC GTs and the HI beamspot in 2023 MC GT Mar 27, 2023
@saumyaphor4252
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4bb521/31630/summary.html
COMMIT: 1db7f4d
CMSSW: CMSSW_13_0_X_2023-03-27-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41203/31630/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 28-Mar-2023 00:58:24 CEST-----------------------
An exception of category 'StdException' occurred while
   [0] Processing global begin Run run: 1
   [1] Prefetching for module OscarMTProducer/'g4SimHits'
   [2] Prefetching for EventSetup module MuonOffsetESProducer/'muonOffsetESProducer'
   [3] Prefetching for EventSetup module DDCompactViewESProducer/''
   [4] Calling method for EventSetup module DDDetectorESProducer/'DDDetectorESProducerFromDB'
Exception Message:
A std::exception was thrown.
An exception of category 'DD4CMS' occurred.
Exception Message:
Composite material "trackermaterial:T_Barium_Titanate" or "trackermaterial:T_Barium_Titanate" not yet defined.

dd4hep: Error interpreting XML nodes of type <CompositeMaterial/>
dd4hep: Error interpreting XML nodes of type <MaterialSection/>
dd4hep: with plugin:DD4hep_XMLProcessor
----- End Fatal Exception -------------------------------------------------

RelVals-INPUT

  • 12634.9912634.99_TTbar_14TeV+2023PU_PMXS1S2/step2_TTbar_14TeV+2023PU_PMXS1S2.log

AddOn Tests

----- Begin Fatal Exception 28-Mar-2023 00:44:30 CEST-----------------------
An exception of category 'StdException' occurred while
   [0] Processing global begin Run run: 1
   [1] Prefetching for module OscarMTProducer/'g4SimHits'
   [2] Prefetching for EventSetup module MuonOffsetESProducer/'muonOffsetESProducer'
   [3] Prefetching for EventSetup module DDCompactViewESProducer/''
   [4] Calling method for EventSetup module DDDetectorESProducer/'DDDetectorESProducerFromDB'
Exception Message:
A std::exception was thrown.
An exception of category 'DD4CMS' occurred.
Exception Message:
Composite material "trackermaterial:T_Barium_Titanate" or "trackermaterial:T_Barium_Titanate" not yet defined.

dd4hep: Error interpreting XML nodes of type <CompositeMaterial/>
dd4hep: Error interpreting XML nodes of type <MaterialSection/>
dd4hep: with plugin:DD4hep_XMLProcessor
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 28-Mar-2023 00:44:30 CEST-----------------------
An exception of category 'StdException' occurred while
   [0] Processing global begin Run run: 1
   [1] Prefetching for module OscarMTProducer/'g4SimHits'
   [2] Prefetching for EventSetup module MuonOffsetESProducer/'muonOffsetESProducer'
   [3] Prefetching for EventSetup module DDCompactViewESProducer/''
   [4] Calling method for EventSetup module DDDetectorESProducer/'DDDetectorESProducerFromDB'
Exception Message:
A std::exception was thrown.
An exception of category 'DD4CMS' occurred.
Exception Message:
Composite material "trackermaterial:T_Barium_Titanate" or "trackermaterial:T_Barium_Titanate" not yet defined.

dd4hep: Error interpreting XML nodes of type <CompositeMaterial/>
dd4hep: Error interpreting XML nodes of type <MaterialSection/>
dd4hep: with plugin:DD4hep_XMLProcessor
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 28-Mar-2023 00:44:34 CEST-----------------------
An exception of category 'StdException' occurred while
   [0] Processing global begin Run run: 1
   [1] Prefetching for module OscarMTProducer/'g4SimHits'
   [2] Prefetching for EventSetup module MuonOffsetESProducer/'muonOffsetESProducer'
   [3] Prefetching for EventSetup module DDCompactViewESProducer/''
   [4] Calling method for EventSetup module DDDetectorESProducer/'DDDetectorESProducerFromDB'
Exception Message:
A std::exception was thrown.
An exception of category 'DD4CMS' occurred.
Exception Message:
Composite material "trackermaterial:T_Barium_Titanate" or "trackermaterial:T_Barium_Titanate" not yet defined.

dd4hep: Error interpreting XML nodes of type <CompositeMaterial/>
dd4hep: Error interpreting XML nodes of type <MaterialSection/>
dd4hep: with plugin:DD4hep_XMLProcessor
----- End Fatal Exception -------------------------------------------------
Expand to see more addon errors ...

@saumyaphor4252 saumyaphor4252 force-pushed the alca-130X_update_2023_GEM_geometry_in_MC_GTs branch from 1db7f4d to 7757cd1 Compare March 28, 2023 10:01
@cmsbuild
Copy link
Contributor

Pull request #41203 was updated. @cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please check and sign again.

@saumyaphor4252
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4bb521/31639/summary.html
COMMIT: 7757cd1
CMSSW: CMSSW_13_0_X_2023-03-27-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41203/31639/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 60 lines to the logs
  • Reco comparison results: 2242 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3554529
  • DQMHistoTests: Total failures: 2147
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3552360
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 1 / 47 workflows

@tvami
Copy link
Contributor

tvami commented Mar 28, 2023

DQMHistoTests: Total failures: 2147

This is mostly in 12434.0 which is where we expect changes. They are widespread, which is also expected for the geometry change

@tvami
Copy link
Contributor

tvami commented Mar 28, 2023

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@tvami
Copy link
Contributor

tvami commented Mar 28, 2023

urgent

  • as we just discussed at ORP this should go into 13_0_2 so it can be validated

@tvami
Copy link
Contributor

tvami commented Mar 28, 2023

backport of #41202

@perrotta
Copy link
Contributor

+1

  • As it was agreed at the ORP meeting on 28/03, next CMMSSW_13_0_2 will be used to validate these updates in the Run3 geometries for MC

@cmsbuild cmsbuild merged commit 87bd74b into cms-sw:CMSSW_13_0_X Mar 29, 2023
@saumyaphor4252 saumyaphor4252 deleted the alca-130X_update_2023_GEM_geometry_in_MC_GTs branch October 13, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants