Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the CUDAService from the HLT configuration [13.0.x] #40851

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Feb 22, 2023

PR description:

Remove the explicit CUDAService from the HLT configuration, and rely on ProcessAcceleratorCUDA to load it if necessary.

PR validation:

None.

Backport status

Backport of #40852 to 13.0.x for data taking.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 22, 2023

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_13_0_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

Remove the explicit CUDAService from the HLT configuration, and rely on
ProcessAcceleratorCUDA to load it if necessary.
@fwyzard fwyzard force-pushed the HLT_remove_CUDAService_130x branch from 4ea9707 to 237e5ce Compare February 22, 2023 19:56
@cmsbuild
Copy link
Contributor

Pull request #40851 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 22, 2023

backport #40852

@fwyzard fwyzard changed the title Remove the CUDAService from the HLT configuration Remove the CUDAService from the HLT configuration [13.0.x] Feb 22, 2023
@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 22, 2023

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-94a113/30819/summary.html
COMMIT: 237e5ce
CMSSW: CMSSW_13_0_X_2023-02-22-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40851/30819/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-94a113/30819/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-94a113/30819/git-merge-result

Comparison Summary

Summary:

  • You potentially added 7 lines to the logs
  • Reco comparison results: 21 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3529029
  • DQMHistoTests: Total failures: 26
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3528981
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

  • 13_1 version looks good in the IBs, proceeding to merge this.

@cmsbuild cmsbuild merged commit e4a95d9 into cms-sw:CMSSW_13_0_X Feb 23, 2023
@fwyzard fwyzard deleted the HLT_remove_CUDAService_130x branch March 9, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants