Remove the CUDAService from the HLT configuration

[fwyzard]

PR description:

Remove the explicit CUDAService from the HLT configuration, and rely on ProcessAcceleratorCUDA to load it if necessary.

PR validation:

None.

Backport status

To be backported to 13.0.x for data taking.

[fwyzard]

enable gpu

[fwyzard]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40852/34308

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

• HLTrigger/Configuration (hlt)

@Martin-Grunewald, @missirol can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[missirol]

Since no ConfDB 'migration' will take care of this removal, I would open a JIRA ticket to document the removal of this module in ConfDB (and we will then remove this customisation once the menus are updated in the release). Is this okay?

I guess any future menu without explicit CUDAService module, but with [..] import ProcessAcceleratorCUDA, should continue to work in plain CMSSW_13_0_0_pre4. Is this correct?

[fwyzard]

I guess any future menu without explicit CUDAService module, but with [..] import ProcessAcceleratorCUDA, should continue to work in plain CMSSW_13_0_0_pre4. Is this correct?

I think so, in any release since at least CMSSW_12_4_0 (I didn't check the git logs further).

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-664eaf/30820/summary.html
COMMIT: c258024
CMSSW: CMSSW_13_1_X_2023-02-22-1600/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40852/30820/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @fabiocos Update debug printouts for MTD in several packages, fix simulation LogDebug #40845

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-664eaf/30820/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-664eaf/30820/git-merge-result

RelVals-INPUT

• 25209.025209.0_QCD_FlatPt_15_3000HS_13/step2_QCD_FlatPt_15_3000HS_13.log
• 25208.025208.0_SMS-T1tttt_mGl-1500_mLSP-100_13/step2_SMS-T1tttt_mGl-1500_mLSP-100_13.log
• 25207.025207.0_NuGun_UP15/step2_NuGun_UP15.log

Expand to see more relval errors ...

• 25214.0
• 50200.0

Comparison Summary

Summary:

• You potentially added 35 lines to the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3528709
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3528684
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 19862
• DQMHistoTests: Total failures: 226
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 19636
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: found differences in 1 / 3 workflows

[missirol]

please test

The errors look like transient ones (and unrelated to this PR), but let's re-test to make sure.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-664eaf/30822/summary.html
COMMIT: c258024
CMSSW: CMSSW_13_1_X_2023-02-22-1600/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40852/30822/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @fabiocos Update debug printouts for MTD in several packages, fix simulation LogDebug #40845

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-664eaf/30822/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-664eaf/30822/git-merge-result

Comparison Summary

Summary:

• You potentially added 14 lines to the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3528709
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3528684
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 19862
• DQMHistoTests: Total failures: 262
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 19600
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: found differences in 3 / 3 workflows

[missirol]

+hlt

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1