Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run 3 jetid backport #40831

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Conversation

laurenhay
Copy link
Contributor

@laurenhay laurenhay commented Feb 21, 2023

PR description:
This PR is a backport to implement the new Run3 JetID criteria and makes them the default.

See #40710

PR validation:
Builds and formatting checked.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 21, 2023

A new Pull Request was created by @laurenhay (Lauren Hay) for CMSSW_13_0_X.

It involves the following packages:

  • Configuration/Eras (operations)
  • PhysicsTools/NanoAOD (xpog)
  • PhysicsTools/SelectorUtils (reconstruction)

@perrotta, @rappoccio, @swertz, @vlimant, @clacaputo, @cmsbuild, @mandrenguyen, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @AnnikaStein, @Martin-Grunewald, @missirol, @gpetruc, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@swertz
Copy link
Contributor

swertz commented Feb 21, 2023

enable nano

@swertz
Copy link
Contributor

swertz commented Feb 21, 2023

please test

@swertz
Copy link
Contributor

swertz commented Feb 21, 2023

type jetmet

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20788a/30771/summary.html
COMMIT: 311e018
CMSSW: CMSSW_13_0_X_2023-02-20-2300/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40831/30771/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 12 lines from the logs
  • Reco comparison results: 23 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3529029
  • DQMHistoTests: Total failures: 29
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3528978
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 10829
  • DQMHistoTests: Total failures: 18
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 10811
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
  • Checked 23 log files, 10 edm output root files, 11 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.31 2.232 2.232 0.000 ( +0.0% ) 9.57 9.60 -0.3% 1.534 1.615
2500.311 2.323 2.323 0.000 ( +0.0% ) 9.28 9.15 +1.4% 1.906 1.988
2500.312 2.277 2.277 0.000 ( +0.0% ) 9.36 9.39 -0.3% 1.889 1.987
2500.33 1.100 1.100 0.000 ( +0.0% ) 21.78 21.50 +1.3% 1.646 1.727
2500.331 1.394 1.394 0.000 ( +0.0% ) 15.96 15.97 -0.0% 1.793 1.882
2500.332 1.326 1.326 0.000 ( +0.0% ) 17.77 17.79 -0.1% 1.848 1.830
2500.401 2.139 2.139 -0.000 ( -0.0% ) 10.49 10.45 +0.4% 1.229 1.294
2500.501 1.711 1.711 -0.000 ( -0.0% ) 16.54 16.58 -0.3% 1.148 1.213
2500.511 1.124 1.124 -0.000 ( -0.0% ) 30.87 30.94 -0.2% 1.388 1.476
2500.601 2.050 2.050 -0.000 ( -0.0% ) 12.44 12.49 -0.4% 1.198 1.277

@swertz
Copy link
Contributor

swertz commented Feb 21, 2023

+1

@clacaputo
Copy link
Contributor

+reconstruction

-backport #40710

@perrotta
Copy link
Contributor

backport of #40710

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants