Include product instance name for the data product copied implicitly to host in Alpaka EDProducers

[makortel]

PR description:

@fwyzard Reported privately that in an Alpaka EDProducer that sets a product instance name for a product, the product instance name gets lost when the device-side product is implicitly copied to the host. This PR enhances the tests to catch the problem, and fixes the it. The PR also enhances the EventSetup side tests to exercise both the appendToDataLabel parameter, and a case where the product label is set explicitly in the user ESProducer code.

Needs to be rebased after a few other Alpaka-related PRs have gotten merged.

PR validation:

Unit tests run in machines with and without NVIDIA GPU.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40813/34253

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File HeterogeneousCore/AlpakaTest/plugins/alpaka/TestAlpakaStreamProducer.cc modified in PR(s): CUDA, ROCm and Alpaka-related updates [13.0.x] #40725

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

• HeterogeneousCore/AlpakaCore (heterogeneous)
• HeterogeneousCore/AlpakaTest (heterogeneous)

@cmsbuild, @makortel, @fwyzard can you please review it and eventually sign? Thanks.
@missirol, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[makortel]

(rebased on top of the topic branch of #40808)

[makortel]

enable gpu

[makortel]

@cmsbuild, please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40813/34255

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File HeterogeneousCore/AlpakaTest/plugins/alpaka/TestAlpakaStreamProducer.cc modified in PR(s): CUDA, ROCm and Alpaka-related updates [13.0.x] #40725

[cmsbuild]

Pull request #40813 was updated. @makortel, @fwyzard can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-326386/30724/summary.html
COMMIT: 6dead51
CMSSW: CMSSW_13_1_X_2023-02-17-1100/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40813/30724/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 34 lines from the logs
• Reco comparison results: 18 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3529029
• DQMHistoTests: Total failures: 936
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3528071
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 19862
• DQMHistoTests: Total failures: 64
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 19798
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: found differences in 3 / 3 workflows

[makortel]

• DQMHistoTests: Total failures: 936

Seems that #39803 is back

[makortel]

+heterogeneous

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1