[CXXMODULE] Remove root_12193 patch for rootmodule

[aandvalenzuela]

CXXMODULE iB fails when applying this patch. After checking it, I think it might not be needed anymore (See https://github.com/cms-sw/root/blob/cms/master/94b3064bb5/interpreter/cling/include/cling/std.modulemap#L376-L380)

[cmsbuild]

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for branch IB/CMSSW_13_1_X/rootmodule.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

[aandvalenzuela]

test parameters:

• full_cmssw = true

[aandvalenzuela]

please test

[davidlange6]

Right - that PR got merged into master. Thanks!

…

On Feb 20, 2023, at 11:04 AM, Andrea Valenzuela ***@***.***> wrote: CXXMODULE iB fails when applying this patch. After checking it, I think it might not be needed anymore (See https://github.com/cms-sw/root/blob/cms/master/94b3064bb5/interpreter/cling/include/cling/std.modulemap#L376-L380) You can view, comment on, or merge this pull request online at: #8326 Commit Summary • 2913837 Remove root_12193 patch for rootmodule File Changes (2 files) • M root.spec (2) • D root_12193.patch (26) Patch Links: • https://github.com/cms-sw/cmsdist/pull/8326.patch • https://github.com/cms-sw/cmsdist/pull/8326.diff — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-585d73/30744/summary.html
COMMIT: 2913837
CMSSW: CMSSW_13_1_CXXMODULE_X_2023-02-17-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8326/30744/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @mmusich usesResource in ConditionDBWriter cmssw#40793
• @bsunanda Phase2-hgx335O Try to introduce different lateral sizes of the components inside a silicon module of HGCal cmssw#40644
• @makortel Include product instance name for the data product copied implicitly to host in Alpaka EDProducers cmssw#40813
• @jeongeun Migrate consumesMany() to edm::GetterOfProducts() in GlobalHitsAnalyzer cmssw#40770
• @Dr15Jones Removed unused variables in SiPixelChargeReweightingAlgorithm cmssw#40805
• @missirol remove one HLT-related histogram from E/Gamma offline DQM cmssw#40788
• @missirol remove one HLT-related histogram from (Jet)MET offline DQM cmssw#40806

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-585d73/30744/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-585d73/30744/git-merge-result

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_CXXMODULE_X_2023-02-17-2300/src/Geometry/VeryForwardRPTopology/src/RPSimTopology.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_CXXMODULE_X_2023-02-17-2300/src/Geometry/VeryForwardRPTopology/src/RPTopology.cc
>> Building shared library tmp/el8_amd64_gcc11/src/Geometry/VeryForwardRPTopology/src/GeometryVeryForwardRPTopology/libGeometryVeryForwardRPTopology.so
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/bin/../lib/gcc/x86_64-redhat-linux-gnu/11.2.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lFWCoreParameterSet
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/bin/../lib/gcc/x86_64-redhat-linux-gnu/11.2.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lFWCorePluginManager
collect2: error: ld returned 1 exit status
gmake: *** [tmp/el8_amd64_gcc11/src/Geometry/VeryForwardRPTopology/src/GeometryVeryForwardRPTopology/libGeometryVeryForwardRPTopology.so] Error 1
Leaving library rule at Geometry/VeryForwardRPTopology
>> Leaving Package Geometry/VeryForwardRPTopology
>> Package Geometry/VeryForwardRPTopology built
>> Entering Package IOPool/Provenance


[smuzaffar]

as externals build so this looks good to go in ( module Ibs are broken anyway)