[13_0_X] Adding a check on the BS transverse widths in OnlineBeamSpotESProducer

[francescobrivio]

PR description:

Verbatim backport of #40744

Since the master was moved from 13_0_X to 13_1_X before the PR being merged,
this new PR provides the backport to 13_0_X needed for data taking.

PR validation:

Code compiles

Backport:

Backport of #40744

[francescobrivio]

backport of #40744

[cmsbuild]

A new Pull Request was created by @francescobrivio for CMSSW_13_0_X.

It involves the following packages:

• RecoVertex/BeamSpotProducer (reconstruction, alca)

@malbouis, @yuanchao, @ChrisMisan, @clacaputo, @cmsbuild, @saumyaphor4252, @tvami, @mandrenguyen, @francescobrivio can you please review it and eventually sign? Thanks.
@VourMa, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @missirol, @tocheng, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Adding a check on the BS transverse widths in OnlineBeamSpotESProducer #40744

[francescobrivio]

urgent

• to be included in 13_0_0

[francescobrivio]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f6ce68/30629/summary.html
COMMIT: 09d7995
CMSSW: CMSSW_13_0_X_2023-02-14-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40766/30629/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 31 lines from the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555972
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555949
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[mmusich]

hold

• Adding a check on the BS transverse widths in OnlineBeamSpotESProducer #40744 is not converged: some change requests are still to be implemented.

[cmsbuild]

Pull request has been put on hold by @mmusich
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[cmsbuild]

Pull request #40766 was updated. @malbouis, @yuanchao, @ChrisMisan, @clacaputo, @cmsbuild, @saumyaphor4252, @tvami, @mandrenguyen, @francescobrivio can you please check and sign again.

[francescobrivio]

hold

* [Adding a check on the BS transverse widths in OnlineBeamSpotESProducer #40744](https://github.com/cms-sw/cmssw/pull/40744) is not converged: some change requests are still to be implemented.

The comments have been implemented in 3857b55, the master PR will be updated soon as well.

[francescobrivio]

@cmsbuild please test

[mmusich]

unhold

[cmsbuild]

Pull request #40766 was updated. @malbouis, @yuanchao, @ChrisMisan, @clacaputo, @cmsbuild, @saumyaphor4252, @tvami, @mandrenguyen, @francescobrivio can you please check and sign again.

[francescobrivio]

@cmsbuild please test

• I have squashed and force-pushed so that this is identical to the master PR

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f6ce68/30706/summary.html
COMMIT: 7a6351b
CMSSW: CMSSW_13_0_X_2023-02-16-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40766/30706/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 7 lines to the logs
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3556272
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3556241
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

• tests pass

[francescobrivio]

@cms-sw/reconstruction-l2 a kind ping to review/sign this backport. Thanks!

[clacaputo]

+reconstruction

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1