Skip to content

Commit

Permalink
apply review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
francescobrivio committed Feb 15, 2023
1 parent 09d7995 commit 3857b55
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions RecoVertex/BeamSpotProducer/plugins/OnlineBeamSpotESProducer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class OnlineBeamSpotESProducer : public edm::ESProducer {
private:
const BeamSpotOnlineObjects* compareBS(const BeamSpotOnlineObjects* bs1, const BeamSpotOnlineObjects* bs2);
const BeamSpotOnlineObjects* checkSingleBS(const BeamSpotOnlineObjects* bs1);
const bool isGoodBS(const BeamSpotOnlineObjects* bs1);
bool isGoodBS(const BeamSpotOnlineObjects* bs1) const;

edm::ESGetToken<BeamSpotObjects, BeamSpotTransientObjectsRcd> const bsToken_;
edm::ESGetToken<BeamSpotOnlineObjects, BeamSpotOnlineHLTObjectsRcd> bsHLTToken_;
Expand All @@ -46,7 +46,7 @@ OnlineBeamSpotESProducer::OnlineBeamSpotESProducer(const edm::ParameterSet& p)
// get parameters
: timeThreshold_(p.getParameter<int>("timeThreshold")),
sigmaZThreshold_(p.getParameter<double>("sigmaZThreshold")),
sigmaXYThreshold_(p.getParameter<double>("sigmaXYThreshold")) {
sigmaXYThreshold_(p.getParameter<double>("sigmaXYThreshold") * 1E-4) {
auto cc = setWhatProduced(this);

fakeBS_.setBeamWidthX(0.1);
Expand Down Expand Up @@ -141,9 +141,9 @@ const BeamSpotOnlineObjects* OnlineBeamSpotESProducer::checkSingleBS(const BeamS
}

// This method is used to check the quality of the beamspot fit
const bool OnlineBeamSpotESProducer::isGoodBS(const BeamSpotOnlineObjects* bs1) {
if (bs1->sigmaZ() > sigmaZThreshold_ && bs1->beamType() == 2 && bs1->beamWidthX() > sigmaXYThreshold_ * 1E-4 &&
bs1->beamWidthY() > sigmaXYThreshold_ * 1E-4)
bool OnlineBeamSpotESProducer::isGoodBS(const BeamSpotOnlineObjects* bs1) const {
if (bs1->sigmaZ() > sigmaZThreshold_ && bs1->beamType() == 2 && bs1->beamWidthX() > sigmaXYThreshold_ &&
bs1->beamWidthY() > sigmaXYThreshold_)
return true;
else
return false;
Expand Down

0 comments on commit 3857b55

Please sign in to comment.