Adding a check on the BS transverse widths in OnlineBeamSpotESProducer #40744

dzuolo · 2023-02-10T13:26:02Z

PR description:

This PR adds a check on the BeamSpot transverse widths in OnlineBeamSpotESProducer. The producer checks the BS Fit produced by the two DQM clients and performs an arbitration. We are now adding a new condition (transverse widths larger than a certain threshold) to prevent the upload of payloads containing the results of fit that converged with unphysical values.

PR validation:

Code compiles.
The following commands have been run
scram b code-format
scram b code-checks

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Since the code runs online we propose not to have backports.

cmsbuild · 2023-02-10T13:34:42Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40744/34154

This PR adds an extra 12KB to repository

cmsbuild · 2023-02-10T13:35:07Z

A new Pull Request was created by @dzuolo (Davide Zuolo) for master.

It involves the following packages:

RecoVertex/BeamSpotProducer (reconstruction, alca)

@malbouis, @yuanchao, @ChrisMisan, @clacaputo, @cmsbuild, @saumyaphor4252, @tvami, @mandrenguyen, @francescobrivio can you please review it and eventually sign? Thanks.
@VourMa, @GiacomoSguazzoni, @JanFSchulte, @tocheng, @VinInn, @missirol, @rovere, @mmusich, @mtosi, @dgulhan, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

francescobrivio · 2023-02-10T13:56:09Z

@cmsbuild please test

mmusich

just a very picky comment...

mmusich · 2023-02-10T13:38:33Z

RecoVertex/BeamSpotProducer/plugins/OnlineBeamSpotESProducer.cc

      return bs1;
-    } else if (bs2->sigmaZ() >= bs1->sigmaZ() && bs2->beamType() == 2) {
+    } else if (bs2->sigmaZ() >= bs1->sigmaZ() && isGoodBS(bs2)) {
      return bs2;
    } else {
      edm::LogInfo("OnlineBeamSpotESProducer")


the log message that comes after this line could be updated to reflect the change in the logic.

Ciao Marco. I changed the log message in "1ec86e9"

cmsbuild · 2023-02-10T16:24:28Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-148e6f/30581/summary.html
COMMIT: 16999c1
CMSSW: CMSSW_13_0_X_2023-02-10-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40744/30581/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 9 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3555972
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3555944
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 213 log files, 164 edm output root files, 49 DQM output files
TriggerResults: no differences found

francescobrivio · 2023-02-10T17:14:09Z

+1

I privately discussed with the author abouth the changes and it's +1 from BeamSpot (and alca) point of view
Tests after first commit are clean. And since the last commit only changes a log message I don't think we need to re-run them.

cmsbuild · 2023-02-10T17:17:01Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40744/34159

This PR adds an extra 12KB to repository

tvami · 2023-02-16T18:02:35Z

@cmsbuild , please test

cmsbuild · 2023-02-16T18:08:56Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40744/34226

This PR adds an extra 8KB to repository

cmsbuild · 2023-02-16T18:09:22Z

Pull request #40744 was updated. @malbouis, @yuanchao, @ChrisMisan, @clacaputo, @saumyaphor4252, @tvami, @mandrenguyen, @francescobrivio can you please check and sign again.

cmsbuild · 2023-02-16T22:42:47Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-148e6f/30680/summary.html
COMMIT: 49ad628
CMSSW: CMSSW_13_1_X_2023-02-16-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40744/30680/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-148e6f/30680/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-148e6f/30680/git-merge-result

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

You potentially removed 6 lines from the logs
Reco comparison results: 35 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3556272
DQMHistoTests: Total failures: 46
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3556204
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 213 log files, 164 edm output root files, 49 DQM output files
TriggerResults: no differences found

tvami · 2023-02-16T22:50:32Z

@cmsbuild , please test

cmsbuild · 2023-02-17T01:38:13Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-148e6f/30692/summary.html
COMMIT: 49ad628
CMSSW: CMSSW_13_1_X_2023-02-16-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40744/30692/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-148e6f/30692/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-148e6f/30692/git-merge-result

Comparison Summary

Summary:

You potentially removed 6 lines from the logs
Reco comparison results: 26 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3556272
DQMHistoTests: Total failures: 37
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3556213
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 213 log files, 164 edm output root files, 49 DQM output files
TriggerResults: no differences found

francescobrivio · 2023-02-17T10:55:44Z

+1

clacaputo · 2023-02-17T14:47:27Z

+reconstruction

cmsbuild · 2023-02-17T14:47:54Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2023-02-17T17:56:57Z

+1

cmsbuild added this to the CMSSW_13_0_X milestone Feb 10, 2023

cmsbuild added reconstruction-pending alca-pending pending-signatures tests-pending orp-pending code-checks-pending tracking labels Feb 10, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 10, 2023

cmsbuild added tests-started and removed tests-pending labels Feb 10, 2023

mmusich reviewed Feb 10, 2023

View reviewed changes

cmsbuild added tests-approved tests-pending code-checks-pending and removed tests-started tests-approved code-checks-approved labels Feb 10, 2023

cmsbuild added alca-approved tests-started and removed alca-pending tests-pending labels Feb 10, 2023

cmsbuild removed the code-checks-pending label Feb 10, 2023

cmsbuild added tests-started and removed tests-pending labels Feb 16, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 16, 2023

cmsbuild added tests-rejected and removed tests-started labels Feb 16, 2023

cmsbuild added tests-started and removed tests-rejected labels Feb 16, 2023

cmsbuild added tests-approved and removed tests-started labels Feb 17, 2023

cmsbuild added alca-approved and removed alca-pending labels Feb 17, 2023

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Feb 17, 2023

cmsbuild added orp-approved and removed orp-pending labels Feb 17, 2023

cmsbuild merged commit 9fa71b4 into cms-sw:master Feb 17, 2023

cmsbuild mentioned this pull request Feb 18, 2023

Displaced regional tracking iteration #40643

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding a check on the BS transverse widths in OnlineBeamSpotESProducer #40744

Adding a check on the BS transverse widths in OnlineBeamSpotESProducer #40744

dzuolo commented Feb 10, 2023

cmsbuild commented Feb 10, 2023

cmsbuild commented Feb 10, 2023

francescobrivio commented Feb 10, 2023

mmusich left a comment

mmusich Feb 10, 2023

dzuolo Feb 10, 2023

cmsbuild commented Feb 10, 2023

francescobrivio commented Feb 10, 2023

cmsbuild commented Feb 10, 2023

tvami commented Feb 16, 2023

cmsbuild commented Feb 16, 2023

cmsbuild commented Feb 16, 2023

cmsbuild commented Feb 16, 2023

tvami commented Feb 16, 2023

cmsbuild commented Feb 17, 2023

francescobrivio commented Feb 17, 2023

clacaputo commented Feb 17, 2023

cmsbuild commented Feb 17, 2023

perrotta commented Feb 17, 2023

Adding a check on the BS transverse widths in OnlineBeamSpotESProducer #40744

Adding a check on the BS transverse widths in OnlineBeamSpotESProducer #40744

Conversation

dzuolo commented Feb 10, 2023

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Feb 10, 2023

cmsbuild commented Feb 10, 2023

francescobrivio commented Feb 10, 2023

mmusich left a comment

Choose a reason for hiding this comment

mmusich Feb 10, 2023

Choose a reason for hiding this comment

dzuolo Feb 10, 2023

Choose a reason for hiding this comment

cmsbuild commented Feb 10, 2023

Comparison Summary

francescobrivio commented Feb 10, 2023

cmsbuild commented Feb 10, 2023

tvami commented Feb 16, 2023

cmsbuild commented Feb 16, 2023

cmsbuild commented Feb 16, 2023

cmsbuild commented Feb 16, 2023

RelVals-INPUT

Comparison Summary

tvami commented Feb 16, 2023

cmsbuild commented Feb 17, 2023

Comparison Summary

francescobrivio commented Feb 17, 2023

clacaputo commented Feb 17, 2023

cmsbuild commented Feb 17, 2023

perrotta commented Feb 17, 2023