Run3-sim138 Changes which will allow the usage of new shower library (the cfi file in Geometry/HcalSimData will be modified once the new library appears)

[bsunanda]

PR description:

Changes which will allow the usage of new shower library (the cfi file in Geometry/HcalSimData will be modified once the new library appears)

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40703/34064

• This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40703/34064/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40703/34064/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40703/34065

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• SimG4CMS/Calo (simulation)
• SimG4CMS/ShowerLibraryProducer (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@felicepantaleo, @rovere, @thomreis, @simonepigazzini, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

test parameters:

• pull_request = [SimG4CMS-Calo] Update HFShowerLibrary_run3_v7 cmsdist#8292

[smuzaffar]

@bsunanda , feel free to update the cfi file to use the new shower library. #40703 (comment) show allow bot to pickup the new library when tests for this PR will run

[bsunanda]

@smuzaffar Committed the changes needed

[bsunanda]

@cmsbuild Please test

[smuzaffar]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40703/34069

• This PR adds an extra 28KB to repository

[cmsbuild]

Pull request #40703 was updated. @civanch, @mdhildreth can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6a1270/30579/summary.html
COMMIT: f09815a
CMSSW: CMSSW_13_0_X_2023-02-09-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40703/30579/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @nurfikri89 [QGL, JMENanoAOD] PUPPI-compatible QGTagger producer #40667
• @francescobrivio Add try/catch in OnlineBeamMonitor plugin to resolve runtime error #40716
• @fabferro PPS pixel track reco in bad pots #40683
• @rovere Fix runTheMatrix interactive and add tests. #40596
• @makortel Allow ProcessAccelerators to delete Services #40736

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6a1270/30579/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6a1270/30579/git-merge-result

Comparison Summary

Summary:

• You potentially added 3 lines to the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555972
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555946
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[civanch]

+1

by default the old v6 version of SL is used, so there is full regression and this PR may be merged allowing further investigation of v7.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

hold

[rappoccio]

This is on hold because it is fully signed but it seems it is not resolved.

[cmsbuild]

Pull request has been put on hold by @rappoccio
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[civanch]

@rappoccio , in our discussion we agreed to merge this PR and resolve problem in the following PR. Technically it is easier, especially because PR was moved from 13_0 to 13_1. This PR includes reasonable update of the current code and do not provide any problem to any WF.

[perrotta]

@rappoccio commit f09815a reverts the version of the HF shower library to previous version v6: therefore as of now this PR does not affect any workflow, but it allows studies on that version of the shower library to be performed in the development release

[perrotta]

unhold

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1