-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ProcessAccelerators to delete Services #40736
Allow ProcessAccelerators to delete Services #40736
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40736/34140
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages:
@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bedbad/30548/summary.html Comparison SummarySummary:
|
@makortel @perrotta @rappoccio can we have this in pre4 ? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
#40725 deletes an existing Service in
ProcessAccelerator.apply()
, which was noticed in cms-sw/cmsdist#8301 (comment) to not work, because theProcess
is wrapped intoProcessForProcessAccelerator
when passed toProcessAccelerator.apply()
, and theProcessForProcessAccelerator
did not implement__delattr__()
. This PR implements the__dellattr__()
.PR validation:
Added unit test succeeds. A simple test configuration reproducing the behavior in cms-sw/cmsdist#8301 (comment) succeeds.