Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ProcessAccelerators to delete Services #40736

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Feb 9, 2023

PR description:

#40725 deletes an existing Service in ProcessAccelerator.apply(), which was noticed in cms-sw/cmsdist#8301 (comment) to not work, because the Process is wrapped into ProcessForProcessAccelerator when passed to ProcessAccelerator.apply(), and the ProcessForProcessAccelerator did not implement __delattr__(). This PR implements the __dellattr__().

PR validation:

Added unit test succeeds. A simple test configuration reproducing the behavior in cms-sw/cmsdist#8301 (comment) succeeds.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40736/34140

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2023

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

  • FWCore/ParameterSet (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@missirol, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

makortel commented Feb 9, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bedbad/30548/summary.html
COMMIT: ab96cfe
CMSSW: CMSSW_13_0_X_2023-02-09-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40736/30548/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 30 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555852
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555824
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@fwyzard
Copy link
Contributor

fwyzard commented Feb 9, 2023

@makortel @perrotta @rappoccio can we have this in pre4 ?
thanks !

@makortel
Copy link
Contributor Author

makortel commented Feb 9, 2023

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants