PPS pixel track reco in bad pots

[fabferro]

PR description:

This PR generalizes what reported in:
https://indico.cern.ch/event/1176711/contributions/4945189/attachments/2474024/4244960/pps-badpot-studies_3.pdf

The generalization is that the 2-plane-track reconstruction can be activated using the channel mask in the DB.
Normally the track reconstruction is done using at least 3 planes out of 6. In the unlikely case 4/6 planes are damaged no track is normally recostructed.
With this PR, a special 2 plane reconstruction is introduced to recover tracks also in these pathologic situations.
The dedicated 2-plane-track reconstruction is activated if 4/6 planes are fully masked in the channel mask inside DB.
This strategy recovers tracks, is double counting safe, is triggered by DB objects (channel mask).

PR validation:

Private tests on Run3 and Run2 data show that the special reco is triggered if and only if 4/6 plane in a detector package are masked.
136 WFs with GT conditions show no changes, as expected (no 4 masked planes condition in any current GT).

No backport currently expected.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40683/34038

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @fabferro (Fabrizio Ferro) for master.

It involves the following packages:

• RecoPPS/Local (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@missirol, @forthommel, @grzanka this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

-1

Failed Tests: ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be146a/30408/summary.html
COMMIT: e30b3b3
CMSSW: CMSSW_13_0_X_2023-02-05-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40683/30408/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40683/34073

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #40683 was updated. @cmsbuild, @mandrenguyen, @clacaputo can you please check and sign again.

[mandrenguyen]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40683/34144

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #40683 was updated. @cmsbuild, @mandrenguyen, @clacaputo can you please check and sign again.

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be146a/30560/summary.html
COMMIT: b71c4b7
CMSSW: CMSSW_13_0_X_2023-02-09-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40683/30560/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 8 lines to the logs
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555852
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555827
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+reconstruction
resign. I'm ok with not changing the label, if it's ok with @perrotta

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1