-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PPS DQM error plots #40688
PPS DQM error plots #40688
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40688/34044
|
A new Pull Request was created by @fabferro (Fabrizio Ferro) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
-1 Failed Tests: RelVals RelVals-INPUT RelVals
Expand to see more relval errors ...RelVals-INPUT |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40688/34075
|
Pull request #40688 was updated. @emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-878101/30439/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
If you need this code for the upcoming data taking period, could you please provide a backport to 12_6? |
+1 |
@emanueleusai Ok. Does this mean that I also have to backport PR #40660 that fixes a bug in error identification at the Event filter level? |
apologies, my language wasn't precise enough. The backport is needed is you need this PR for the upcoming MWGR. If you need it only for actual collision data, assuming we will use 13_X for that, then a backport to 12_6 is not needed. |
Ah, ok. Then I'll do no backport. |
PR description:
This PR introduces new plots for monitoring the errors in PPS Pixel data taking and unpacking.
The plots are created per FED and per DetId to ease the error understanding and debugging.
PR validation:
Use of Run2 data via 136 WFs