PPS pixel bug fix in error filling #40660
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40660/33989
|
|
A new Pull Request was created by @fabferro (Fabrizio Ferro) for master. It involves the following packages:
@malbouis, @yuanchao, @ChrisMisan, @clacaputo, @cmsbuild, @saumyaphor4252, @tvami, @mandrenguyen, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
-1 Failed Tests: RelVals-INPUT RelVals-INPUTThe relvals timed out after 4 hours. Comparison SummarySummary:
|
|
It seems relvals are failing because of unreachable input files. |
|
@cmsbuild please test |
Relval timeouts happen from time to time. Let's try again! |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0fed64/30330/summary.html Comparison SummarySummary:
|
|
type bugfix |
|
+alca
|
|
+reconstruction |
cmsbuild
added
reconstruction-approved
fully-signed
and removed
reconstruction-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
| auto rawId = rocp.rawId(); | ||
|
|
||
| detDigis = &digis.find_or_insert(rawId); | ||
| if ((*detDigis).empty()) | ||
| (*detDigis).data.reserve(32); // avoid the first relocations | ||
| } | ||
|
|
||
| if (skipROC || rocp.rawId() == 0) |
There was a problem hiding this comment.
@fabferro , just for checking: is it correct that skipROC is defined outside the loop, i.e. it remains set at the value taken during the previous iterations in the loop over word's?
There was a problem hiding this comment.
Thanks Andrea for the question. The use of this flag is very delicate. The way it's assumed to work is that if it happens to be set true (i.e. a roc chip behaving badly) all the words from that roc are skipped. The flag can change inside the loop when the roc number changes (see lines 156-162) and the new roc is checked.
|
+1 |
PR description:
This PR is a bug fix in filling the persistent information about the errors coming from PPS Pixels during the data unpacking.
Data unpacking is not affected, only the way errors are decoded.
This PR is needed by a forthcoming PR to update the PPS Pixel DQM in order to display errors.
PR validation:
Validation has been done reprocessing Run-3 data (AlCaPPS data of run 355921, ~1M events) and running WF 136.892 of RunThematrix.
The tests reported no changes in unpacked data, a part from the desired new error encoding.
No backport needed.