Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 125X] OS requirement for Triple Muon seeds in the uGT emulator #40129

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

elfontan
Copy link
Contributor

Backport of #40060 to CMSSW 12_5_X.

PR description:

This PR contains a fix in the correlation class to handle the three-body conditions in order to include the possibility to read the OS requirement for TripleMu seeds with the three-muon invariant mass requirement.
Reference PR: #33911.

PR validation:

Basic tests performed successfully starting from CMSSW_12_5_2_patch1.

cmsrel CMSSW_12_5_2_patch1
cd CMSSW_12_5_2_patch1/src
cmsenv
git cms-addpkg L1Trigger/L1TGlobal
Added relevant files in L1Trigger/L1TGlobal.
scram b distclean
git cms-checkdeps -a -A
scram b -j 8
scram build code-checks
scram build code-format

…u seeds with the three-muon invariant mass requirement (final)
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 22, 2022

A new Pull Request was created by @elfontan (Elisa Fontanesi) for CMSSW_12_5_X.

It involves the following packages:

  • L1Trigger/L1TGlobal (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@elfontan elfontan changed the title [Backport] OS requirement for Triple Muon seeds in the uGT emulator [Backport 125X] OS requirement for Triple Muon seeds in the uGT emulator Nov 22, 2022
@elfontan elfontan marked this pull request as ready for review November 22, 2022 14:41
@epalencia
Copy link
Contributor

Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-013c86/29181/summary.html
COMMIT: ae20cb1
CMSSW: CMSSW_12_5_X_2022-11-22-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40129/29181/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3734871
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3734841
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 216 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@cecilecaillol
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cecilecaillol
Copy link
Contributor

backport of #33911

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 685bb88 into cms-sw:CMSSW_12_5_X Nov 22, 2022
@elfontan elfontan deleted the EF_3MUOS_backport125X branch January 19, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants