-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OS requirement for Triple Muon seeds in the uGT emulator #40060
Conversation
…u seeds with the three-muon invariant mass requirement
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40060/33034
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
…u seeds with the three-muon invariant mass requirement (2)
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40060/33036
|
A new Pull Request was created by @elfontan (Elisa Fontanesi) for master. It involves the following packages:
@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40060/33049
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40060/33051 |
-1 Failed Tests: UnitTests RelVals-INPUT Unit TestsI found errors in the following unit tests: ---> test test-das-selected-lumis had ERRORS RelVals-INPUTThe relvals timed out after 4 hours. Comparison SummarySummary:
|
please test (relvals timed out) |
-1 Failed Tests: RelVals-INPUT RelVals-INPUTThe relvals timed out after 4 hours.
Comparison SummarySummary:
|
please test (relvals timed out) |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-437337/29156/summary.html Comparison SummarySummary:
|
+l1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This PR contains a fix in the correlation class to handle the three-body conditions in order to include the possibility to read the OS requirement for TripleMu seeds with the three-muon invariant mass requirement.
Reference PR: #33911.
Note that two backports of this PR followed the update of CMSSW_126X. The PR have been backported to the OSW as well.
The preparation and online deployment of the new 124X release (CMSSW_12_4_11_patch2) for the last days of the 2022 data-taking have been requested: #40137.
PR validation:
Two special menu have been created for the validation of the updates:
CMSSW release used for tests: CMSSW_12_6_0_pre4.
L1Ntuples have been created re-emulating the uGT step to take into account the new menu and the final countings have been checked in three scenarios:
Final tests have been performed by producing test vectors based on the above mentioned L1 menu and checking the agreement of the firmware and emulator response.
The run used for the test is 359661 (LS=43), that contains a few cases useful for the debug as pointed out in CMSLITDPG-960:
/store/data/Run2022E/EphemeralHLTPhysics0/RAW/v1/000/359/661/00000/355c33ec-6253-4590-bc11-94e0ce1b45be.root
.