Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS requirement for Triple Muon seeds in the uGT emulator #40060

Merged
merged 5 commits into from
Nov 21, 2022

Conversation

elfontan
Copy link
Contributor

@elfontan elfontan commented Nov 14, 2022

This PR contains a fix in the correlation class to handle the three-body conditions in order to include the possibility to read the OS requirement for TripleMu seeds with the three-muon invariant mass requirement.
Reference PR: #33911.

Note that two backports of this PR followed the update of CMSSW_126X. The PR have been backported to the OSW as well.

The preparation and online deployment of the new 124X release (CMSSW_12_4_11_patch2) for the last days of the 2022 data-taking have been requested: #40137.

PR validation:

Two special menu have been created for the validation of the updates:

  1. baseline L1Menu_Collisions2022_v1_3_0 + two new seeds as copy of bits 82-83 with an additional OS requirement
  2. a reduced menu containing only TauTo3Mu-type seeds with and without opposite sign requirement.

CMSSW release used for tests: CMSSW_12_6_0_pre4.

L1Ntuples have been created re-emulating the uGT step to take into account the new menu and the final countings have been checked in three scenarios:

  • Default uGT emulator
  • Updated uGT emulator adding the cut for all cases involving the three body invariant mass: same countings in default bits and new bits with the expected reduction by the removal of the three SS muon events causing the high rate.
  • Updated uGT emulator adding the cut for cases involving the three body invariant mass with an OS requirement parsed from the xml menu: reduction as expected ONLY in the new seeds containing the OS requirement.

Final tests have been performed by producing test vectors based on the above mentioned L1 menu and checking the agreement of the firmware and emulator response.
The run used for the test is 359661 (LS=43), that contains a few cases useful for the debug as pointed out in CMSLITDPG-960:
/store/data/Run2022E/EphemeralHLTPhysics0/RAW/v1/000/359/661/00000/355c33ec-6253-4590-bc11-94e0ce1b45be.root.

…u seeds with the three-muon invariant mass requirement
@cmsbuild cmsbuild added this to the CMSSW_12_6_X milestone Nov 14, 2022
@elfontan elfontan changed the title Fix to include the possibility to read the OS requirement for TripleM… OS requirement for Triple Muon seeds in the uGT emulator Nov 14, 2022
@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40060/33034

  • This PR adds an extra 36KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

…u seeds with the three-muon invariant mass requirement (2)
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40060/33036

  • This PR adds an extra 40KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @elfontan (Elisa Fontanesi) for master.

It involves the following packages:

  • L1Trigger/L1TGlobal (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40060/33049

  • This PR adds an extra 44KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40060/33051

  • This PR adds an extra 44KB to repository

  • Found files with invalid states:

    • L1Trigger/L1TGlobal/testVectorCode_data.py:

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-437337/29103/summary.html
COMMIT: 3f952d5
CMSSW: CMSSW_12_6_X_2022-11-17-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40060/29103/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3417167
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3417142
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cecilecaillol
Copy link
Contributor

please test

(relvals timed out)

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-437337/29112/summary.html
COMMIT: 3f952d5
CMSSW: CMSSW_12_6_X_2022-11-18-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40060/29112/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

  • 4.64.6_MinimumBias2010A+MinimumBias2010A+RECOSKIMALCA+HARVESTDR1/step2_MinimumBias2010A+MinimumBias2010A+RECOSKIMALCA+HARVESTDR1.log

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3417167
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3417139
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cecilecaillol
Copy link
Contributor

please test

(relvals timed out)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-437337/29156/summary.html
COMMIT: 3f952d5
CMSSW: CMSSW_12_6_X_2022-11-20-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40060/29156/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3417239
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3417214
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cecilecaillol
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants