Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1T uGT: Three body invariant mass for muons #33911

Merged

Conversation

elfontan
Copy link
Contributor

PR description:

Development of a new condition class to deal with a three-body correlation condition (starting from CorrCondition and CorrWithOverlapRemovalCondition as a model): CorrThreeBodyCondition and CorrelationThreeBodyTemplate.
Based on the version of the UTM libraries utm_0.8.1: https://gitlab.cern.ch/cms-l1t-utm/utm/-/tree/utm_0.8.1.
New parseCorrelation function needed in the TriggerMenuParser. Minor changes needed in the L1TGlobalProducer, GlobalBoard, TruggerMenu, GlobalCondition, GlobalDefinitions.

PR validation:

  1. Tests performed by producing test vectors using a dedicated L1 Menu with four algorithms requiring three muons with different pT cuts and a threshold on the three-muon invariant mass: successful comparison with triggers from the firmware.
    CMSSW release used for tests: CMSSW_12_0_X_2021-05-24-2300.
  2. Test at the HLT level to verify that the correct information about the objects that caused the decision is correctly saved and used: a generic triple muon HLT path can be seeded by L1 triggers with a three-body invariant mass requirement.
    STEPS:
    - Private production of a small RAW-DIGI ZZTo4Mu sample (100 events) using Run 3 conditions
    - Production of a dedicated HLT menu in ConfDB including FirstPath, FinalPath, and a generic TripleMu seed (HLT_TripleMu_10_5_5_DZ_v10) with modified L1 seeds as Logical Expression:
    /users/elfontan/ThreeMuInvMassTest/TriMuInvarianMass1120/V4
    - HLT configuration and uGT emulator run with a dedicated L1 test menu:
    [... --l1-emulator uGT --mc --l1Xml L1Menu_test_mass_3_body_reduced_v2.xml"]
  3. Some final checks:
    - scram build code-format #Ensure that the code conforms to CMSSW standards
    - scram b -j8
    - runTheMatrix.py -l 11634.0

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33911/22979

  • This PR adds an extra 424KB to repository

  • Found files with invalid states:

    • L1Trigger/L1TGlobal/data/Luminosity/startup/L1Menu_test_mass_3_body_reduced_v2.xml:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @elfontan (Elisa Fontanesi) for master.

It involves the following packages:

L1Trigger/L1TGlobal

@cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cecilecaillol
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-92449d/15466/summary.html
COMMIT: 228ef8d
CMSSW: CMSSW_12_0_X_2021-05-30-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33911/15466/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation warning when building: See details on the summary page.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33911/23004

  • This PR adds an extra 424KB to repository

  • Found files with invalid states:

    • L1Trigger/L1TGlobal/data/Luminosity/startup/L1Menu_test_mass_3_body_reduced_v2.xml:

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2021

Pull request #33911 was updated. @cmsbuild, @rekovic, @cecilecaillol can you please check and sign again.

@cecilecaillol
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33911/23113

  • This PR adds an extra 36KB to repository

  • Found files with invalid states:

    • L1Trigger/L1TGlobal/data/Luminosity/startup/L1Menu_test_mass_3_body_reduced_v2.xml:

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2021

Pull request #33911 was updated. @cmsbuild, @rekovic, @cecilecaillol can you please check and sign again.

@qliphy
Copy link
Contributor

qliphy commented Jun 7, 2021

thanks @elfontan
@cecilecaillol Would you mind check and sign again if the changes looks ok to you?

@cecilecaillol
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-92449d/15715/summary.html
COMMIT: 4ec2873
CMSSW: CMSSW_12_0_X_2021-06-06-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33911/15715/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2648335
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2648312
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@qliphy
Copy link
Contributor

qliphy commented Jun 8, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants