Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move DiMuonMassBiasClient to a regular harvesting path #39217

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 26, 2022

PR description:

Inspired by the discussion at #39180 (comment) I move the DiMuonMassBiasClient to a regular harvesting path, actually into the DQMHarvestMuon sequence which as per autoDQM is run in the @muon sequence

'muon': ['DQMOfflineMuon',
'PostDQMOffline',
'DQMHarvestMuon+DQMCertMuon'],

that would be run at Tier-0 for the Muon PD (cf also: https://github.com/dmwm/T0/blob/0f4f9d27c5366da57c456c4ae01da81c75524595/etc/ProdOfflineConfiguration.py#L698)

I profit of this PR to remove remove useless DMQToken produce and consumes as pointed out in #39180 (comment)

PR validation:

Run successfully several workflows that were failing before issue #39180 was solved in threading mode:

runTheMatrix.py -nel 1000.0,10042.0,10842.0 -j 8 -t 4

EDIT:
unfortunately I could not find a RelVal workflow in the matrix that mimics Tier0 in this respect (i.e. that runs ALCA:TkAlDiMuonAndVertex in the same step as DQM and then a regular harvesting, so I've created one for this purpose: 1002.4.

after that I've tested with :

runTheMatrix.py -l 1002.4 -t 4 -j 8 --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but will need to be backported.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39217/31834

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • DQMOffline/Alignment (dqm)
  • DQMOffline/Configuration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@threus, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Aug 26, 2022

enable threading

@mmusich
Copy link
Contributor Author

mmusich commented Aug 26, 2022

test parameters:

  • workflow = 10042.0,10842.0

@mmusich
Copy link
Contributor Author

mmusich commented Aug 26, 2022

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39217/31841

  • This PR adds an extra 24KB to repository

@mmusich
Copy link
Contributor Author

mmusich commented Aug 26, 2022

test parameters:

  • enable_test = threading
  • workflows_threading = 10042.0,10842.0

@mmusich
Copy link
Contributor Author

mmusich commented Aug 26, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

Pull request #39217 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Aug 29, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-31d783/27162/summary.html
COMMIT: 9b3144c
CMSSW: CMSSW_12_6_X_2022-08-28-2300/el8_amd64_gcc10
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39217/27162/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-31d783/1002.4_RunDoubleMuon2022B+RunDoubleMuon2022B+TIER0PROMPTRUN3+HARVESTPROMPTRUN3

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3695708
  • DQMHistoTests: Total failures: 20
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3695666
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@kskovpen
Copy link
Contributor

+pdmv

Thanks Marco

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

  • Wouldn't it be worth adding the newly created 1002.4 workflow into the matrix used regularly for the PR tests, if it really mimics Tier0?

@cmsbuild cmsbuild merged commit 996b91b into cms-sw:master Aug 30, 2022
@mmusich
Copy link
Contributor Author

mmusich commented Aug 30, 2022

Wouldn't it be worth adding the newly created 1002.4 workflow into the matrix used regularly for the PR tests, if it really mimics Tier0?

arguably yes, and perhaps we should add also 1001.3 and 1002.3

@srimanob
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants