-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce DiMuonMassBiasClient
and use in ALCARECOTkAlDiMuonAndVertexDQM
#39148
Conversation
…asClient, update sequence run in alcareco production, update unit tests
type bug-fix, new-feature, trk |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39148/31724
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc9090/27015/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This PR caused many workflows to fail in IB multithreaded tests because |
DiMuMassConfiguration_(iConfig.getParameter<edm::ParameterSet>("DiMuMassConfig")) {} | ||
DiMuMassConfiguration_(iConfig.getParameter<edm::ParameterSet>("DiMuMassConfig")) { | ||
produces<DQMToken, edm::Transition::EndRun>("DQMGenerationDiMuonMassBiasMonitorRun"); | ||
produces<DQMToken, edm::Transition::EndLuminosityBlock>("DQMGenerationDiMuonMassBiasMonitorLumi"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmusich Did you have a specific reason to not use the existing DQMToken
functionality in the DQM base classes?
cmssw/DQMServices/Core/interface/DQMEDAnalyzer.h
Lines 57 to 58 in f3a1901
runToken_ = this->template produces<DQMToken, edm::Transition::EndRun>("DQMGenerationRecoRun"); | |
lumiToken_ = this->template produces<DQMToken, edm::Transition::EndLuminosityBlock>("DQMGenerationRecoLumi"); |
cmssw/DQMServices/Core/interface/DQMEDHarvester.h
Lines 79 to 95 in f3a1901
// Use explicitly specified inputs, but if there are none... | |
auto inputtags = | |
iConfig.getUntrackedParameter<std::vector<edm::InputTag>>("inputMEs", std::vector<edm::InputTag>()); | |
if (inputtags.empty()) { | |
// ... use all RECO MEs. | |
inputtags.push_back(edm::InputTag("", inputgeneration + "Job")); | |
inputtags.push_back(edm::InputTag("", inputgeneration + "Run")); | |
inputtags.push_back(edm::InputTag("", inputgeneration + "Lumi")); | |
} | |
jobmegetter_ = edm::GetterOfProducts<DQMToken>(edm::VInputTagMatch(inputtags), this, edm::InProcess); | |
runmegetter_ = edm::GetterOfProducts<DQMToken>(edm::VInputTagMatch(inputtags), this, edm::InRun); | |
lumimegetter_ = edm::GetterOfProducts<DQMToken>(edm::VInputTagMatch(inputtags), this, edm::InLumi); | |
callWhenNewProductsRegistered([this](edm::BranchDescription const &bd) { | |
jobmegetter_(bd); | |
runmegetter_(bd); | |
lumimegetter_(bd); | |
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you have a specific reason to not use the existing DQMToken functionality in the DQM base classes?
those were a relic from a previous stage of development in which this module was an edm::EDAnalyzer
and not a DQMEDHarvester
. That line of development was abandoned as the legacy modules are anyway deprecated.
I removed the useless statements in a5bab3b as part of #39217
PR description:
This PR is a follow-up to PR #39128 and adds a client
DQMEDHarvester
to create profiles of the mass bias vs track kinematics, based on the 2DMonitorElement
s introduced there.I profit of this PR to introduce a bug-fix in commit 2456648 in order to protect vertex tool compatibility failures with a try/catch mechanism.
Running privately on data the following exception was observed if not protected:
cmssw/RecoVertex/VertexTools/src/VertexDistance3D.cc
Lines 57 to 60 in 1ce6a20
PR validation:
Run the (augmented) unit tests of this package and also run manually on 2022C data obtaining the fits at this link.
The resulting DQM file has been uploaded to a private GUI that is available by:
and visiting:
https://tinyurl.com/2pwdox97
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, but will need to be backported.