Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce DiMuonMassBiasClient and use in ALCARECOTkAlDiMuonAndVertexDQM #39148

Merged
merged 3 commits into from
Aug 24, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 23, 2022

PR description:

This PR is a follow-up to PR #39128 and adds a client DQMEDHarvester to create profiles of the mass bias vs track kinematics, based on the 2D MonitorElements introduced there.
I profit of this PR to introduce a bug-fix in commit 2456648 in order to protect vertex tool compatibility failures with a try/catch mechanism.
Running privately on data the following exception was observed if not protected:

bool ifail = !error.InvertChol();
if (ifail) {
throw cms::Exception("VertexDistance3D::matrix inversion problem");
}

PR validation:

Run the (augmented) unit tests of this package and also run manually on 2022C data obtaining the fits at this link.
The resulting DQM file has been uploaded to a private GUI that is available by:

 ssh -NL 8060:localhost:8060 <USER>@lxplus724.cern.ch

and visiting:

https://tinyurl.com/2pwdox97

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but will need to be backported.

@mmusich
Copy link
Contributor Author

mmusich commented Aug 23, 2022

type bug-fix, new-feature, trk

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39148/31724

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • DQMOffline/Alignment (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Aug 23, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc9090/27015/summary.html
COMMIT: 7863ffd
CMSSW: CMSSW_12_5_X_2022-08-23-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39148/27015/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3693084
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3693059
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.008 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): 0.004 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 1000.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Aug 24, 2022

+1

@makortel
Copy link
Contributor

This PR caused many workflows to fail in IB multithreaded tests because DiMuonMassBiasClient does not support concurrent lumis, see #39180.

DiMuMassConfiguration_(iConfig.getParameter<edm::ParameterSet>("DiMuMassConfig")) {}
DiMuMassConfiguration_(iConfig.getParameter<edm::ParameterSet>("DiMuMassConfig")) {
produces<DQMToken, edm::Transition::EndRun>("DQMGenerationDiMuonMassBiasMonitorRun");
produces<DQMToken, edm::Transition::EndLuminosityBlock>("DQMGenerationDiMuonMassBiasMonitorLumi");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmusich Did you have a specific reason to not use the existing DQMToken functionality in the DQM base classes?

runToken_ = this->template produces<DQMToken, edm::Transition::EndRun>("DQMGenerationRecoRun");
lumiToken_ = this->template produces<DQMToken, edm::Transition::EndLuminosityBlock>("DQMGenerationRecoLumi");

// Use explicitly specified inputs, but if there are none...
auto inputtags =
iConfig.getUntrackedParameter<std::vector<edm::InputTag>>("inputMEs", std::vector<edm::InputTag>());
if (inputtags.empty()) {
// ... use all RECO MEs.
inputtags.push_back(edm::InputTag("", inputgeneration + "Job"));
inputtags.push_back(edm::InputTag("", inputgeneration + "Run"));
inputtags.push_back(edm::InputTag("", inputgeneration + "Lumi"));
}
jobmegetter_ = edm::GetterOfProducts<DQMToken>(edm::VInputTagMatch(inputtags), this, edm::InProcess);
runmegetter_ = edm::GetterOfProducts<DQMToken>(edm::VInputTagMatch(inputtags), this, edm::InRun);
lumimegetter_ = edm::GetterOfProducts<DQMToken>(edm::VInputTagMatch(inputtags), this, edm::InLumi);
callWhenNewProductsRegistered([this](edm::BranchDescription const &bd) {
jobmegetter_(bd);
runmegetter_(bd);
lumimegetter_(bd);
});

Copy link
Contributor Author

@mmusich mmusich Aug 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@makortel

Did you have a specific reason to not use the existing DQMToken functionality in the DQM base classes?

those were a relic from a previous stage of development in which this module was an edm::EDAnalyzer and not a DQMEDHarvester. That line of development was abandoned as the legacy modules are anyway deprecated.
I removed the useless statements in a5bab3b as part of #39217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants