Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean unused dependencies from BuildFiles #39160

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Clean unused dependencies from BuildFiles #39160

merged 1 commit into from
Aug 29, 2022

Conversation

guitargeek
Copy link
Contributor

PR description:

Another quick BuildFile cleaning PR in the style of many before (for example #37915).

In many cases, the dependencies had to be moved to the appropriate BuildFile, for example from a plugins directory to the library directory or vice versa.

This PR cleans unnecessary includes from CMSSW BuildFiles that were added in the last months.

PR validation:

CMSSW compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport intended.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39160/31742

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

  • Alignment/MillePedeAlignmentAlgorithm (alca)
  • Alignment/OfflineValidation (alca)
  • CommonTools/ConditionDBWriter (db)
  • CondCore/AlignmentPlugins (db)
  • CondCore/SiPixelPlugins (db)
  • CondCore/SiStripPlugins (db)
  • DQMOffline/Alignment (dqm)
  • DataFormats/PortableTestObjects (heterogeneous)
  • HeavyFlavorAnalysis/SpecificDecay (analysis)
  • HeterogeneousCore/AlpakaServices (heterogeneous)
  • L1Trigger/Phase2L1ParticleFlow (upgrade, l1)
  • PhysicsTools/TensorFlow (reconstruction)
  • RecoHGCal/TICL (upgrade, reconstruction)
  • RecoTracker/FinalTrackSelectors (reconstruction)
  • RecoTracker/MkFit (reconstruction)
  • SimG4Core/CustomPhysics (simulation)
  • Validation/CTPPS (dqm)

@rekovic, @jpata, @ChrisMisan, @cecilecaillol, @civanch, @yuanchao, @makortel, @ahmad3213, @cmsbuild, @fwyzard, @mandrenguyen, @pmandrik, @epalencia, @emanueleusai, @mdhildreth, @AdrianoDee, @jfernan2, @ggovi, @micsucmed, @francescobrivio, @malbouis, @clacaputo, @srimanob, @saumyaphor4252, @rvenditti, @tvami can you please review it and eventually sign? Thanks.
@VourMa, @felicepantaleo, @forthommel, @Martin-Grunewald, @bsunanda, @OzAmram, @grzanka, @tlampen, @trtomei, @mmusich, @slomeo, @youyingli, @missirol, @makortel, @JanFSchulte, @dgulhan, @apsallid, @sobhatta, @ferencek, @beaucero, @rociovilar, @GiacomoSguazzoni, @rovere, @VinInn, @tocheng, @hatakeyamak, @ebrondol, @mtosi, @fabiocos, @adewit, @riga, @dkotlins, @lecriste, @gpetruc, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor

@cmsbuild, please test

@guitargeek
Copy link
Contributor Author

Hi, sorry I opened the PR too early and realized that it didn't even compile yet locally... Now it does!

Sorry for wasting a bot test

@makortel
Copy link
Contributor

@cmsbuild, please abort

Let's minimize the waste :)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39160/31744

@civanch
Copy link
Contributor

civanch commented Aug 27, 2022

+1

@ChrisMisan
Copy link
Contributor

+alca

  • re-signing
  • differences in L1T not related to this PR

@mandrenguyen
Copy link
Contributor

+reconstruction
re-sign

@tvami
Copy link
Contributor

tvami commented Aug 27, 2022

+db

@cecilecaillol
Copy link
Contributor

+l1

@perrotta
Copy link
Contributor

+1

  • @cms-sw/dqm-l2 already approved a few days ago a version of this PR which is identical to this one for what the dqm-related files are concerned

@perrotta
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit e2a21d3 into cms-sw:master Aug 29, 2022
@guitargeek guitargeek deleted the deps_1 branch August 29, 2022 08:18
@emanueleusai
Copy link
Member

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.