-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean unused dependencies from BuildFiles #37915
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37915/29955
|
A new Pull Request was created by @guitargeek (Jonas Rembser) for master. It involves the following packages:
@SiewYan, @jpata, @Saptaparna, @rekovic, @alberto-sanchez, @cecilecaillol, @yuanchao, @makortel, @ahmad3213, @cmsbuild, @fwyzard, @GurpreetSinghChahal, @pmandrik, @epalencia, @emanueleusai, @AdrianoDee, @jfernan2, @slava77, @ggovi, @micsucmed, @francescobrivio, @malbouis, @mkirsano, @clacaputo, @srimanob, @tvami, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Please test |
+heterogeneous |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-399f4f/24645/summary.html Comparison SummarySummary:
|
+upgrade |
+1 |
+1
|
+1 |
+l1 |
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Another quick BuildFile cleaning PR in the style of many before (for example #36834).
In many cases, the dependencies had to be moved to the appropriate BuildFile, for example from a plugins directory to the library directory or vice versa.
This PR cleans unnecessary includes from CMSSW BuildFiles that were added in the last months.
PR validation:
CMSSW compiles.
if this PR is a backport please specify the original PR and why you need to backport that PR:
No backport intended.