switch pixelLess iteration to use CKF instead of mkFit #38967

slava77 · 2022-08-04T14:52:27Z

Discussion in PPD Aug 4
https://indico.cern.ch/event/1187803/#43-discussion-of-reversion-to
appears to be converging to the decision to switch the pixelLess iteration to use CKF instead of mkFit.

This PR makes the switch and removes Run3_ckfPixelLessStep, which is now identical to Run3
(I checked this using the run3 wf 11834.0 expanded config for step3).

@cms-sw/tracking-pog-l2

… for mkFit tracking in phase-1)

mmusich · 2022-08-04T14:55:14Z

Configuration/Eras/python/ModifierChain_trackingMkFitProd_cff.py

@@ -16,5 +15,4 @@
    trackingMkFitHighPtTripletStep,
    trackingMkFitDetachedQuadStep,
    trackingMkFitDetachedTripletStep,
-    trackingMkFitPixelLessStep,


Shall we comment it, hoping to put it back ~ soon?

IIRC, commented out parts are usually not advised by reco: if some change is expected in the code soon, the usual advice is to make an issue in github

cmsbuild · 2022-08-04T14:59:27Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38967/31421

This PR adds an extra 36KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): TICL version 4: CLUE3D as default Pattern Recognition, Linking #38880, Update BeamSpot in Run3 MC GTs + swap Run3RoundOptics25ns13TeVLowSigmaZ with Realistic25ns13p6TeVEarly2022Collision vtx smearing #38760, Clean up Phase-2 geometry (Up to D85) #38702, Add run3 tracking low pu era #33532
- File Configuration/StandardSequences/python/Eras.py modified in PR(s): Add run3 tracking low pu era #33532, fix dump of nano + add modifier for 122 mini #38749

cmsbuild · 2022-08-04T14:59:53Z

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

Configuration/Eras (operations)
Configuration/PyReleaseValidation (pdmv, upgrade)
Configuration/StandardSequences (operations)

@perrotta, @rappoccio, @jordan-martins, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @VourMa, @makortel, @felicepantaleo, @slomeo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @kpedro88, @lecriste, @trtomei, @mmusich, @mtosi, @beaucero, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

slava77 · 2022-08-04T15:00:01Z

@cmsbuild please test

cmsbuild · 2022-08-04T19:11:17Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-370908/26642/summary.html
COMMIT: dda3f63
CMSSW: CMSSW_12_5_X_2022-08-04-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38967/26642/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 19186 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3691510
DQMHistoTests: Total failures: 30994
DQMHistoTests: Total nulls: 2
DQMHistoTests: Total successes: 3660492
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.008 KiB( 50 files compared)
DQMHistoSizes: changed ( 138.5 ): 0.004 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 212 log files, 49 edm output root files, 51 DQM output files
TriggerResults: found differences in 3 / 50 workflows

srimanob · 2022-08-12T11:03:29Z

@cmsbuild please test

srimanob · 2022-08-12T11:04:15Z

@slava77
I have not followed up closely. I assume this PR is ready to go, right? I just call the test again as the last one is a week ago.

slava77 · 2022-08-12T12:17:57Z

@slava77 I have not followed up closely. I assume this PR is ready to go, right? I just call the test again as the last one is a week ago.

I do not expect any functional modifications in this PR.

The only pending item was a formal go-ahead from PPD/Validation that this is good to go for the default.
But that part is perhaps on the ORP part of the sign off.

cmsbuild · 2022-08-12T15:26:59Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-370908/26780/summary.html
COMMIT: dda3f63
CMSSW: CMSSW_12_5_X_2022-08-12-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38967/26780/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 19335 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3692476
DQMHistoTests: Total failures: 30990
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3661463
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
DQMHistoSizes: changed ( 138.5 ): 0.004 KiB JetMET/SUSYDQM
Checked 212 log files, 49 edm output root files, 51 DQM output files
TriggerResults: found differences in 3 / 50 workflows

srimanob · 2022-08-13T01:40:43Z

+Upgrade

From the upgrade side, this PR follows the agreement on switching pixelless iteration to use CKF instead of mkFit.

kskovpen · 2022-08-13T09:39:56Z

+pdmv

perrotta · 2022-08-16T15:18:48Z

+1

As agreed at the Aug 16 ORP meeting

cmsbuild · 2022-08-16T15:19:10Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

slava77 · 2023-11-30T20:56:23Z

type tracking

cmsbuild · 2023-11-30T23:30:59Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-370908/36218/summary.html
COMMIT: dda3f63
CMSSW: CMSSW_14_0_X_2023-11-30-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38967/36218/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 164 lines from the logs
Reco comparison results: 28 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3370032
DQMHistoTests: Total failures: 1201
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3368809
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: no differences found

slava77devel added 2 commits August 4, 2022 16:44

remove pixelLess from trackingMkFitProd (defines the production setup…

1ce573a

… for mkFit tracking in phase-1)

remove Run3_ckfPixelLessStep (now the same as the default Run3)

dda3f63

cmsbuild added this to the CMSSW_12_5_X milestone Aug 4, 2022

cmsbuild added code-checks-pending operations-pending orp-pending pdmv-pending pending-signatures tests-pending upgrade-pending labels Aug 4, 2022

mmusich reviewed Aug 4, 2022

View reviewed changes

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 4, 2022

cmsbuild added tests-started and removed tests-pending labels Aug 4, 2022

slava77 mentioned this pull request Aug 4, 2022

switch pixelLess iteration to use CKF instead of mkFit #38968

Merged

cmsbuild added tests-approved and removed tests-started labels Aug 4, 2022

cmsbuild added tests-started and removed tests-approved labels Aug 12, 2022

cmsbuild added tests-approved and removed tests-started labels Aug 12, 2022

cmsbuild added upgrade-approved and removed upgrade-pending labels Aug 13, 2022

cmsbuild added pdmv-approved and removed pdmv-pending labels Aug 13, 2022

cmsbuild mentioned this pull request Aug 14, 2022

Tracker Traits and Enabling Phase2 for Inner Tracker Reconstruction on GPU #38761

Merged

8 tasks

cmsbuild added fully-signed operations-approved orp-approved and removed operations-pending pending-signatures orp-pending labels Aug 16, 2022

cmsbuild merged commit 1ce2b7e into cms-sw:master Aug 16, 2022

This was referenced Aug 16, 2022

Remove run2_HLTconditions_2018 modifier from Run3 setting #39084

Merged

Update cuda to 11.7.1 for gcc12 cms-sw/cmsdist#8025

Closed

[GCC Flags] drop -Wstrict-overflow which has been deprecated since gcc8 cms-sw/cmsdist#8026

Merged

mmusich mentioned this pull request Oct 20, 2022

Disable computation of Q probability in SiPixel template CPE for iterative tracking #39776

Merged

cmsbuild added tests-started tracking and removed tests-approved labels Nov 30, 2023

cmsbuild added tests-approved and removed tests-started labels Nov 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

switch pixelLess iteration to use CKF instead of mkFit #38967

switch pixelLess iteration to use CKF instead of mkFit #38967

slava77 commented Aug 4, 2022

mmusich Aug 4, 2022

slava77 Aug 4, 2022 •

edited

Loading

cmsbuild commented Aug 4, 2022

cmsbuild commented Aug 4, 2022

slava77 commented Aug 4, 2022

cmsbuild commented Aug 4, 2022

srimanob commented Aug 12, 2022

srimanob commented Aug 12, 2022

slava77 commented Aug 12, 2022

cmsbuild commented Aug 12, 2022

srimanob commented Aug 13, 2022

kskovpen commented Aug 13, 2022

perrotta commented Aug 16, 2022

cmsbuild commented Aug 16, 2022

slava77 commented Nov 30, 2023

cmsbuild commented Nov 30, 2023

switch pixelLess iteration to use CKF instead of mkFit #38967

switch pixelLess iteration to use CKF instead of mkFit #38967

Conversation

slava77 commented Aug 4, 2022

mmusich Aug 4, 2022

Choose a reason for hiding this comment

slava77 Aug 4, 2022 • edited Loading

Choose a reason for hiding this comment

cmsbuild commented Aug 4, 2022

cmsbuild commented Aug 4, 2022

slava77 commented Aug 4, 2022

cmsbuild commented Aug 4, 2022

Comparison Summary

srimanob commented Aug 12, 2022

srimanob commented Aug 12, 2022

slava77 commented Aug 12, 2022

cmsbuild commented Aug 12, 2022

Comparison Summary

srimanob commented Aug 13, 2022

kskovpen commented Aug 13, 2022

perrotta commented Aug 16, 2022

cmsbuild commented Aug 16, 2022

slava77 commented Nov 30, 2023

cmsbuild commented Nov 30, 2023

Comparison Summary

slava77 Aug 4, 2022 •

edited

Loading