Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch pixelLess iteration to use CKF instead of mkFit #38967

Merged
merged 2 commits into from
Aug 16, 2022
Merged

switch pixelLess iteration to use CKF instead of mkFit #38967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ce573a
remove pixelLess from trackingMkFitProd (defines the production setup…
slava77devel Aug 4, 2022
dda3f63
remove Run3_ckfPixelLessStep (now the same as the default Run3)
slava77devel Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions Configuration/Eras/python/Era_Run3_ckfPixelLessStep_cff.py
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions Configuration/Eras/python/ModifierChain_trackingMkFitProd_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
from Configuration.ProcessModifiers.trackingMkFitHighPtTripletStep_cff import *
from Configuration.ProcessModifiers.trackingMkFitDetachedQuadStep_cff import *
from Configuration.ProcessModifiers.trackingMkFitDetachedTripletStep_cff import *
from Configuration.ProcessModifiers.trackingMkFitPixelLessStep_cff import *

trackingMkFitProd = cms.ModifierChain(
trackingMkFitCommon,
Expand All @@ -16,5 +15,4 @@
trackingMkFitHighPtTripletStep,
trackingMkFitDetachedQuadStep,
trackingMkFitDetachedTripletStep,
trackingMkFitPixelLessStep,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we comment it, hoping to put it back ~ soon?

Copy link
Contributor Author

@slava77 slava77 Aug 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, commented out parts are usually not advised by reco: if some change is expected in the code soon, the usual advice is to make an issue in github

)
38 changes: 0 additions & 38 deletions Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,44 +397,6 @@ def condition_(self, fragment, stepList, key, hasHarvest):
'--procModifiers': 'trackingMkFitDevel'
}

class UpgradeWorkflow_trackingRun3CkfPixelLessStep(UpgradeWorkflowTracking):
def setup__(self, step, stepName, stepDict, k, properties):
if 'Reco' in step and stepDict[step][k]['--era']=='Run3':
stepDict[stepName][k] = merge([{'--era': 'Run3_ckfPixelLessStep'}, stepDict[step][k]])
def condition_(self, fragment, stepList, key, hasHarvest):
return '2021' in key and 'FS' not in key
upgradeWFs['trackingRun3CkfPixelLessStep'] = UpgradeWorkflow_trackingRun3CkfPixelLessStep(
steps = [
'Reco',
'RecoNano',
'RecoGlobal',
'RecoFakeHLT',
],
suffix = '_trackingRun3CkfPixelLessStep',
offset = 0.71,
)

class UpgradeWorkflow_trackingOnlyRun3CkfPixelLessStep(UpgradeWorkflowTracking):
def setup__(self, step, stepName, stepDict, k, properties):
if 'Reco' in step and stepDict[step][k]['--era']=='Run3':
stepDict[stepName][k] = merge([{'--era': 'Run3_ckfPixelLessStep'}, self.step3, stepDict[step][k]])
elif 'HARVEST' in step: stepDict[stepName][k] = merge([{'-s': 'HARVESTING:@trackingOnlyValidation+@trackingOnlyDQM'}, stepDict[step][k]])
def condition_(self, fragment, stepList, key, hasHarvest):
return '2021' in key and 'FS' not in key
upgradeWFs['trackingOnlyRun3CkfPixelLessStep'] = UpgradeWorkflow_trackingOnlyRun3CkfPixelLessStep(
steps = [
'Reco',
'HARVEST',
'RecoNano',
'HARVESTNano',
'RecoFakeHLT',
'HARVESTFakeHLT',
],
suffix = '_trackingOnlyRun3CkfPixelLessStep',
offset = 0.72,
)
upgradeWFs['trackingOnlyRun3CkfPixelLessStep'].step3 = upgradeWFs['trackingOnly'].step3

#DeepCore seeding for JetCore iteration workflow
class UpgradeWorkflow_seedingDeepCore(UpgradeWorkflow):
def setup_(self, step, stepName, stepDict, k, properties):
Expand Down
1 change: 0 additions & 1 deletion Configuration/StandardSequences/python/Eras.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ def __init__(self):
'Run2_2018_highBetaStar',
'Run2_2018_noMkFit',
'Run3',
'Run3_ckfPixelLessStep',
'Run3_noMkFit',
'Run3_pp_on_PbPb',
'Run3_dd4hep',
Expand Down