fix dump of nano + add modifier for 122 mini #38749

mariadalfonso · 2022-07-15T12:08:38Z

fix issue https://github.com/cms-sw/cmssw/issues/386862
add modifier to run nano from 122 mini

cmsbuild · 2022-07-15T12:14:43Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38749/31069

This PR adds an extra 16KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/nano_cff.py modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167

cmsbuild · 2022-07-15T12:15:07Z

A new Pull Request was created by @mariadalfonso for master.

It involves the following packages:

PhysicsTools/NanoAOD (xpog)

@cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @swertz this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

mariadalfonso · 2022-07-15T22:25:43Z

please test

cmsbuild · 2022-07-16T01:02:03Z

-1

Failed Tests: UnitTests RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e032d/26279/summary.html
COMMIT: 4e81937
CMSSW: CMSSW_12_5_X_2022-07-15-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38749/26279/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test runtestPhysicsToolsNanoAOD had ERRORS

RelVals

1325.81

----- Begin Fatal Exception 16-Jul-2022 01:50:55 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 3 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [3] Prefetching for module SimpleCandidateFlatTableProducer/'caloMetTable'
   [4] Calling method for module PATMETSlimmer/'slimmedMETs'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<pat::MET>
Looking for module label: deepMETsResolutionTune
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

RelVals-INPUT

136.7722136.7722_RunJetHT2016H_nano+RunJetHT2016H_nano+NANOEDM2016_80X+HARVESTNANOAOD2016_80X/step2_RunJetHT2016H_nano+RunJetHT2016H_nano+NANOEDM2016_80X+HARVESTNANOAOD2016_80X.log
136.7952136.7952_RunJetHT2017C_94Xv2NanoAODINPUT+RunJetHT2017C_94Xv2NanoAODINPUT+NANOEDM2017_94XMiniAODv2+HARVESTNANOAOD2017_94XMiniAODv2/step2_RunJetHT2017C_94Xv2NanoAODINPUT+RunJetHT2017C_94Xv2NanoAODINPUT+NANOEDM2017_94XMiniAODv2+HARVESTNANOAOD2017_94XMiniAODv2.log
136.8521136.8521_RunJetHT2018A_nano+RunJetHT2018A_nano+NANOEDM2018_102Xv1+HARVESTNANOAOD2018_102Xv1/step2_RunJetHT2018A_nano+RunJetHT2018A_nano+NANOEDM2018_102Xv1+HARVESTNANOAOD2018_102Xv1.log

Expand to see more relval errors ...

mariadalfonso · 2022-07-17T17:23:56Z

please test

cmsbuild · 2022-07-17T19:20:05Z

-1

Failed Tests: UnitTests RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e032d/26295/summary.html
COMMIT: 4e81937
CMSSW: CMSSW_12_5_X_2022-07-17-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38749/26295/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test runtestPhysicsToolsNanoAOD had ERRORS

RelVals

1325.81

----- Begin Fatal Exception 17-Jul-2022 19:45:46 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 3 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [3] Prefetching for module SimpleCandidateFlatTableProducer/'caloMetTable'
   [4] Calling method for module PATMETSlimmer/'slimmedMETs'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<pat::MET>
Looking for module label: deepMETsResolutionTune
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

RelVals-INPUT

136.7722136.7722_RunJetHT2016H_nano+RunJetHT2016H_nano+NANOEDM2016_80X+HARVESTNANOAOD2016_80X/step2_RunJetHT2016H_nano+RunJetHT2016H_nano+NANOEDM2016_80X+HARVESTNANOAOD2016_80X.log
136.7952136.7952_RunJetHT2017C_94Xv2NanoAODINPUT+RunJetHT2017C_94Xv2NanoAODINPUT+NANOEDM2017_94XMiniAODv2+HARVESTNANOAOD2017_94XMiniAODv2/step2_RunJetHT2017C_94Xv2NanoAODINPUT+RunJetHT2017C_94Xv2NanoAODINPUT+NANOEDM2017_94XMiniAODv2+HARVESTNANOAOD2017_94XMiniAODv2.log
136.8521136.8521_RunJetHT2018A_nano+RunJetHT2018A_nano+NANOEDM2018_102Xv1+HARVESTNANOAOD2018_102Xv1/step2_RunJetHT2018A_nano+RunJetHT2018A_nano+NANOEDM2018_102Xv1+HARVESTNANOAOD2018_102Xv1.log

Expand to see more relval errors ...

mariadalfonso · 2022-07-21T14:28:51Z

please test

cmsbuild · 2022-07-21T14:35:48Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38749/31190

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/StandardSequences/python/Eras.py modified in PR(s): [PPS] Direct simulation as sequence #38280, Add run3 tracking low pu era #33532
- File PhysicsTools/NanoAOD/python/nano_cff.py modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167

cmsbuild · 2022-07-21T14:36:15Z

Pull request #38749 was updated. @perrotta, @rappoccio, @gouskos, @fabiocos, @fgolf, @qliphy, @mariadalfonso, @davidlange6 can you please check and sign again.

cmsbuild · 2022-07-21T17:38:51Z

-1

Failed Tests: UnitTests RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e032d/26373/summary.html
COMMIT: 52aa2f4
CMSSW: CMSSW_12_5_X_2022-07-21-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38749/26373/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test runtestPhysicsToolsNanoAOD had ERRORS

RelVals

1325.81

----- Begin Fatal Exception 21-Jul-2022 17:01:38 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 3 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [3] Prefetching for module SimpleCandidateFlatTableProducer/'caloMetTable'
   [4] Calling method for module PATMETSlimmer/'slimmedMETs'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<pat::MET>
Looking for module label: deepMETsResolutionTune
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

RelVals-INPUT

136.7722136.7722_RunJetHT2016H_nano+RunJetHT2016H_nano+NANOEDM2016_80X+HARVESTNANOAOD2016_80X/step2_RunJetHT2016H_nano+RunJetHT2016H_nano+NANOEDM2016_80X+HARVESTNANOAOD2016_80X.log
136.7952136.7952_RunJetHT2017C_94Xv2NanoAODINPUT+RunJetHT2017C_94Xv2NanoAODINPUT+NANOEDM2017_94XMiniAODv2+HARVESTNANOAOD2017_94XMiniAODv2/step2_RunJetHT2017C_94Xv2NanoAODINPUT+RunJetHT2017C_94Xv2NanoAODINPUT+NANOEDM2017_94XMiniAODv2+HARVESTNANOAOD2017_94XMiniAODv2.log
136.8521136.8521_RunJetHT2018A_nano+RunJetHT2018A_nano+NANOEDM2018_102Xv1+HARVESTNANOAOD2018_102Xv1/step2_RunJetHT2018A_nano+RunJetHT2018A_nano+NANOEDM2018_102Xv1+HARVESTNANOAOD2018_102Xv1.log

Expand to see more relval errors ...

srimanob · 2022-09-21T17:33:11Z

Should this PR be closed as the issue is fixed in #39127 ?
Do we still need modifier for 12_2 part?

cmsbuild added this to the CMSSW_12_5_X milestone Jul 15, 2022

cmsbuild added code-checks-pending orp-pending pending-signatures tests-pending xpog-pending labels Jul 15, 2022

mariadalfonso mentioned this pull request Jul 15, 2022

fix dump of nano [12_4] #38750

Closed

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 15, 2022

srimanob mentioned this pull request Jul 15, 2022

dump_python does not work with Nano step #38686

Closed

cmsbuild added tests-started and removed tests-pending labels Jul 15, 2022

cmsbuild added tests-rejected and removed tests-started labels Jul 16, 2022

cmsbuild added tests-started and removed tests-rejected labels Jul 17, 2022

cmsbuild added tests-rejected and removed tests-started labels Jul 17, 2022

mariadalfonso added 2 commits July 21, 2022 11:22

fix dump of nano

651ea92

add modifier to run nano from 122 mini

52aa2f4

mariadalfonso force-pushed the fixEGM branch from 4e81937 to 52aa2f4 Compare July 21, 2022 14:28

cmsbuild removed tests-rejected code-checks-approved labels Jul 21, 2022

cmsbuild added code-checks-pending operations-pending tests-started labels Jul 21, 2022

mariadalfonso changed the title ~~fix dump of nano~~ fix dump of nano + add modifier for 122 mini Jul 21, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 21, 2022

cmsbuild added tests-rejected and removed tests-started labels Jul 21, 2022

This was referenced Jul 31, 2022

Migration of input collection parameters to untracked for CTPPS and DTMonitorModule #38854

Closed

switch pixelLess iteration to use CKF instead of mkFit #38967

Merged

cmsbuild mentioned this pull request Aug 14, 2022

Tracker Traits and Enabling Phase2 for Inner Tracker Reconstruction on GPU #38761

Merged

8 tasks

smuzaffar modified the milestones: CMSSW_12_5_X, CMSSW_12_6_X Aug 28, 2022

cmsbuild mentioned this pull request Sep 20, 2022

LHE generic mass filter extension #39458

Closed

mariadalfonso closed this Sep 22, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix dump of nano + add modifier for 122 mini #38749

fix dump of nano + add modifier for 122 mini #38749

mariadalfonso commented Jul 15, 2022 •

edited

Loading

cmsbuild commented Jul 15, 2022

cmsbuild commented Jul 15, 2022

mariadalfonso commented Jul 15, 2022

cmsbuild commented Jul 16, 2022

mariadalfonso commented Jul 17, 2022

cmsbuild commented Jul 17, 2022

mariadalfonso commented Jul 21, 2022

cmsbuild commented Jul 21, 2022

cmsbuild commented Jul 21, 2022

cmsbuild commented Jul 21, 2022

srimanob commented Sep 21, 2022

fix dump of nano + add modifier for 122 mini #38749

fix dump of nano + add modifier for 122 mini #38749

Conversation

mariadalfonso commented Jul 15, 2022 • edited Loading

cmsbuild commented Jul 15, 2022

cmsbuild commented Jul 15, 2022

mariadalfonso commented Jul 15, 2022

cmsbuild commented Jul 16, 2022

Unit Tests

RelVals

RelVals-INPUT

mariadalfonso commented Jul 17, 2022

cmsbuild commented Jul 17, 2022

Unit Tests

RelVals

RelVals-INPUT

mariadalfonso commented Jul 21, 2022

cmsbuild commented Jul 21, 2022

cmsbuild commented Jul 21, 2022

cmsbuild commented Jul 21, 2022

Unit Tests

RelVals

RelVals-INPUT

srimanob commented Sep 21, 2022

mariadalfonso commented Jul 15, 2022 •

edited

Loading