-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CalibTracker
: fallback to the OnlineLuminosityRecord
when SCAL is not available
#38384
Conversation
CalibTracker
: fallback to the OnlineLuminosityRecord when SCAL is not availableCalibTracker
: fallback to the OnlineLuminosityRecord
when SCAL is not available
type bugfix,trk |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38384/30580
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5fbd66/25552/summary.html Comparison SummarySummary:
|
+alca |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
Although there is this dead initialization |
clearly beyond the scope. |
+1 |
PR description:
It was noticed during 2022 900GeV collision runs that the information for PU and instantaneous luminosity is always identically zero for all runs (see e.g.: https://tinyurl.com/25cqyvlu).
This is due to the fact that the online PU and inst. luminosity information were taken from the SCAL FED digis which are not available anymore in Run-3. This PR fixes the problem by adding a fall-back to the
OnlineLuminosityRecord
provided by the S/W FED 1023.PR validation:
cmssw
compiles, unit tests are running correctly.if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport, but needs to be backported all the way down to 12.3.X.