Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.4.X] CalibTracker: fallback to the OnlineLuminosityRecord when SCAL is not available #38386

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jun 16, 2022

backport of #38384

PR description:

It was noticed during 2022 900GeV collision runs that the information for PU and instantaneous luminosity is always identically zero for all runs (see e.g.: https://tinyurl.com/25cqyvlu).
This is due to the fact that the online PU and inst. luminosity information were taken from the SCAL FED digis which are not available anymore in Run-3. This PR fixes the problem by adding a fall-back to the OnlineLuminosityRecord provided by the S/W FED 1023.

PR validation:

cmssw compiles, unit tests are running correctly.

if this PR is a backport please specify the original PR and why you need to backport that PR:

verbatim backport of #38384

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 16, 2022

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_4_X.

It involves the following packages:

  • CalibTracker/SiStripCommon (alca)
  • CalibTracker/SiStripHitEfficiency (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@echabert, @pieterdavid, @robervalwalsh, @gbenelli, @tocheng, @mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jun 16, 2022

please test

@francescobrivio
Copy link
Contributor

type bugfix,trk

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee0b1a/25555/summary.html
COMMIT: 796a852
CMSSW: CMSSW_12_4_X_2022-06-15-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38386/25555/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3680359
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3680329
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Jun 16, 2022

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

  • Good to have in the next 12_4_1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants