[L1T] Phase-2 update phase 2 emulator sequence #38375

cecilecaillol · 2022-06-15T11:00:55Z

PR description:

Use new emulators instead of old simulation

cmsbuild · 2022-06-15T11:07:13Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38375/30569

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DQMOffline/L1Trigger/python/L1TPhase2Offline_cfi.py modified in PR(s): [L1T] fix DQM phase-2 #38314, [L1T] phase-2, drop old L1 simulations from event content #38342
- File L1Trigger/Configuration/python/L1Trigger_EventContent_cff.py modified in PR(s): [L1T] Phase-2 - drop old L1 simulations #38313, [L1T] phase-2, drop old L1 simulations from event content #38342
- File L1Trigger/Configuration/python/SimL1Emulator_cff.py modified in PR(s): [L1T] Phase-2 - drop old L1 simulations #38313, [L1T] Clean obsolete phase-2 code #38316, [L1T] phase-2, update L1 emulation objects #38327, [L1T] phase-2, drop old L1 simulations from event content #38342, [L1T] phase2, drop old simulations from SimL1Emulator #38340
- File L1Trigger/L1CaloTrigger/python/Phase1L1TJetProducer_cfi.py modified in PR(s): [L1T] phase-2, drop old L1 simulations from event content #38342
- File L1Trigger/Phase2L1ParticleFlow/python/l1pfJetMet_cff.py modified in PR(s): [L1T] Clean obsolete phase-2 code #38316, [L1T] phase-2, drop old L1 simulations from event content #38342

cmsbuild · 2022-06-15T11:07:34Z

A new Pull Request was created by @cecilecaillol for master.

It involves the following packages:

DQMOffline/L1Trigger (dqm, l1)
L1Trigger/Configuration (l1)
L1Trigger/L1CaloTrigger (upgrade, l1)
L1Trigger/Phase2L1ParticleFlow (upgrade, l1)

@rekovic, @epalencia, @emanueleusai, @ahmad3213, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @pmandrik, @micsucmed, @cecilecaillol, @rvenditti can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @beaucero, @trtomei, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

cecilecaillol · 2022-06-15T11:08:44Z

please test with cms-data/L1Trigger-Phase2L1ParticleFlow#4

cmsbuild · 2022-06-15T13:20:14Z

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56914a/25535/summary.html
COMMIT: 9606f3d
CMSSW: CMSSW_12_5_X_2022-06-14-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38375/25535/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56914a/25535/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56914a/25535/git-merge-result

RelVals

39500.0

----- Begin Fatal Exception 15-Jun-2022 14:48:00 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGHLToutput'
   [3] Prefetching for module Phase2L1TGMTStubProducer/'L1TkStubsGmt'
   [4] Prefetching for module DTTrigPhase2Prod/'dtTriggerPhase2PrimitiveDigis'
   [5] Calling method for module CalibratedDigis/'CalibratedDigis'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: MuonDigiCollection<DTLayerId,DTDigi>
Looking for module label: muonDTDigis
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

23234.0

----- Begin Fatal Exception 15-Jun-2022 14:48:18 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGHLToutput'
   [3] Prefetching for module Phase2L1TGMTStubProducer/'L1TkStubsGmt'
   [4] Prefetching for module DTTrigPhase2Prod/'dtTriggerPhase2PrimitiveDigis'
   [5] Calling method for module CalibratedDigis/'CalibratedDigis'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: MuonDigiCollection<DTLayerId,DTDigi>
Looking for module label: muonDTDigis
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

39496.0

----- Begin Fatal Exception 15-Jun-2022 14:48:24 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGHLToutput'
   [3] Prefetching for module Phase2L1TGMTStubProducer/'L1TkStubsGmt'
   [4] Prefetching for module DTTrigPhase2Prod/'dtTriggerPhase2PrimitiveDigis'
   [5] Calling method for module CalibratedDigis/'CalibratedDigis'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: MuonDigiCollection<DTLayerId,DTDigi>
Looking for module label: muonDTDigis
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

23234.023234.0_TTbar_14TeV+2026D49+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+HARVESTGlobal/step2_TTbar_14TeV+2026D49+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+HARVESTGlobal.log
34634.034634.0_TTbar_14TeV+2026D76+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+HARVESTGlobal/step2_TTbar_14TeV+2026D76+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+HARVESTGlobal.log
35034.035034.0_TTbar_14TeV+2026D77+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+HARVESTGlobal/step2_TTbar_14TeV+2026D77+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+HARVESTGlobal.log

Expand to see more relval errors ...

cecilecaillol · 2022-06-15T13:59:19Z

@folguera The relval error above disappears if I comment the 2 keep lines https://github.com/cms-sw/cmssw/pull/38375/files#diff-9ee5d95b80750ddfe3e1fb7513dbd7cf445e6c1b52239b3275dc652d385ea4f0R211-R212 Do you know how to solve the problem (I guess commenting the lines is a problem because we will miss some objects in the end)?

mcepeda · 2022-06-16T12:01:34Z

Following the issue with @jaimeleonh - muonDTDigis refers to data. We need simMuonDTDigis for it to work on TTBar Phase2 MC. An easy fix is changing that in SimL1Emulator:

CalibratedDigis.dtDigiTag = "simMuonDTDigis"

before line 75 (L1Trigger/Configuration/python/SimL1Emulator_cff.py#L75)

A more elegant way would be to do it with the Eras.

I have not ran the tests yet, but the solution is along those lines.

cmsbuild · 2022-06-16T12:47:58Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38375/30586

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DQMOffline/L1Trigger/python/L1TPhase2Offline_cfi.py modified in PR(s): [L1T] fix DQM phase-2 #38314, [L1T] phase-2, drop old L1 simulations from event content #38342
- File L1Trigger/Configuration/python/L1Trigger_EventContent_cff.py modified in PR(s): [L1T] Phase-2 - drop old L1 simulations #38313, [L1T] phase-2, drop old L1 simulations from event content #38342
- File L1Trigger/Configuration/python/SimL1Emulator_cff.py modified in PR(s): [L1T] Phase-2 - drop old L1 simulations #38313, [L1T] Clean obsolete phase-2 code #38316, [L1T] phase-2, update L1 emulation objects #38327, [L1T] phase-2, drop old L1 simulations from event content #38342, [L1T] phase2, drop old simulations from SimL1Emulator #38340
- File L1Trigger/L1CaloTrigger/python/Phase1L1TJetProducer_cfi.py modified in PR(s): [L1T] phase-2, drop old L1 simulations from event content #38342
- File L1Trigger/Phase2L1ParticleFlow/python/l1pfJetMet_cff.py modified in PR(s): [L1T] Clean obsolete phase-2 code #38316, [L1T] phase-2, drop old L1 simulations from event content #38342

cmsbuild · 2022-06-16T12:48:24Z

Pull request #38375 was updated. @rekovic, @epalencia, @emanueleusai, @ahmad3213, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @pmandrik, @micsucmed, @cecilecaillol, @rvenditti can you please check and sign again.

cmsbuild · 2022-06-16T13:34:11Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38375/30589

This PR adds an extra 32KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DQMOffline/L1Trigger/python/L1TPhase2Offline_cfi.py modified in PR(s): [L1T] fix DQM phase-2 #38314, [L1T] phase-2, drop old L1 simulations from event content #38342
- File L1Trigger/Configuration/python/L1Trigger_EventContent_cff.py modified in PR(s): [L1T] Phase-2 - drop old L1 simulations #38313, [L1T] phase-2, drop old L1 simulations from event content #38342
- File L1Trigger/Configuration/python/SimL1Emulator_cff.py modified in PR(s): [L1T] Phase-2 - drop old L1 simulations #38313, [L1T] Clean obsolete phase-2 code #38316, [L1T] phase-2, update L1 emulation objects #38327, [L1T] phase-2, drop old L1 simulations from event content #38342, [L1T] phase2, drop old simulations from SimL1Emulator #38340
- File L1Trigger/L1CaloTrigger/python/Phase1L1TJetProducer_cfi.py modified in PR(s): [L1T] phase-2, drop old L1 simulations from event content #38342
- File L1Trigger/Phase2L1ParticleFlow/python/l1pfJetMet_cff.py modified in PR(s): [L1T] Clean obsolete phase-2 code #38316, [L1T] phase-2, drop old L1 simulations from event content #38342

cmsbuild · 2022-06-16T13:34:33Z

Pull request #38375 was updated. @rekovic, @epalencia, @emanueleusai, @ahmad3213, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @pmandrik, @micsucmed, @cecilecaillol, @rvenditti can you please check and sign again.

cecilecaillol · 2022-06-16T13:34:55Z

please test with cms-data/L1Trigger-Phase2L1ParticleFlow#4

cmsbuild · 2022-06-16T18:36:47Z

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56914a/25564/summary.html
COMMIT: 8185efd
CMSSW: CMSSW_12_5_X_2022-06-15-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38375/25564/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56914a/25564/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56914a/25564/git-merge-result

RelVals

39434.75

----- Begin Fatal Exception 16-Jun-2022 17:12:34 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLT_DoublePFPuppiJets128_DoublePFPuppiBTagDeepFlavour_2p4'
   [2] Prefetching for module L1TJetFilter/'l1tDoublePFPuppiJet112offMaxEta2p4'
   [3] Prefetching for module Phase1L1TJetCalibrator/'l1tSlwPFPuppiJetsCorrected'
   [4] Calling method for module Phase1L1TJetProducer/'l1tSlwPFPuppiJets'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for a container with elements of type: reco::Candidate
Looking for module label: l1pfCandidates
Looking for productInstanceName: Puppi

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

RelVals-INPUT

The relvals timed out after 4 hours.

update phase 2 emulator sequence

9606f3d

cmsbuild added this to the CMSSW_12_5_X milestone Jun 15, 2022

cmsbuild added code-checks-pending dqm-pending l1-pending orp-pending pending-signatures tests-pending upgrade-pending labels Jun 15, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 15, 2022

cmsbuild added requires-external tests-started and removed tests-pending labels Jun 15, 2022

cmsbuild added tests-rejected and removed tests-started labels Jun 15, 2022

fix calibratedDigis issue

d3b24ba

cmsbuild added code-checks-pending tests-pending and removed tests-rejected requires-external code-checks-approved labels Jun 16, 2022

cmsbuild removed the code-checks-pending label Jun 16, 2022

cmsbuild added the code-checks-approved label Jun 16, 2022

ccaillol added 2 commits June 16, 2022 15:02

Merged l1t-phase2emu from repository cecilecaillol with cms-merge-topic

fe12527

muon DQM

8185efd

cmsbuild added code-checks-pending and removed code-checks-approved labels Jun 16, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 16, 2022

cmsbuild added requires-external tests-started and removed tests-pending labels Jun 16, 2022

cmsbuild added tests-rejected and removed tests-started labels Jun 16, 2022

cmsbuild mentioned this pull request Jun 20, 2022

[L1T] Phase-2, remove old simulation and adapt DQM #38442

Merged

cecilecaillol closed this Jun 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[L1T] Phase-2 update phase 2 emulator sequence #38375

[L1T] Phase-2 update phase 2 emulator sequence #38375

cecilecaillol commented Jun 15, 2022

cmsbuild commented Jun 15, 2022

cmsbuild commented Jun 15, 2022

cecilecaillol commented Jun 15, 2022

cmsbuild commented Jun 15, 2022

cecilecaillol commented Jun 15, 2022

mcepeda commented Jun 16, 2022 •

edited

Loading

cmsbuild commented Jun 16, 2022

cmsbuild commented Jun 16, 2022

cmsbuild commented Jun 16, 2022

cmsbuild commented Jun 16, 2022

cecilecaillol commented Jun 16, 2022

cmsbuild commented Jun 16, 2022

[L1T] Phase-2 update phase 2 emulator sequence #38375

[L1T] Phase-2 update phase 2 emulator sequence #38375

Conversation

cecilecaillol commented Jun 15, 2022

PR description:

cmsbuild commented Jun 15, 2022

cmsbuild commented Jun 15, 2022

cecilecaillol commented Jun 15, 2022

cmsbuild commented Jun 15, 2022

RelVals

RelVals-INPUT

cecilecaillol commented Jun 15, 2022

mcepeda commented Jun 16, 2022 • edited Loading

cmsbuild commented Jun 16, 2022

cmsbuild commented Jun 16, 2022

cmsbuild commented Jun 16, 2022

cmsbuild commented Jun 16, 2022

cecilecaillol commented Jun 16, 2022

cmsbuild commented Jun 16, 2022

RelVals

RelVals-INPUT

mcepeda commented Jun 16, 2022 •

edited

Loading