[L1T] phase2, drop old simulations from SimL1Emulator #38340

cecilecaillol · 2022-06-11T20:53:18Z

PR description:

Drop old simulated objects from SimL1Emulator. Includes the changes from cms-l1t-offline#1021, cms-l1t-offline#1020, cms-l1t-offline#1019, cms-l1t-offline#1023

cmsbuild · 2022-06-11T20:58:59Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38340/30521

This PR adds an extra 16KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/Configuration/python/SimL1Emulator_cff.py modified in PR(s): [L1T] Clean obsolete phase-2 code #38316, [L1T] Phase-2 - drop old L1 simulations #38313, [L1T] phase-2, update L1 emulation objects #38327, [L1T] Phase-2, Drop e/g simulation from L1 emulator sequence and event content #38335, [L1T] phase-2, Drop old tau-jet-MET simulation from L1 emulator sequence and event content and remove old modules #38336

cmsbuild · 2022-06-11T20:59:25Z

A new Pull Request was created by @cecilecaillol for master.

It involves the following packages:

L1Trigger/Configuration (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

cecilecaillol · 2022-06-11T20:59:43Z

please test

cmsbuild · 2022-06-11T23:01:41Z

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-40345d/25453/summary.html
COMMIT: 2dd93e8
CMSSW: CMSSW_12_5_X_2022-06-11-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38340/25453/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

23234.0

----- Begin Fatal Exception 11-Jun-2022 23:42:54 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=L1TCorrectedPFJetProducer label='scPFL1PuppiCorrectedEmulator'
Exception Message:
cannot find directory 'L1PuppiSC4EmuDeregJets' in file L1Trigger/Phase2L1ParticleFlow/data/jecs/jecs.PU200_110X.root 
----- End Fatal Exception -------------------------------------------------

39500.0

----- Begin Fatal Exception 11-Jun-2022 23:42:56 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=L1TCorrectedPFJetProducer label='scPFL1PuppiCorrectedEmulator'
Exception Message:
cannot find directory 'L1PuppiSC4EmuDeregJets' in file L1Trigger/Phase2L1ParticleFlow/data/jecs/jecs.PU200_110X.root 
----- End Fatal Exception -------------------------------------------------

39496.0

----- Begin Fatal Exception 11-Jun-2022 23:43:19 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=L1TCorrectedPFJetProducer label='scPFL1PuppiCorrectedEmulator'
Exception Message:
cannot find directory 'L1PuppiSC4EmuDeregJets' in file L1Trigger/Phase2L1ParticleFlow/data/jecs/jecs.PU200_110X.root 
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

23234.023234.0_TTbar_14TeV+2026D49+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+HARVESTGlobal/step2_TTbar_14TeV+2026D49+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+HARVESTGlobal.log
23234.2123234.21_TTbar_14TeV+2026D49_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+MiniAOD/step2_TTbar_14TeV+2026D49_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+MiniAOD.log
23434.2123434.21_TTbar_14TeV+2026D49PU_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTriggerPU+RecoGlobalPU+MiniAODPU/step2_TTbar_14TeV+2026D49PU_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTriggerPU+RecoGlobalPU+MiniAODPU.log

Expand to see more relval errors ...

cmsbuild · 2022-06-12T06:13:01Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38340/30524

This PR adds an extra 16KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/Configuration/python/SimL1Emulator_cff.py modified in PR(s): [L1T] Clean obsolete phase-2 code #38316, [L1T] Phase-2 - drop old L1 simulations #38313, [L1T] phase-2, update L1 emulation objects #38327, [L1T] Phase-2, Drop e/g simulation from L1 emulator sequence and event content #38335, [L1T] phase-2, Drop old tau-jet-MET simulation from L1 emulator sequence and event content and remove old modules #38336

cmsbuild · 2022-06-12T06:13:40Z

Pull request #38340 was updated. @epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please check and sign again.

cecilecaillol · 2022-06-12T06:21:54Z

please test

cmsbuild · 2022-06-12T10:02:49Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38340/30525

This PR adds an extra 16KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/Configuration/python/SimL1Emulator_cff.py modified in PR(s): [L1T] Clean obsolete phase-2 code #38316, [L1T] Phase-2 - drop old L1 simulations #38313, [L1T] phase-2, update L1 emulation objects #38327, [L1T] Phase-2, Drop e/g simulation from L1 emulator sequence and event content #38335, [L1T] phase-2, Drop old tau-jet-MET simulation from L1 emulator sequence and event content and remove old modules #38336

cmsbuild · 2022-06-12T10:03:13Z

Pull request #38340 was updated. @epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please check and sign again.

cecilecaillol · 2022-06-12T10:03:18Z

please test

cmsbuild · 2022-06-12T14:51:30Z

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-40345d/25454/summary.html
COMMIT: 9ce3a19
CMSSW: CMSSW_12_5_X_2022-06-12-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38340/25454/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

39496.0

----- Begin Fatal Exception 12-Jun-2022 16:24:26 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGHLToutput'
   [3] Prefetching for module Phase1L1TJetCalibrator/'Phase1L1TJetCalibrator9x9'
   [4] Calling method for module Phase1L1TJetProducer/'Phase1L1TJetProducer9x9'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for a container with elements of type: reco::Candidate
Looking for module label: l1pfCandidates
Looking for productInstanceName: Puppi

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

39500.0

----- Begin Fatal Exception 12-Jun-2022 16:24:27 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGHLToutput'
   [3] Prefetching for module Phase1L1TJetCalibrator/'Phase1L1TJetCalibrator9x9'
   [4] Calling method for module Phase1L1TJetProducer/'Phase1L1TJetProducer9x9'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for a container with elements of type: reco::Candidate
Looking for module label: l1pfCandidates
Looking for productInstanceName: Puppi

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

23234.0

----- Begin Fatal Exception 12-Jun-2022 16:24:46 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGHLToutput'
   [3] Prefetching for module Phase1L1TJetCalibrator/'Phase1L1TJetCalibrator9x9'
   [4] Calling method for module Phase1L1TJetProducer/'Phase1L1TJetProducer9x9'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for a container with elements of type: reco::Candidate
Looking for module label: l1pfCandidates
Looking for productInstanceName: Puppi

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

23234.023234.0_TTbar_14TeV+2026D49+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+HARVESTGlobal/step2_TTbar_14TeV+2026D49+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+HARVESTGlobal.log
23234.2123234.21_TTbar_14TeV+2026D49_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+MiniAOD/step2_TTbar_14TeV+2026D49_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+MiniAOD.log
23434.2123434.21_TTbar_14TeV+2026D49PU_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTriggerPU+RecoGlobalPU+MiniAODPU/step2_TTbar_14TeV+2026D49PU_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTriggerPU+RecoGlobalPU+MiniAODPU.log

Expand to see more relval errors ...

drop old sim

2dd93e8

cmsbuild added this to the CMSSW_12_5_X milestone Jun 11, 2022

cmsbuild added code-checks-pending l1-pending orp-pending pending-signatures tests-pending labels Jun 11, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 11, 2022

cmsbuild added tests-started and removed tests-pending labels Jun 11, 2022

cmsbuild added tests-rejected and removed tests-started labels Jun 11, 2022

remove failing jet sequence

12b7998

cmsbuild added code-checks-pending tests-pending and removed tests-rejected code-checks-approved labels Jun 12, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 12, 2022

cmsbuild added tests-started and removed tests-pending labels Jun 12, 2022

remove deprecated cms.InputTag

9ce3a19

cmsbuild added code-checks-pending tests-pending and removed tests-started code-checks-approved labels Jun 12, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 12, 2022

cmsbuild added tests-started and removed tests-pending labels Jun 12, 2022

cmsbuild mentioned this pull request Jun 12, 2022

[L1T] phase-2, drop old L1 simulations from event content #38342

Closed

cmsbuild added tests-rejected and removed tests-started labels Jun 12, 2022

This was referenced Jun 15, 2022

[L1T] Phase-2 update phase 2 emulator sequence #38375

Closed

[L1T] Phase-2, remove old simulation and adapt DQM #38442

Merged

cecilecaillol closed this Jun 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[L1T] phase2, drop old simulations from SimL1Emulator #38340

[L1T] phase2, drop old simulations from SimL1Emulator #38340

cecilecaillol commented Jun 11, 2022

cmsbuild commented Jun 11, 2022

cmsbuild commented Jun 11, 2022

cecilecaillol commented Jun 11, 2022

cmsbuild commented Jun 11, 2022

cmsbuild commented Jun 12, 2022

cmsbuild commented Jun 12, 2022

cecilecaillol commented Jun 12, 2022

cmsbuild commented Jun 12, 2022

cmsbuild commented Jun 12, 2022

cecilecaillol commented Jun 12, 2022

cmsbuild commented Jun 12, 2022

[L1T] phase2, drop old simulations from SimL1Emulator #38340

[L1T] phase2, drop old simulations from SimL1Emulator #38340

Conversation

cecilecaillol commented Jun 11, 2022

PR description:

cmsbuild commented Jun 11, 2022

cmsbuild commented Jun 11, 2022

cecilecaillol commented Jun 11, 2022

cmsbuild commented Jun 11, 2022

RelVals

RelVals-INPUT

cmsbuild commented Jun 12, 2022

cmsbuild commented Jun 12, 2022

cecilecaillol commented Jun 12, 2022

cmsbuild commented Jun 12, 2022

cmsbuild commented Jun 12, 2022

cecilecaillol commented Jun 12, 2022

cmsbuild commented Jun 12, 2022

RelVals

RelVals-INPUT