Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[L1T] Phase-2, Drop e/g simulation from L1 emulator sequence and event content #38335

Closed
wants to merge 1 commit into from

Conversation

cecilecaillol
Copy link
Contributor

PR description:

Porting local cms-l1t-offline#1019

This PR drops the simulation of e/g Standalone objects in the endcap and TkElectron and TkEm objects in barrel and endcap from the sequence and from the event content.

Additionally, the PR edits the customization of FEVTDEBUGHLT to be able to read input files containing the olf data format for certain types of PFCandidates.
PR validation:

Validated running the cmsDriver command:
cmsDriver.py step1 --processName=L1REPR --conditions 123X_mcRun4_realistic_v3 -n 10 --era Phase2C9 --eventcontent FEVTDEBUGHLT -s RAW2DIGI,L1 --datatier FEVTDEBUGHLT --geometry Extended2026D49 --fileout file:/tmp/step1_Reprocess_L1.root --no_exec --nThreads 8 --python step1_L1_Reprocess.py --filein "das:/MinBias_TuneCP5_14TeV-pythia8/Phase2HLTTDRSummer20L1T-PU200_111X_mcRun4_realistic_T15_v1-v2/FEVT" --customise L1Trigger/Configuration/customisePhase2.addHcalTriggerPrimitives,L1Trigger/Configuration/customisePhase2FEVTDEBUGHLT.customisePhase2FEVTDEBUGHLT --no_exec

The diff of the output of the edmDumpEventContent /tmp/step1_Reprocess_L1.root command is:

203d202
< BXVectorl1t::EGamma "l1EGammaEEProducer" "L1EGammaCollectionBXVWithCuts" "RECO"
391,399d389
< vectorl1t::TkElectron "L1TkElectronsCrystal" "EG" "RECO"
< vectorl1t::TkElectron "L1TkElectronsEllipticMatchCrystal" "EG" "RECO"
< vectorl1t::TkElectron "L1TkElectronsEllipticMatchHGC" "EG" "RECO"
< vectorl1t::TkElectron "L1TkElectronsHGC" "EG" "RECO"
< vectorl1t::TkElectron "L1TkElectronsLooseCrystal" "EG" "RECO"
< vectorl1t::TkElectron "L1TkIsoElectronsCrystal" "EG" "RECO"
< vectorl1t::TkElectron "L1TkIsoElectronsHGC" "EG" "RECO"
< vectorl1t::TkEm "L1TkPhotonsCrystal" "EG" "RECO"
< vectorl1t::TkEm "L1TkPhotonsHGC" "EG" "RECO"
667d656
< BXVectorl1t::EGamma "l1EGammaEEProducer" "L1EGammaCollectionBXVWithCuts" "L1REPR"
968,975d956
< vectorl1t::TkElectron "L1TkElectronsCrystal" "EG" "L1REPR"
< vectorl1t::TkElectron "L1TkElectronsEllipticMatchCrystal" "EG" "L1REPR"
< vectorl1t::TkElectron "L1TkElectronsEllipticMatchHGC" "EG" "L1REPR"
< vectorl1t::TkElectron "L1TkElectronsHGC" "EG" "L1REPR"
< vectorl1t::TkElectron "L1TkElectronsLooseCrystal" "EG" "L1REPR"
< vectorl1t::TkElectron "L1TkElectronsLooseHGC" "EG" "L1REPR"
< vectorl1t::TkElectron "L1TkIsoElectronsCrystal" "EG" "L1REPR"
< vectorl1t::TkElectron "L1TkIsoElectronsHGC" "EG" "L1REPR"
986,987d966
< vectorl1t::TkEm "L1TkPhotonsCrystal" "EG" "L1REPR"
< vectorl1t::TkEm "L1TkPhotonsHGC" "EG" "L1REPR"

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38335/30513

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @cecilecaillol for master.

It involves the following packages:

  • L1Trigger/Configuration (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cecilecaillol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-baf96d/25448/summary.html
COMMIT: 77d6cbb
CMSSW: CMSSW_12_5_X_2022-06-11-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38335/25448/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 11-Jun-2022 17:18:17 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'L1T_TkIsoEm22TkIsoEm12'
   [2] Calling method for module L1TTkEmFilter/'L1TkIsoEmSingle22Filter'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<l1t::TkEm>
Looking for module label: hltL1TkPhotonsHGC
Looking for productInstanceName: EG

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants