add basic data run3 reco and apply to splash events as a wf 138.3; fix tools for simple lumi list #35776
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35776/26131
|
|
A new Pull Request was created by @slava77 (Slava Krutelyov) for master. It involves the following packages:
@smuzaffar, @Dr15Jones, @jordan-martins, @makortel, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Hi @slava77 I think you can expect this to be copied in an hour from now. Regarding the GT, I think what you did is correct and the autoCond key for data Run-3 should be used. |
@tvami |
|
Hi @slava77 the dataset is copied, feel free to trigger tests |
|
@cmsbuild , please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4235bc/19815/summary.html Comparison SummarySummary:
|
cmsbuild
added
code-checks-pending
tests-pending
and removed
tests-approved
code-checks-approved
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35776/26136
|
|
ok, the input file is cached but looks like the job is hanging for this workflow https://cmssdt.cern.ch/jenkins/job/ib-run-pr-relvals/11580/console . It is not doing any thing after printing the message I am afraid it might time out again. Have you managed to run this workflow locally ? |
|
Is the bug fix for this already in the IB being used for tests?
… On Oct 22, 2021, at 10:45 AM, Malik Shahzad Muzaffar ***@***.***> wrote:
ok, the input file is cached but looks like the job is job hanging for this workflow https://cmssdt.cern.ch/jenkins/job/ib-run-pr-relvals/11580/console . It is not doing any thing after printing the message
%MSG-w EnergyInDeadEE_FE: ***@***.*** 22-Oct-2021 10:35:55 CEST Run: 345881 Event: 18724
TP energy in the dead TT = 310.166 at (EE iz + ix 17 , iy 6)
%MSG
#--------------------------------------------------------------------------
# FastJet release 3.4.0
# M. Cacciari, G.P. Salam and G. Soyez
# A software package for jet finding and analysis at colliders
# http://fastjet.fr
#
# Please cite EPJC72(2012)1896 [arXiv:1111.6097] if you use this package
# for scientific work and optionally PLB641(2006)57 [hep-ph/0512210].
#
# FastJet is provided without warranty under the GNU GPL v2 or higher.
# It uses T. Chan's closest pair algorithm, S. Fortune's Voronoi code
# and 3rd party plugin jet algorithms. See COPYING file for details.
#--------------------------------------------------------------------------
I am afraid it might time out again. Have you managed to run this workflow locally ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
|
No - it isn't - @smuzaffar - this needs at least the 10-21-2300 build to work.. |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4235bc/19831/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
|
looking at the log for 138.3 the second event is not a splash. Considering that the first one takes about an hour, I don't feel like adding another proper splash event. The "plan" (hope?) for the near/mid term is that developers will check the slow modules and this will eventually become faster. Once that happens, perhaps another 1-2 events can be added as well. I think that I'm done with the features needed in this setup from my side. comments are welcome |
I agree with this proposal |
|
+alca |
| if newLumis and newLumis[-1][0] <= lumi[0] <= newLumis[-1][1] + 1: | ||
| newLumis[-1][1] = max(newLumis[-1][1], lumi[1]) | ||
| else: | ||
| newLumis.append(lumi) |
There was a problem hiding this comment.
I'm a little bit confused why these changes are needed (probably mostly because of not paying enough attention on what exactly this code does). I understand the point would be to support single lumi numbers in addition to pairs, but the docstring already has
cmssw/FWCore/PythonUtilities/python/LumiList.py
Lines 32 to 39 in 1a3ffb2
which to me looks like the added lumi list in the
relval_steps.py. Does this not work, or what am I missing?
|
+core |
|
+Upgrade |
|
@cms-sw/pdmv-l2 |
|
+1 |
cmsbuild
added
fully-signed
pdmv-approved
and removed
pending-signatures
pdmv-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
This is mostly an idea, but can become a full PR for the splash test data reco for run3.
The lumi and run
345881: [782, 790, 796, 801, 1031, 1037]are from https://hypernews.cern.ch/HyperNews/CMS/get/tier0-Ops/2293/1/1/1/1.htmlI may need inputs from
we will also need the files in an accessible place
I was not able to access the files with the regular xrootd read (cms-xrd-global.cern.ch). Some help to get these (or a better replacement) transferred is appreciated.
after the files are available, the number of events will likely need to be updated so that just 1 or 2 events is processed to avoid timeouts.
@drkovalskyi