Adapt CAConstants for HIon

[stahlleiton]

This PR include changes needed to avoid overflow while running the patatrack pixel tracking on HIon HLT menu using 2018 PbPb data.

The changes increase the thresholds of the following CA constants:

maxNumberOfTuples : increased from 24 * 1024 to 32 * 1024 to avoid overflow on number of tuples.
maxCellsPerHit : increased from 128 to 256 to avoid overflow on OuterHitOfCell.

PR validation:

The changes were tested on 2018 PbPb data using the HardProbe PDs.
if this PR is a backport please specify the original PR and why you need to backport that PR:

@fwyzard

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35017/24870

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @stahlleiton (Andre Stahl) for master.

It involves the following packages:

• RecoPixelVertexing/PixelTriplets (reconstruction)

@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

assign heterogeneous

[cmsbuild]

New categories assigned: heterogeneous

@fwyzard,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

[slava77]

enable gpu

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-220df6/18039/summary.html
COMMIT: 0b491a1
CMSSW: CMSSW_12_1_X_2021-08-25-1100/slc7_amd64_gcc900
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35017/18039/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 19735
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 19729
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: no differences found

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000352
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000330
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #35017 0b491a1

• code changes are in line with the PR description and seem to be in the direction of the comments from @cms-sw/heterogeneous-l2 / @fwyzard in Adapt CAConstants for HIon #34811
• jenkins tests pass and comparisons with the baseline show no differences

#34811 (comment)

The impact comes mostly from the change to the maxCellsPerHit:
maxNumberOfTuples maxCellsPerHit throughput
24k 128 1269.8 ± 3.6 ev/s
24k 256 1258.9 ± 2.9 ev/s
32k 128 1265.2 ± 2.0 ev/s
32k 256 1256.7 ± 4.0 ev/s

I'm guessing that 32k/212 will be around 1262, although it's not obvious if this linearises.

[perrotta]

for #35027 2b79cf7

This is #35107, in fact...

[slava77]

for #35027 2b79cf7

This is #35107, in fact...

thanks. It's updated now.

[fwyzard]

Actually, it turns out that maxCellsPerHit = 212 has slightly worse performance than maxCellsPerHit = 256.
I checked also maxCellsPerHit = 224 to pick a multiple of 32, and that is also marginally worse than 256:

maxNumberOfTuples	maxCellsPerHit	throughput
24 * 1024	128	1270.6 ± 4.8 ev/s
32 * 1024	128	1269.1 ± 5.9 ev/s
32 * 1024	256	1258.4 ± 5.8 ev/s
32 * 1024	212	1257.8 ± 4.1 ev/s
32 * 1024	224	1256.1 ± 6.0 ev/s

So I would suggest to just go ahead with 32 * 1024 and 256.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35017/24991

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #35017 was updated. @makortel, @jpata, @cmsbuild, @fwyzard, @slava77 can you please check and sign again.

[fwyzard]

enable gpu

[fwyzard]

please test

[fwyzard]

+heterogeneous

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-220df6/18202/summary.html
COMMIT: 241f74d
CMSSW: CMSSW_12_1_X_2021-08-31-2300/slc7_amd64_gcc900
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35017/18202/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 19735
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 19729
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: no differences found

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000404
• DQMHistoTests: Total failures: 11
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3000370
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #35017 241f74d

• code changes are in line with the PR description and the follow up review
• jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1