Adapt CAConstants for HIon #34811

stahlleiton · 2021-08-06T13:10:40Z

This PR include changes needed to avoid overflow while running the patatrack pixel tracking on HIon HLT menu using 2018 PbPb data.

The changes increase the thresholds of the following CA constants:

maxNumberOfTuples : increased from 24 * 1024 to 32 * 1024 to avoid overflow on number of tuples.
maxCellsPerHit : increased from 128 to 2 * 128 to avoid overflow on OuterHitOfCell.

PR validation:

The changes were tested on 2018 PbPb data using the HardProbe PDs.

if this PR is a backport please specify the original PR and why you need to backport that PR:

@fwyzard

cmsbuild · 2021-08-06T13:16:01Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34811/24555

This PR adds an extra 12KB to repository

cmsbuild · 2021-08-06T13:16:28Z

A new Pull Request was created by @stahlleiton (Andre Stahl) for master.

It involves the following packages:

RecoPixelVertexing/PixelTriplets (reconstruction)

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

RecoPixelVertexing/PixelTriplets/plugins/CAConstants.h

fwyzard · 2021-08-06T13:25:00Z

enable gpu

fwyzard · 2021-08-06T13:26:21Z

please test

fwyzard · 2021-08-06T13:27:57Z

assign heterogeneous

cmsbuild · 2021-08-06T13:31:46Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34811/24556

This PR adds an extra 12KB to repository

cmsbuild · 2021-08-06T13:32:05Z

New categories assigned: heterogeneous

@fwyzard,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild · 2021-08-06T13:32:07Z

Pull request #34811 was updated. @perrotta, @makortel, @fwyzard, @jpata, @slava77 can you please check and sign again.

cmsbuild · 2021-08-06T21:59:48Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-45810e/17611/summary.html
COMMIT: aabb0db
CMSSW: CMSSW_12_1_X_2021-08-05-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34811/17611/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

11601.011601.0_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
11602.011602.0_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
11603.011603.0_SingleElectronPt1000+2021+SingleElectronPt1000_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt1000+2021+SingleElectronPt1000_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log

Expand to see more relval errors ...

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2999410
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2999381
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

stahlleiton · 2021-08-25T16:21:25Z

Sorry, seems I made a mistake while trying to go to a different release (the daily CMSSW development release I was using had already expired).

How do I go to a newer release without all commits appearing in the history?

cmsbuild · 2021-08-25T16:26:56Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34811/24869

This PR adds an extra 16KB to repository
Found files with invalid states:
- Geometry/VeryForwardData/data/dd4hep/cmsExtendedGeometry2021,xml:
  - Added: 75859ae
  - Deleted: e571303
- SimCalorimetry/HcalSimProducers/plugins/HcalDigiProducer.cc:
  - Added: bbdfbaf
  - Deleted: fea5cc2
- SimCalorimetry/HcalSimProducers/plugins/SealModule.cc:
  - Deleted: bbdfbaf
  - Added: fea5cc2
- Validation/Geometry/test/runMaterialBudgetVolumeBigXML_cfg.py:
  - Added: b04428b
  - Deleted: ec08c83
- SimG4Core/PrintGeomInfo/data/dd4hep/hcalRecNumbering.xml:
  - Added: b04428b
  - Deleted: 076def7
- SimCalorimetry/HcalSimProducers/src/HcalDigiProducer.cc:
  - Deleted: bbdfbaf
  - Added: fea5cc2
- SimG4Core/PrintGeomInfo/data/dd4hep/hcalSimNumbering.xml:
  - Added: b04428b
  - Deleted: 076def7
There are other open Pull requests which might conflict with changes you have proposed:
- File Alignment/OfflineValidation/python/TkAlAllInOneTool/offlineValidationTemplates.py modified in PR(s): Fix on compile issues with DMR, MTS and GC validation scripts. #35016
- File CondCore/Utilities/src/CondDBFetch.cc modified in PR(s): Removed lexical_cast boost dependency in CondCore #34932
- File Configuration/Applications/python/ConfigBuilder.py modified in PR(s): Add SiStripCalCosmics ALCANANO #34985
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): NANO: rework for Prompt (part3) #34714, Add SiStripCalCosmics ALCANANO #34985
- File Configuration/StandardSequences/python/AlCaRecoStreams_cff.py modified in PR(s): Add SiStripCalCosmics ALCANANO #34985
- File DQM/SiPixelMonitorDigi/src/SiPixelDigiSource.cc modified in PR(s): TkDQM: fix reset counter logic in SiPixelDigiSource #32875
- File FWCore/Framework/src/EDAnalyzer.cc modified in PR(s): Make EventSetup get to throw if called without a token when EDModule consumed any ES product #31746
- File FWCore/Framework/src/EDProducer.cc modified in PR(s): Make EventSetup get to throw if called without a token when EDModule consumed any ES product #31746
- File FWCore/Framework/src/global/EDAnalyzerBase.cc modified in PR(s): Make EventSetup get to throw if called without a token when EDModule consumed any ES product #31746
- File FWCore/Framework/src/global/EDFilterBase.cc modified in PR(s): Make EventSetup get to throw if called without a token when EDModule consumed any ES product #31746
- File FWCore/Framework/src/global/EDProducerBase.cc modified in PR(s): Make EventSetup get to throw if called without a token when EDModule consumed any ES product #31746
- File FWCore/Framework/src/limited/EDAnalyzerBase.cc modified in PR(s): Make EventSetup get to throw if called without a token when EDModule consumed any ES product #31746
- File FWCore/Framework/src/limited/EDFilterBase.cc modified in PR(s): Make EventSetup get to throw if called without a token when EDModule consumed any ES product #31746
- File FWCore/Framework/src/limited/EDProducerBase.cc modified in PR(s): Make EventSetup get to throw if called without a token when EDModule consumed any ES product #31746
- File FWCore/Framework/src/one/EDAnalyzerBase.cc modified in PR(s): Make EventSetup get to throw if called without a token when EDModule consumed any ES product #31746
- File FWCore/Framework/src/one/EDFilterBase.cc modified in PR(s): Make EventSetup get to throw if called without a token when EDModule consumed any ES product #31746
- File FWCore/Framework/src/one/EDProducerBase.cc modified in PR(s): Make EventSetup get to throw if called without a token when EDModule consumed any ES product #31746
- File FWCore/Framework/src/stream/EDAnalyzerAdaptorBase.cc modified in PR(s): Make EventSetup get to throw if called without a token when EDModule consumed any ES product #31746
- File FWCore/Framework/src/stream/EDFilterAdaptorBase.cc modified in PR(s): Make EventSetup get to throw if called without a token when EDModule consumed any ES product #31746
- File FWCore/Framework/src/stream/EDProducerAdaptorBase.cc modified in PR(s): Make EventSetup get to throw if called without a token when EDModule consumed any ES product #31746
- File FWCore/Framework/src/stream/ProducingModuleAdaptorBase.cc modified in PR(s): Make EventSetup get to throw if called without a token when EDModule consumed any ES product #31746
- File FWCore/Framework/test/BuildFile.xml modified in PR(s): Make EventSetup get to throw if called without a token when EDModule consumed any ES product #31746
- File HLTrigger/Configuration/python/customizeHLTforCMSSW.py modified in PR(s): Add support for the gpu modifier at HLT #34978, Add GEM unpacker in L1Repack FullMC and temporary load of GEM geometry to hltGetConfiguration #34788
- File Mixing/Base/src/PileUp.cc modified in PR(s): Migrate BMixingModule and EcalShapeBase-derived classes to esConsumes #34902
- File PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py modified in PR(s): Bug fix for track MET in MET correction tools #34860, Unify vertex association between CHS and PUPPI #33885
- File SimG4Core/PrintGeomInfo/test/SimFileCompare.cpp modified in PR(s): Run3-sim104 Update the tools to investigate geometry setups #35015
- File SimPPS/PPSSimTrackProducer/plugins/PPSSimTrackProducer.cc modified in PR(s): Migrate some modules in SimPPS to esConsumes #34989
- File Validation/EcalDigis/plugins/EcalMixingModuleValidation.cc modified in PR(s): Migrate BMixingModule and EcalShapeBase-derived classes to esConsumes #34902
- File Validation/EcalDigis/plugins/EcalMixingModuleValidation.h modified in PR(s): Migrate BMixingModule and EcalShapeBase-derived classes to esConsumes #34902
- File Validation/Geometry/macros/MatBudgetVolume.C modified in PR(s): Run3-sim104 Update the tools to investigate geometry setups #35015
- File Validation/RecoParticleFlow/test/compare.py modified in PR(s): Adding jet efficiency and purity plots #34580

cmsbuild · 2021-08-25T16:27:45Z

Pull request #34811 was updated. @SiewYan, @andrius-k, @jpata, @lveldere, @chayanit, @bbilin, @wajidalikhan, @sbein, @ianna, @Saptaparna, @Martin-Grunewald, @rekovic, @tlampen, @alberto-sanchez, @pohsun, @santocch, @cecilecaillol, @perrotta, @civanch, @yuanchao, @makortel, @ErnestaP, @ahmad3213, @cmsbuild, @agrohsje, @fwyzard, @GurpreetSinghChahal, @smorovic, @davidlange6, @smuzaffar, @Dr15Jones, @cvuosalo, @mdhildreth, @jfernan2, @kpedro88, @kskovpen, @slava77, @ggovi, @qliphy, @fabiocos, @francescobrivio, @malbouis, @ssekmen, @mkirsano, @jordan-martins, @AdrianoDee, @kmaeshima, @emeschi, @alja, @srimanob, @rvenditti, @tvami can you please check and sign again.

cmsbuild added this to the CMSSW_12_1_X milestone Aug 6, 2021

cmsbuild added code-checks-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Aug 6, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 6, 2021

fwyzard reviewed Aug 6, 2021

View reviewed changes

RecoPixelVertexing/PixelTriplets/plugins/CAConstants.h Show resolved Hide resolved

cmsbuild added tests-started and removed tests-pending labels Aug 6, 2021

cmsbuild added code-checks-pending tests-pending and removed tests-started code-checks-approved labels Aug 6, 2021

cmsbuild added tests-started and removed tests-pending labels Aug 6, 2021

cmsbuild added the heterogeneous-pending label Aug 6, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 6, 2021

cmsbuild removed the tests-started label Aug 6, 2021

Updated the maxCellsPerHit threshold

0b491a1

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 25, 2021

stahlleiton closed this Aug 25, 2021

slava77 mentioned this pull request Aug 27, 2021

Adapt CAConstants for HIon #35017

Merged

stahlleiton deleted the CMSSW_12_1_X_GPU_HIon_v1 branch September 1, 2021 21:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adapt CAConstants for HIon #34811

Adapt CAConstants for HIon #34811

stahlleiton commented Aug 6, 2021

cmsbuild commented Aug 6, 2021

cmsbuild commented Aug 6, 2021

fwyzard commented Aug 6, 2021

fwyzard commented Aug 6, 2021

fwyzard commented Aug 6, 2021

cmsbuild commented Aug 6, 2021

cmsbuild commented Aug 6, 2021

cmsbuild commented Aug 6, 2021

cmsbuild commented Aug 6, 2021

stahlleiton commented Aug 25, 2021

cmsbuild commented Aug 25, 2021

cmsbuild commented Aug 25, 2021

Adapt CAConstants for HIon #34811

Adapt CAConstants for HIon #34811

Conversation

stahlleiton commented Aug 6, 2021

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Aug 6, 2021

cmsbuild commented Aug 6, 2021

fwyzard commented Aug 6, 2021

fwyzard commented Aug 6, 2021

fwyzard commented Aug 6, 2021

cmsbuild commented Aug 6, 2021

cmsbuild commented Aug 6, 2021

cmsbuild commented Aug 6, 2021

cmsbuild commented Aug 6, 2021

RelVals-INPUT

Comparison Summary

stahlleiton commented Aug 25, 2021

cmsbuild commented Aug 25, 2021

cmsbuild commented Aug 25, 2021