-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding jet efficiency and purity plots #34580
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34580/24130
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34580/24131
|
A new Pull Request was created by @garvitaa for master. It involves the following packages:
@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34580/24136
|
Pull request #34580 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again. |
please test |
-1 Failed Tests: Build BuildI found compilation warning when building: See details on the summary page. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34580/24341
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34580/24353
|
Pull request #34580 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again. |
please test |
-1 Failed Tests: Build BuildI found compilation warning when building: See details on the summary page. |
@garvitaa what are your plans for this PR? |
ping @garvitaa |
closing it now. Please open a new one if needed. @garvitaa |
PR description:
Should be able to produce validation plots with pv_z, et efficiency, Jet Purity and PU Jet rate distributions.
PR validation:
Ran scram tests, produced the validation plots successfully and presented at PFlow meeting (https://indico.cern.ch/event/1050783/#3-studying-the-hgcal-and-hf-hg)
if this PR is a backport please specify the original PR and why you need to backport that PR:
NA