[GCC11] Fix compilation warning for EcalMatacqDigi #35148

smuzaffar · 2021-09-03T16:05:04Z

This should fix the two compilation warnings of GCC11 IBs

  DataFormats/EcalDigi/interface/EcalMatacqDigi.h:16:7: warning: 'matacqDigi.EcalMatacqDigi::freq' may be used uninitialized [-Wmaybe-uninitialized]
    16 | class EcalMatacqDigi {
      |       ^~~~~~~~~~~~~~
  DataFormats/EcalDigi/interface/EcalMatacqDigi.h:16:7: warning: '*(const __vector(2) long long int*)((char*)&matacqDigi + offsetof(EcalMatacqDigi, EcalMatacqDigi::tv_sec_))' may be used uninitialized [-Wmaybe-uninitialized]
    16 | class EcalMatacqDigi {
      |       ^~~~~~~~~~~~~~

It also fixes the conditional code so that the init() ( https://github.com/cms-sw/cmssw/blob/master/DataFormats/EcalDigi/interface/EcalMatacqDigi.h#L32 ) method is also declared/defined for #define ECAL_MATACQ_DIGI_VERS 1 (https://github.com/cms-sw/cmssw/blob/master/DataFormats/EcalDigi/interface/EcalMatacqDigi.h#L11)

smuzaffar · 2021-09-03T16:05:14Z

please test

cmsbuild · 2021-09-03T16:09:15Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35148/25066

This PR adds an extra 16KB to repository

cmsbuild · 2021-09-03T16:09:35Z

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

DataFormats/EcalDigi (simulation)

@civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@rchatter, @simonepigazzini, @rovere, @thomreis, @argiro this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

smuzaffar · 2021-09-03T16:12:19Z

please test for slc7_amd64_gcc11

cmsbuild · 2021-09-03T19:08:14Z

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be8c79/18296/summary.html
COMMIT: 65d2302
CMSSW: CMSSW_12_1_X_2021-09-01-1100/slc7_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35148/18296/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be8c79/18296/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be8c79/18296/git-merge-result

Found compilation warnings

Unit Tests

I found errors in the following unit tests:

---> test testPhase2PixelNtuple had ERRORS

RelVals

312.0

----- Begin Fatal Exception 03-Sep-2021 20:29:10 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Running EventSetup component CSCL1TPLookupTableEP/'
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/GEMCSC/BendingAngle/GEMCSCLUT_es_diff_slope_L1_ME1a_even.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35148/18296/CMSSW_12_1_X_2021-09-01-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35148/18296/CMSSW_12_1_X_2021-09-01-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35148/18296/CMSSW_12_1_X_2021-09-01-1100/external/slc7_amd64_gcc11/data:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-09-01-1100/src:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-09-01-1100/external/slc7_amd64_gcc11/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/runTheMatrix-results/312.0_Pyquen_ZeemumuJets_pt10_2760GeV_2021+Pyquen_ZeemumuJets_pt10_2760GeV_2021+DIGIHI2021MIX+RECOHI2021MIX+HARVESTHI2021PPRECO
----- End Fatal Exception -------------------------------------------------

11634.0

----- Begin Fatal Exception 03-Sep-2021 20:39:58 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Running EventSetup component CSCL1TPLookupTableEP/'
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/GEMCSC/BendingAngle/GEMCSCLUT_es_diff_slope_L1_ME1a_even.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35148/18296/CMSSW_12_1_X_2021-09-01-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35148/18296/CMSSW_12_1_X_2021-09-01-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35148/18296/CMSSW_12_1_X_2021-09-01-1100/external/slc7_amd64_gcc11/data:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-09-01-1100/src:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-09-01-1100/external/slc7_amd64_gcc11/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/runTheMatrix-results/11634.0_TTbar_14TeV+2021+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA
----- End Fatal Exception -------------------------------------------------

11634.912

----- Begin Fatal Exception 03-Sep-2021 20:41:19 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Running EventSetup component CSCL1TPLookupTableEP/'
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/GEMCSC/BendingAngle/GEMCSCLUT_es_diff_slope_L1_ME1a_even.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35148/18296/CMSSW_12_1_X_2021-09-01-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35148/18296/CMSSW_12_1_X_2021-09-01-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35148/18296/CMSSW_12_1_X_2021-09-01-1100/external/slc7_amd64_gcc11/data:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-09-01-1100/src:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-09-01-1100/external/slc7_amd64_gcc11/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/runTheMatrix-results/11634.912_TTbar_14TeV+2021_DD4hepDB+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

AddOn Tests

hlt_mc_GRun

----- Begin Fatal Exception 03-Sep-2021 20:24:51 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Running EventSetup component CSCL1TPLookupTableEP/'
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/GEMCSC/BendingAngle/GEMCSCLUT_es_diff_slope_L1_ME1a_even.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35148/18296/CMSSW_12_1_X_2021-09-01-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35148/18296/CMSSW_12_1_X_2021-09-01-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35148/18296/CMSSW_12_1_X_2021-09-01-1100/external/slc7_amd64_gcc11/data:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-09-01-1100/src:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-09-01-1100/external/slc7_amd64_gcc11/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-addon/addOnTests/hlt_mc_GRun
----- End Fatal Exception -------------------------------------------------

hlt_mc_HIon

----- Begin Fatal Exception 03-Sep-2021 20:24:57 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Running EventSetup component CSCL1TPLookupTableEP/'
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/GEMCSC/BendingAngle/GEMCSCLUT_es_diff_slope_L1_ME1a_even.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35148/18296/CMSSW_12_1_X_2021-09-01-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35148/18296/CMSSW_12_1_X_2021-09-01-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35148/18296/CMSSW_12_1_X_2021-09-01-1100/external/slc7_amd64_gcc11/data:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-09-01-1100/src:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-09-01-1100/external/slc7_amd64_gcc11/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-addon/addOnTests/hlt_mc_HIon
----- End Fatal Exception -------------------------------------------------

hlt_mc_PIon

----- Begin Fatal Exception 03-Sep-2021 20:24:54 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Running EventSetup component CSCL1TPLookupTableEP/'
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/GEMCSC/BendingAngle/GEMCSCLUT_es_diff_slope_L1_ME1a_even.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35148/18296/CMSSW_12_1_X_2021-09-01-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35148/18296/CMSSW_12_1_X_2021-09-01-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35148/18296/CMSSW_12_1_X_2021-09-01-1100/external/slc7_amd64_gcc11/data:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-09-01-1100/src:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-09-01-1100/external/slc7_amd64_gcc11/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-addon/addOnTests/hlt_mc_PIon
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

hlt_mc_PRef

cmsbuild · 2021-09-03T19:34:52Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be8c79/18295/summary.html
COMMIT: 65d2302
CMSSW: CMSSW_12_1_X_2021-09-03-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35148/18295/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 3000404
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3000382
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

civanch · 2021-09-04T21:06:06Z

+1

cmsbuild · 2021-09-04T21:06:29Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2021-09-05T06:26:56Z

@smuzaffar @civanch I wonder whether the freq class member is even needed at all: it is never used, not even considered in the swap method: I think the warning could be more conveniently fixed by simply removing that freq (which by the way is the only class member written without a trailing underscore: it looks like some remnants of some older version of the code...)

smuzaffar · 2021-09-06T07:37:25Z

@perrotta , this is a persistant class ( https://github.com/cms-sw/cmssw/blob/master/DataFormats/EcalDigi/src/classes_def.xml#L51-L54 ) so I am not sure what will happen if we drop this

perrotta · 2021-09-06T08:35:47Z

@perrotta , this is a persistant class ( https://github.com/cms-sw/cmssw/blob/master/DataFormats/EcalDigi/src/classes_def.xml#L51-L54 ) so I am not sure what will happen if we drop this

Just update the class version?
Since we are touching it anyhow, if that member isn't needed at all I would rather drop it. Even with an updated class version everything continues to be fully backward compatible, because nobody was looking for that (private) member

civanch · 2021-09-06T08:51:44Z

@smuzaffar , @perrotta , if I would make this PR I would drop the class member as Andrea propose. I have signed Shahzad variant of the fix only because the class is not important and the fix is working.

smuzaffar · 2021-09-06T11:56:42Z

ok , I have removed the unused EcalMatacqDigi::freq data member now

cmsbuild · 2021-09-06T12:01:41Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35148/25092

This PR adds an extra 20KB to repository

cmsbuild · 2021-09-06T12:02:01Z

Pull request #35148 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

smuzaffar · 2021-09-06T12:02:06Z

please test

cmsbuild · 2021-09-06T15:14:13Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be8c79/18333/summary.html
COMMIT: 9712294
CMSSW: CMSSW_12_1_X_2021-09-05-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35148/18333/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 3001001
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3000979
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

civanch · 2021-09-06T18:22:34Z

+1

cmsbuild · 2021-09-06T18:22:55Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2021-09-06T21:23:50Z

+1

[GCC11] Fix compilation warning for EcalMatacqDigi

65d2302

cmsbuild added this to the CMSSW_12_1_X milestone Sep 3, 2021

cmsbuild added code-checks-pending orp-pending pending-signatures simulation-pending tests-started labels Sep 3, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 3, 2021

cmsbuild added tests-approved and removed tests-started labels Sep 3, 2021

cmsbuild added fully-signed simulation-approved and removed simulation-pending pending-signatures labels Sep 4, 2021

remove unused data member EcalMatacqDigi::freq

9712294

cmsbuild removed simulation-approved fully-signed labels Sep 6, 2021

cmsbuild added code-checks-pending pending-signatures simulation-pending tests-pending and removed tests-approved code-checks-approved labels Sep 6, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 6, 2021

cmsbuild added tests-started and removed tests-pending labels Sep 6, 2021

cmsbuild added tests-approved and removed tests-started labels Sep 6, 2021

cmsbuild added fully-signed simulation-approved and removed simulation-pending pending-signatures labels Sep 6, 2021

cmsbuild added orp-approved and removed orp-pending labels Sep 6, 2021

cmsbuild merged commit f2d6c16 into cms-sw:master Sep 6, 2021

smuzaffar mentioned this pull request Sep 7, 2021

[GCC11] Warning: matacqDigi.EcalMatacqDigi::freq could be undefined #34850

Closed

cmsbuild mentioned this pull request Sep 8, 2021

Updated root to tip of branch v6-24-00-patches cms-sw/cmsdist#7271

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GCC11] Fix compilation warning for EcalMatacqDigi #35148

[GCC11] Fix compilation warning for EcalMatacqDigi #35148

smuzaffar commented Sep 3, 2021

smuzaffar commented Sep 3, 2021

cmsbuild commented Sep 3, 2021

cmsbuild commented Sep 3, 2021

smuzaffar commented Sep 3, 2021

cmsbuild commented Sep 3, 2021

cmsbuild commented Sep 3, 2021

civanch commented Sep 4, 2021

cmsbuild commented Sep 4, 2021

perrotta commented Sep 5, 2021

smuzaffar commented Sep 6, 2021

perrotta commented Sep 6, 2021

civanch commented Sep 6, 2021

smuzaffar commented Sep 6, 2021

cmsbuild commented Sep 6, 2021

cmsbuild commented Sep 6, 2021

smuzaffar commented Sep 6, 2021

cmsbuild commented Sep 6, 2021

civanch commented Sep 6, 2021

cmsbuild commented Sep 6, 2021

perrotta commented Sep 6, 2021

[GCC11] Fix compilation warning for EcalMatacqDigi #35148

[GCC11] Fix compilation warning for EcalMatacqDigi #35148

Conversation

smuzaffar commented Sep 3, 2021

smuzaffar commented Sep 3, 2021

cmsbuild commented Sep 3, 2021

cmsbuild commented Sep 3, 2021

smuzaffar commented Sep 3, 2021

cmsbuild commented Sep 3, 2021

Unit Tests

RelVals

AddOn Tests

cmsbuild commented Sep 3, 2021

Comparison Summary

civanch commented Sep 4, 2021

cmsbuild commented Sep 4, 2021

perrotta commented Sep 5, 2021

smuzaffar commented Sep 6, 2021

perrotta commented Sep 6, 2021

civanch commented Sep 6, 2021

smuzaffar commented Sep 6, 2021

cmsbuild commented Sep 6, 2021

cmsbuild commented Sep 6, 2021

smuzaffar commented Sep 6, 2021

cmsbuild commented Sep 6, 2021

Comparison Summary

civanch commented Sep 6, 2021

cmsbuild commented Sep 6, 2021

perrotta commented Sep 6, 2021