-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue with watching Runs and LuminosityBlocks in Calibration/TkAlCaRecoProducers #33866
fix issue with watching Runs and LuminosityBlocks in Calibration/TkAlCaRecoProducers #33866
Conversation
type bug-fix |
urgent |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33866/22896
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: Calibration/TkAlCaRecoProducers @malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
I tested the backport to this PR in 11.3.X and it works as expected. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ec3389/15359/summary.html Comparison SummarySummary:
|
+alca
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
In PR #32432 the classes
AlcaBeamSpotHarvester
andPCLMetadataWriter
have been migrated from legacyEDAnalyzer
s toedm::one::EDAnalyzer
, though not correctly as they need to observe bothRun
andLuminosityBlock
transitions in order to supportbeginRun|LuminosityBlock
andendRun|LuminosityBlock
methods that are doing actual work. This has resulted e.g. in the problem reported in this Tier-0 Hypernew thread.This PR fixes the issue.
PR validation:
It compiles.
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport, but a backport for the 11_3_X cycle is going to be needed to support MWGRs.