Introduce AlCaHarvesting / PCLMetadataWriter unit test

[mmusich]

PR description:

The issue fixed at #33866 and discussed in this Tier-0 Hypernew thread highlighted that the PCLMetadataWriter mechanism - which is crucial to dispatch the correct tag names for upload in the Tier-0 PCL workflow - is currently NOT actively tested in cmssw integration tests.
This PR creates a unit test that covers this functionality.
I profit of this PR to perform two very minor bug-fixes:

• commit cc9852d protects the case in which there is no input histogram to harvest in SiStripGainsPCLHarvester
• commit 0a5f3d1 fixes a typo in SiStripQualityHotStripIdentifierRoot.

PR validation:

Run the augmented unit tests.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, no backport needed.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33880/22916

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CalibTracker/SiStripChannelGain
Calibration/TkAlCaRecoProducers
DQMOffline/CalibTracker

@malbouis, @andrius-k, @yuanchao, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @tlampen, @pohsun, @francescobrivio, @rvenditti can you please review it and eventually sign? Thanks.
@echabert, @pieterdavid, @robervalwalsh, @gbenelli, @tocheng, @alesaggio, @mmusich, @threus, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-74fc1f/15389/summary.html
COMMIT: 0a5f3d1
CMSSW: CMSSW_12_0_X_2021-05-28-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33880/15389/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2650486
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2650463
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[francescobrivio]

+alca

Thanks @mmusich for adding this unitTest!

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[mmusich]

@francescobrivio @jfernan2 I am sorry, I realized that the script doesn't actually return failure in case of failure.
The last commit should be OK now.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33880/22928

• This PR adds an extra 28KB to repository

[cmsbuild]

Pull request #33880 was updated. @malbouis, @andrius-k, @yuanchao, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @tlampen, @pohsun, @francescobrivio, @rvenditti can you please check and sign again.

[francescobrivio]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-74fc1f/15395/summary.html
COMMIT: 61f3cb0
CMSSW: CMSSW_12_0_X_2021-05-28-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33880/15395/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2650486
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2650463
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[francescobrivio]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1