-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Calibration/TkAlCaRecoProducers to esConsumes and other fixes #32432
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32432/20309
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: Alignment/APEEstimation @cmsbuild, @pohsun, @yuanchao, @christopheralanwest, @tlampen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 |
Comparison results are now available Comparison Summary:
|
46dcecd
to
65cdaec
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32432/20400
|
5bb0c87
to
70dc373
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32432/20416
|
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6be748/11688/summary.html Comparison SummarySummary:
|
@christopheralanwest ping |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The main goal of this PR is to migrate to
esConsumes
theCalibration/TkAlCaRecoProducer
subsystem (as part of issue #31061)I profit of this PR to perform also the following:
#include "FWCore/Framework/interface/ESHandle.h"
left from previous migrations"UnkownType"
=>"UnknownType"
typo highlighted in Adapt Tracker Alignment PV Validation to work with phase-2 geometries #32363 (comment)Calibration/TkAlCaRecoProducers/plugins/PCLMetadataWriter.h
is removed and all code included in the.cc
(as recommended for plugins).PR validation:
cmssw
compiles.if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport, no backport needed.