Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Calibration/TkAlCaRecoProducers to esConsumes and other fixes #32432

Merged
merged 6 commits into from
Dec 15, 2020

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Dec 9, 2020

PR description:

The main goal of this PR is to migrate to esConsumes the Calibration/TkAlCaRecoProducer subsystem (as part of issue #31061)
I profit of this PR to perform also the following:

PR validation:

cmssw compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, no backport needed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32432/20309

  • This PR adds an extra 160KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2020

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Alignment/APEEstimation
Alignment/CommonAlignmentProducer
Alignment/OfflineValidation
Calibration/TkAlCaRecoProducers

@cmsbuild, @pohsun, @yuanchao, @christopheralanwest, @tlampen can you please review it and eventually sign? Thanks.
@pakhotin, @adewit, @tocheng, @tlampen, @mschrode, @mmusich, @threus this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Dec 9, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2020

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6be748/11470/summary.html
CMSSW: CMSSW_11_3_X_2020-12-08-2300/slc7_amd64_gcc900

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2020

Comparison results are now available
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6be748/11470/summary.html
CMSSW: CMSSW_11_3_X_2020-12-08-2300/slc7_amd64_gcc900

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2747014
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2746985
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 35 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 153 log files, 37 edm output root files, 36 DQM output files

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32432/20400

  • This PR adds an extra 160KB to repository

@cmsbuild
Copy link
Contributor

Pull request #32432 was updated. @cmsbuild, @pohsun, @yuanchao, @christopheralanwest, @tlampen can you please check and sign again.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32432/20416

  • This PR adds an extra 160KB to repository

@cmsbuild
Copy link
Contributor

Pull request #32432 was updated. @cmsbuild, @pohsun, @yuanchao, @christopheralanwest, @tlampen can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Dec 15, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6be748/11688/summary.html
CMSSW: CMSSW_11_3_X_2020-12-15-1100/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2747284
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2747255
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 153 log files, 37 edm output root files, 36 DQM output files

@mmusich
Copy link
Contributor Author

mmusich commented Dec 15, 2020

@christopheralanwest ping

@christopheralanwest
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants