HFNose: ticl updates #33001

mariadalfonso · 2021-02-25T16:56:21Z

customize the ticl parameters after the ticl3 update
fix rhtools_.getPositionLayer recently added
adds EM track seeded and Hadronic iterations
add caloParticles

updates only on HFnose, no changes expected on HGCAL

cmsbuild · 2021-02-25T17:03:10Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33001/21273

This PR adds an extra 32KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoHGCal/TICL/plugins/TICLSeedingRegionProducer.cc modified in PR(s): Seed TICL by L1 e/gamma + other timing considerations for e/gamma HLT #32978

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33001/21273/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33001/21273/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-02-25T18:38:03Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33001/21277

This PR adds an extra 32KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoHGCal/TICL/plugins/TICLSeedingRegionProducer.cc modified in PR(s): Seed TICL by L1 e/gamma + other timing considerations for e/gamma HLT #32978

cmsbuild · 2021-02-25T18:38:23Z

A new Pull Request was created by @mariadalfonso for master.

It involves the following packages:

RecoHGCal/Configuration
RecoHGCal/TICL
SimGeneral/MixingModule

@perrotta, @civanch, @kpedro88, @cmsbuild, @srimanob, @mdhildreth, @slava77, @jpata can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @rovere, @apsallid, @sobhatta, @clelange, @lecriste, @hatakeyamak, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

RecoHGCal/TICL/plugins/SeedingRegionByTracks.h

rovere · 2021-02-27T18:23:37Z

RecoHGCal/TICL/python/EMStep_cff.py

    filtered_mask = "filteredLayerClustersHFNoseEM:EMn",
    seeding_regions = "ticlSeedingGlobalHFNose",
    time_layerclusters = "hgcalLayerClustersHFNose:timeLayerCluster",
-    min_layers_per_trackster = 6
+    itername = "EMn",


Could you use a more expressive name? Also for the downstream HADn and TrkEMn.

rovere · 2021-02-27T18:27:19Z

RecoHGCal/TICL/python/HADStep_cff.py

@@ -1,6 +1,6 @@
 import FWCore.ParameterSet.Config as cms

-from RecoHGCal.TICL.TICLSeedingRegions_cff import ticlSeedingGlobal
+from RecoHGCal.TICL.TICLSeedingRegions_cff import ticlSeedingGlobal, ticlSeedingGlobalHFNose, ticlSeedingForHFHFNose


I cannot find where ticlSeedingForHFHFNose is defined.
Possibly you meant ticlSeedingTrkHFNose?

the test failed because the ticlSeedingForHFHFNose wasn't committed; I did now.
ticlSeedingByHFHFNose allows to seed from a HFcell; but the iteration is not build as would be better to build the trackster outside-in.

for the hadrons I foresee 3 set of iterations:

early shower for charger particle: track seeded + short trackster

late shower: HFseeded with outside-in trackster

all the rest will be taken from the self seeded

rovere · 2021-02-27T18:35:51Z

@mariadalfonso Out of curiosity, how did you solve the propagation to HFNose business?

rovere · 2021-02-27T18:36:03Z

@cmsbuild please test

cmsbuild · 2021-02-27T20:55:30Z

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-547c7c/13140/summary.html
COMMIT: e453f78
CMSSW: CMSSW_11_3_X_2021-02-26-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33001/13140/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals

5.15.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log
135.4135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log
140.56140.56_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18/step2_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18.log

Expand to see more relval errors ...

RelVals-INPUT

4.64.6_MinimumBias2010A+MinimumBias2010A+RECOSKIMALCA+HARVESTDR1/step2_MinimumBias2010A+MinimumBias2010A+RECOSKIMALCA+HARVESTDR1.log
140.54140.54_RunPA2013+RunPA2013+RECO_PPbData+HARVEST_PPbData/step2_RunPA2013+RunPA2013+RECO_PPbData+HARVEST_PPbData.log
140.56140.56_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18/step2_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18.log

Expand to see more relval errors ...

AddOn Tests

fastsimcmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Sat Feb 27 19:52:49 2021-date Sat Feb 27 19:52:40 2021 s - exit: 256
hlt_data_Fake2cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_DATA.root --fileout file:RelVal_Raw_Fake2_DATA_HLT_RECO.root : FAILED - time: date Sat Feb 27 20:19:52 2021-date Sat Feb 27 19:52:44 2021 s - exit: 256
hlt_data_PRefcmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run3_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Sat Feb 27 20:18:14 2021-date Sat Feb 27 19:52:48 2021 s - exit: 256

Expand to see more addon errors ...

cmsbuild · 2021-03-15T13:24:32Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-547c7c/13506/summary.html
COMMIT: b1df50f
CMSSW: CMSSW_11_3_X_2021-03-14-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33001/13506/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 5 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2635087
DQMHistoTests: Total failures: 103
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2634962
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 155 log files, 37 edm output root files, 37 DQM output files

jpata · 2021-03-15T13:46:45Z

Thanks for the updates. Looks like tests run now, no more crash in the validator. There are some HGCAL reco and DQM differences. @mariadalfonso et al, do they look OK to you?

mariadalfonso · 2021-03-16T15:31:47Z

Thanks for the updates. Looks like tests run now, no more crash in the validator. There are some HGCAL reco and DQM differences. @mariadalfonso et al, do they look OK to you?

https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_3_X_2021-03-12-1100+547c7c/41671/validateJR/all_OldVSNew_TTbar14TeV2026D60wf28234p0/all_OldVSNew_TTbar14TeV2026D60wf28234p0c_recoPFClusters_particleFlowClusterHGCal__RECO_obj_eta.png

The few differences on HGCal are related to the particleFlowClusterHGCal. This particleFlowClusterHGCal (likely) depends on the caloParticles change as I suspect the particleFlowClusterHGCal still depend on the sim-assisted reco.
The validation package now doesn't show the differences of the HFnose (eta 3-4.2) because of hardcoded values in Validation/HGCalValidation.

jfernan2 · 2021-03-16T16:16:17Z

And any idea why these differences appear only in wf 28234.0 and not in the rest of Phase2 samples?
Thanks

mariadalfonso · 2021-03-16T17:28:18Z

And any idea why these differences appear only in wf 28234.0 and not in the rest of Phase2 samples?
Thanks

yes, the HFnose is only in the WF28234.0 ( as HFnose it's not in the approved Phase2 detector for Run4 )

the phase2_hfnose era activate the caloParticles here
https://github.com/cms-sw/cmssw/pull/33001/files#diff-969698d33dc7e57ea0dce87e527740aa866cc4c22da5216aaa83e740ec617b65R38

jfernan2 · 2021-03-16T17:30:26Z

+1

jpata · 2021-03-17T10:47:56Z

+reconstruction

TICL updates for HFNose
reco changes only in the Phase2 workflow 28234.0 which contains HFNose, as expected

mariadalfonso · 2021-03-21T19:44:24Z

@civanch, @kpedro88, @srimanob

would be great if we can get this in the 11_3_pre5 for this Tuesday

civanch · 2021-03-21T20:32:17Z

+1

srimanob · 2021-03-22T02:15:13Z

+Upgrade

cmsbuild · 2021-03-22T02:15:41Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2021-03-22T08:34:21Z

+1

cmsbuild added this to the CMSSW_11_3_X milestone Feb 25, 2021

cmsbuild added code-checks-pending orp-pending pending-signatures reconstruction-pending simulation-pending tests-pending upgrade-pending labels Feb 25, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels Feb 25, 2021

mariadalfonso changed the title ~~Ticl nosefixes~~ HFNose: ticl updates Feb 25, 2021

cmsbuild added code-checks-pending and removed code-checks-rejected labels Feb 25, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 25, 2021

rovere reviewed Feb 27, 2021

View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Feb 27, 2021

cmsbuild added tests-rejected code-checks-pending tests-pending and removed tests-started code-checks-approved tests-rejected labels Feb 27, 2021

cmsbuild added tests-approved and removed tests-started labels Mar 15, 2021

cmsbuild added dqm-approved and removed dqm-pending labels Mar 16, 2021

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Mar 17, 2021

cmsbuild added simulation-approved and removed simulation-pending labels Mar 21, 2021

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Mar 22, 2021

cmsbuild added orp-approved and removed orp-pending labels Mar 22, 2021

cmsbuild merged commit 3070a54 into cms-sw:master Mar 22, 2021

This was referenced Mar 22, 2021

Use phase1PixelTopology::numberOfLayers where appropriate #33244

Merged

moving DataFormats/RecoCandidate/interface/TrackAssociation.h into SimDataFormats #33186

Merged

update dict map as TTTrackTruthPair is now part of Associations #33247

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HFNose: ticl updates #33001

HFNose: ticl updates #33001

mariadalfonso commented Feb 25, 2021 •

edited

Loading

cmsbuild commented Feb 25, 2021

cmsbuild commented Feb 25, 2021

cmsbuild commented Feb 25, 2021

rovere Feb 27, 2021

rovere Feb 27, 2021

mariadalfonso Feb 28, 2021

mariadalfonso Feb 28, 2021

rovere commented Feb 27, 2021

rovere commented Feb 27, 2021

cmsbuild commented Feb 27, 2021

cmsbuild commented Mar 15, 2021

jpata commented Mar 15, 2021

mariadalfonso commented Mar 16, 2021

jfernan2 commented Mar 16, 2021

mariadalfonso commented Mar 16, 2021

jfernan2 commented Mar 16, 2021

jpata commented Mar 17, 2021

mariadalfonso commented Mar 21, 2021

civanch commented Mar 21, 2021

srimanob commented Mar 22, 2021

cmsbuild commented Mar 22, 2021

silviodonato commented Mar 22, 2021

HFNose: ticl updates #33001

HFNose: ticl updates #33001

Conversation

mariadalfonso commented Feb 25, 2021 • edited Loading

cmsbuild commented Feb 25, 2021

cmsbuild commented Feb 25, 2021

cmsbuild commented Feb 25, 2021

rovere Feb 27, 2021

Choose a reason for hiding this comment

rovere Feb 27, 2021

Choose a reason for hiding this comment

mariadalfonso Feb 28, 2021

Choose a reason for hiding this comment

mariadalfonso Feb 28, 2021

Choose a reason for hiding this comment

rovere commented Feb 27, 2021

rovere commented Feb 27, 2021

cmsbuild commented Feb 27, 2021

RelVals

RelVals-INPUT

AddOn Tests

cmsbuild commented Mar 15, 2021

Comparison Summary

jpata commented Mar 15, 2021

mariadalfonso commented Mar 16, 2021

jfernan2 commented Mar 16, 2021

mariadalfonso commented Mar 16, 2021

jfernan2 commented Mar 16, 2021

jpata commented Mar 17, 2021

mariadalfonso commented Mar 21, 2021

civanch commented Mar 21, 2021

srimanob commented Mar 22, 2021

cmsbuild commented Mar 22, 2021

silviodonato commented Mar 22, 2021

mariadalfonso commented Feb 25, 2021 •

edited

Loading