Seed TICL by L1 e/gamma + other timing considerations for e/gamma HLT

[swagata87]

PR description:

This PR introduces

1. an option to seed TICL by L1 e/gamma objects. Currently TICL can be seeded by general tracks, which is fine for offline reco but too slow for EGM HLT, hence we are not using it. We use globally seeded TICL EM iteration. It was found in preliminary studies that the trackster production step runs faster if we replace global seeding by L1 seeding.

2. options to produce reduced recHit and reduced digi collections for HGCAL. Currently the layercluster production step at EGM HLT takes some time to run, as it runs on all HGCAL recHits. We want to run the layercluster production step on a reduced recHit collection, ie, only the recHits around L1 e/gamma objects. The reduced digi is not being used currently, but can be used later if needed.

3. a producer code to filter phase2 L1 collection based on hardware quality. The reduced recHit producer will take the filtered L1 collection with good quality L1 objects, and will keep the recHits around them.

[with thanks to @Sam-Harper]

PR validation:

runTheMatrix.py -l 23234.0 #2026D49 ttbar (HLT TDR baseline w/ HGCal v11)
runTheMatrix.py -l 11634.0 #2021 ttbar

A backport to 11_1_X will be needed for HLT TDR.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32978/21221

• This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32978/21221/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32978/21221/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32978/21222

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @swagata87 (Swagata Mukherjee) for master.

It involves the following packages:

RecoEgamma/EgammaHLTProducers
RecoHGCal/TICL

@perrotta, @cmsbuild, @fwyzard, @kpedro88, @Martin-Grunewald, @srimanob, @slava77, @jpata can you please review it and eventually sign? Thanks.
@Sam-Harper, @HuguesBrun, @apsallid, @felicepantaleo, @jainshilpi, @afiqaize, @Fedespring, @lgray, @calderona, @sobhatta, @rovere, @lecriste, @hatakeyamak, @cericeci, @varuns23, @clelange, @ram1123 this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[fwyzard]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32978/21225

• This PR adds an extra 24KB to repository

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32978/21355

• This PR adds an extra 32KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoHGCal/TICL/plugins/SeedingRegionByTracks.cc modified in PR(s): HFNose: ticl updates #33001
  • File RecoHGCal/TICL/plugins/SeedingRegionByTracks.h modified in PR(s): HFNose: ticl updates #33001
  • File RecoHGCal/TICL/plugins/TICLSeedingRegionProducer.cc modified in PR(s): HFNose: ticl updates #33001
  • File RecoHGCal/TICL/python/TICLSeedingRegions_cff.py modified in PR(s): HFNose: ticl updates #33001

[cmsbuild]

Pull request #32978 was updated. @perrotta, @cmsbuild, @fwyzard, @kpedro88, @Martin-Grunewald, @srimanob, @slava77, @jpata can you please check and sign again.

[jpata]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e80dad/13236/summary.html
COMMIT: a7afa14
CMSSW: CMSSW_11_3_X_2021-03-02-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32978/13236/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2865 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2750983
• DQMHistoTests: Total failures: 64465
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2686496
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[jpata]

+reconstruction

• updates to TICL seeding
• no relevant differences observed (11634.911 is from dd4hep)

[srimanob]

+Upgrade

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1

[silviodonato]

+1