moving DataFormats/RecoCandidate/interface/TrackAssociation.h into SimDataFormats

[davidlange6]

reduces the number of incorrect dependencies on SimDataFormats within DataFormats packages.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33186/21598

• This PR adds an extra 48KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimDataFormats/Associations/src/classes.h modified in PR(s): MultiCluster-CaloParticle associator #32941
  • File SimDataFormats/Associations/src/classes_def.xml modified in PR(s): [RFC] Outline of HGCAL ML ntuples using NanoAOD #32187, MultiCluster-CaloParticle associator #32941

[cmsbuild]

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

CalibTracker/SiStripCommon
DataFormats/RecoCandidate
RecoVertex/KalmanVertexFit
SimDataFormats/Associations
SimMuon/MCTruth
SimTracker/TrackAssociatorProducers
SimTracker/VertexAssociation
Validation/RecoMuon
Validation/RecoParticleFlow

@perrotta, @malbouis, @andrius-k, @yuanchao, @kmaeshima, @civanch, @slava77, @christopheralanwest, @ErnestaP, @mdhildreth, @cmsbuild, @jfernan2, @ahmad3213, @tlampen, @jpata, @pohsun, @rvenditti, @francescobrivio can you please review it and eventually sign? Thanks.
@echabert, @gouskos, @pieterdavid, @robervalwalsh, @threus, @mmusich, @cericeci, @battibass, @makortel, @JanFSchulte, @jhgoh, @dgulhan, @apsallid, @HuguesBrun, @slomeo, @trocino, @rociovilar, @abbiendi, @GiacomoSguazzoni, @rovere, @VinInn, @tocheng, @hatakeyamak, @ebrondol, @mtosi, @fabiocos, @gbenelli, @Fedespring, @calderona, @lecriste this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

…

On Mar 16, 2021, at 9:22 AM, cmsbuild ***@***.***> wrote: A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: CalibTracker/SiStripCommon DataFormats/RecoCandidate RecoVertex/KalmanVertexFit SimDataFormats/Associations SimMuon/MCTruth SimTracker/TrackAssociatorProducers SimTracker/VertexAssociation Validation/RecoMuon Validation/RecoParticleFlow @perrotta, @malbouis, @andrius-k, @yuanchao, @kmaeshima, @civanch, @slava77, @christopheralanwest, @ErnestaP, @mdhildreth, @cmsbuild, @jfernan2, @ahmad3213, @tlampen, @jpata, @pohsun, @rvenditti, @francescobrivio can you please review it and eventually sign? Thanks. @echabert, @gouskos, @pieterdavid, @robervalwalsh, @threus, @mmusich, @cericeci, @battibass, @makortel, @JanFSchulte, @jhgoh, @dgulhan, @apsallid, @HuguesBrun, @slomeo, @trocino, @rociovilar, @abbiendi, @GiacomoSguazzoni, @rovere, @VinInn, @tocheng, @hatakeyamak, @ebrondol, @mtosi, @fabiocos, @gbenelli, @Fedespring, @calderona, @lecriste this is something you requested to watch as well. @silviodonato, @dpiparo, @qliphy you are the release manager for this. cms-bot commands are listed here — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a25045/13535/summary.html
COMMIT: d60f967
CMSSW: CMSSW_11_3_X_2021-03-15-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33186/13535/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Building  edm plugin tmp/slc7_amd64_gcc900/src/DQMOffline/RecoB/plugins/DQMOfflineRecoBPlugins/libDQMOfflineRecoBPlugins.so
/cvmfs/cms-ib.cern.ch/nweek-02672/slc7_amd64_gcc900/external/gcc/9.3.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/9.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc900/src/DQMOffline/RecoB/plugins/DQMOfflineRecoBPlugins/BTagPerformanceAnalyzerOnData.cc.o: in function `BTagPerformanceAnalyzerOnData::BTagPerformanceAnalyzerOnData(edm::ParameterSet const&)':
BTagPerformanceAnalyzerOnData.cc:(.text+0x177a): undefined reference to `typeinfo for GenEventInfoProduct'
/cvmfs/cms-ib.cern.ch/nweek-02672/slc7_amd64_gcc900/external/gcc/9.3.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/9.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc900/src/DQMOffline/RecoB/plugins/DQMOfflineRecoBPlugins/BTagPerformanceAnalyzerOnData.cc.o: in function `bool edm::Event::getByToken(edm::EDGetTokenT, edm::Handle&) const':
BTagPerformanceAnalyzerOnData.cc:(.text._ZNK3edm5Event10getByTokenI19GenEventInfoProductEEbNS_11EDGetTokenTIT_EERNS_6HandleIS4_EE[_ZNK3edm5Event10getByTokenI19GenEventInfoProductEEbNS_11EDGetTokenTIT_EERNS_6HandleIS4_EE]+0x63): undefined reference to `typeinfo for GenEventInfoProduct'
collect2: error: ld returned 1 exit status
gmake: *** [tmp/slc7_amd64_gcc900/src/DQMOffline/RecoB/plugins/DQMOfflineRecoBPlugins/libDQMOfflineRecoBPlugins.so] Error 1
Leaving library rule at src/DQMOffline/RecoB/plugins
>> Leaving Package DQMOffline/RecoB
>> Package DQMOffline/RecoB built
>> Entering Package DQM/TrackingMonitorClient


[davidlange6]

is DQMOffline supposed to need MC information?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33186/21614

• This PR adds an extra 52KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimDataFormats/Associations/src/classes.h modified in PR(s): move TTTrackTruthPair to SimDataFormats/Associations #33188, MultiCluster-CaloParticle associator #32941
  • File SimDataFormats/Associations/src/classes_def.xml modified in PR(s): move TTTrackTruthPair to SimDataFormats/Associations #33188, [RFC] Outline of HGCAL ML ntuples using NanoAOD #32187, MultiCluster-CaloParticle associator #32941

[cecilecaillol]

+l1

[slava77]

+reconstruction

for #33186 c75d0d0

[christopheralanwest]

+alca

[jfernan2]

+1

[civanch]

+1

[silviodonato]

merge

[silviodonato]

@cmsbuild ping

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.