Update CSCMake2DRecHit.cc #32442

nvoytish · 2020-12-10T19:21:53Z

Fix of issue #32274
caused by changes in PR #32052

PR description:

It turned out that we need to keep the omitted "if"
7501f0c#diff-89c0bedb1d5ff71760f4a99102f4c06386cdac66bb8527527d41a7fe28e5dab8L160
We forgot that there is a difference in detid for wires in simulation and real
data. For real data all wires are labelled as ME11B. This "if" does not allow for a strip from ME11A to be assembled with a wire that geometrically is outside the ME11A sensitive area.

Fix of issue cms-sw#32274 caused by changes in PR cms-sw#32052

cmsbuild · 2020-12-10T19:29:13Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32442/20333

This PR adds an extra 16KB to repository

cmsbuild · 2020-12-10T19:29:40Z

A new Pull Request was created by @nvoytish for master.

It involves the following packages:

RecoLocalMuon/CSCRecHitD

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@ptcox, @bellan, @abbiendi, @jhgoh this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

slava77 · 2020-12-10T19:30:24Z

@cmsbuild please test for CMSSW_11_2_ASAN_X

slava77 · 2020-12-10T19:32:46Z

cms/unknown/release — Unable to find cmssw release to run tests.

@smuzaffar is there a way to test with ASAN from the bot?

slava77 · 2020-12-10T19:37:58Z

@cmsbuild please test for CMSSW_11_3_ASAN_X

perhaps this would work

slava77 · 2020-12-10T19:40:04Z

perhaps this would work

 cms/ASAN/slc7_amd64_gcc900/optional Pending — Tests scheduled CMSSW_11_3_ASAN_X/slc7_amd64_gcc900

it works

cmsbuild · 2020-12-11T00:07:44Z

-1

CMSSW: CMSSW_11_3_ASAN_X_2020-12-09-2300/slc7_amd64_gcc900

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Phase2-hgx270 Bug correction for HGCal scintillator Geometry #32423 @bsunanda: Phase2-hgx270 Bug correction for HGCal scintillator Geometry
[Puppi] option to use generic PU proxy #32341 @missirol: [Puppi] option to use generic PU proxy
sync up with #32372: remove unnecessary include in PhysicsTools/PatAlgos slimmedLowPtElectrons_cff.py #32426 @slava77: sync up with Add low-pT electrons to MINIAOD, update ID, improve end user experience (back port of 31220) #32372: remove unnecessary include in PhysicsTools/PatAlgos slimmedLowPtElectrons_cff.py
Break circular dependency between CommonTools and JetMETCorrections subsystems #32401 @guitargeek: Break circular dependency between CommonTools and JetMETCorrections subsystems
Phase2-hgx269 Make use of ESGetToken and remove usage of HCAL (in one app) #32393 @bsunanda: Phase2-hgx269 Make use of ESGetToken and remove usage of HCAL (in one app)
Update of HGCal validation of CaloParticle #32412 @ebrondol: Update of HGCal validation of CaloParticle

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b3fa5/11527/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b3fa5/11527/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b3fa5/11527/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests RelVals AddOn

Unit Tests:

I found errors in the following unit tests:

---> test TestDQMServicesDemo had ERRORS

RelVals:

When I ran the RelVals I found an error in the following workflows:
11624.911 step1

runTheMatrix-results/11624.911_TTbar_13+2021_DD4hep+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+Reco+HARVEST+ALCA/step1_TTbar_13+2021_DD4hep+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+Reco+HARVEST+ALCA.log

1001.0 step4

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step4_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log

23234.0 step2

runTheMatrix-results/23234.0_TTbar_14TeV+2026D49+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal/step2_TTbar_14TeV+2026D49+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal.log

28234.0 step2

runTheMatrix-results/28234.0_TTbar_14TeV+2026D60+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal/step2_TTbar_14TeV+2026D60+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal.log

23434.999 step3

runTheMatrix-results/23434.999_TTbar_14TeV+2026D49PU_PMXS1S2PR+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU/step3_TTbar_14TeV+2026D49PU_PMXS1S2PR+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU.log

AddOn:

I found errors in the following addon tests:

cmsRun /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_11_3_ASAN_X_2020-12-09-2300/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Dec 11 00:54:31 2020-date Fri Dec 11 00:01:05 2020 s - exit: 256
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_11_3_ASAN_X_2020-12-09-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Dec 11 00:52:12 2020-date Fri Dec 11 00:01:10 2020 s - exit: 256
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_11_3_ASAN_X_2020-12-09-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Dec 11 00:48:17 2020-date Fri Dec 11 00:01:24 2020 s - exit: 256
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_11_3_ASAN_X_2020-12-09-2300/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Dec 11 00:49:45 2020-date Fri Dec 11 00:01:25 2020 s - exit: 256
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_11_3_ASAN_X_2020-12-09-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake2.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Dec 11 00:48:37 2020-date Fri Dec 11 00:01:30 2020 s - exit: 256
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_11_3_ASAN_X_2020-12-09-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake1.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Dec 11 00:48:32 2020-date Fri Dec 11 00:01:34 2020 s - exit: 256
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_11_3_ASAN_X_2020-12-09-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Dec 11 00:55:31 2020-date Fri Dec 11 00:22:24 2020 s - exit: 256

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Phase2-hgx270 Bug correction for HGCal scintillator Geometry #32423 @bsunanda: Phase2-hgx270 Bug correction for HGCal scintillator Geometry
[Puppi] option to use generic PU proxy #32341 @missirol: [Puppi] option to use generic PU proxy
sync up with #32372: remove unnecessary include in PhysicsTools/PatAlgos slimmedLowPtElectrons_cff.py #32426 @slava77: sync up with Add low-pT electrons to MINIAOD, update ID, improve end user experience (back port of 31220) #32372: remove unnecessary include in PhysicsTools/PatAlgos slimmedLowPtElectrons_cff.py
Break circular dependency between CommonTools and JetMETCorrections subsystems #32401 @guitargeek: Break circular dependency between CommonTools and JetMETCorrections subsystems
Phase2-hgx269 Make use of ESGetToken and remove usage of HCAL (in one app) #32393 @bsunanda: Phase2-hgx269 Make use of ESGetToken and remove usage of HCAL (in one app)
Update of HGCal validation of CaloParticle #32412 @ebrondol: Update of HGCal validation of CaloParticle

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b3fa5/11527/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b3fa5/11527/git-merge-result

slava77 · 2020-12-11T01:11:10Z

it doesn't look like the CSC-related error is showing up in the ASAN tests, hopefully it's not shadowed by the other errors

slava77 · 2020-12-11T01:11:18Z

@cmsbuild please test

cmsbuild · 2020-12-11T02:49:46Z

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b3fa5/11530/summary.html
CMSSW: CMSSW_11_3_X_2020-12-10-1100/slc7_amd64_gcc900

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Phase2-hgx269 Make use of ESGetToken and remove usage of HCAL (in one app) #32393 @bsunanda: Phase2-hgx269 Make use of ESGetToken and remove usage of HCAL (in one app)
Update of HGCal validation of CaloParticle #32412 @ebrondol: Update of HGCal validation of CaloParticle

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b3fa5/11530/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b3fa5/11530/git-merge-result

cmsbuild · 2020-12-11T05:27:36Z

Comparison results are now available
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b3fa5/11530/summary.html
CMSSW: CMSSW_11_3_X_2020-12-10-1100/slc7_amd64_gcc900

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 1106 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2746654
DQMHistoTests: Total failures: 3163
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2743469
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -4789.446 KiB( 35 files compared)
DQMHistoSizes: changed ( 23234.0,... ): -3579.133 KiB HGCAL/CaloParticles
DQMHistoSizes: changed ( 23234.0,... ): 1982.650 KiB HGCAL/HGCalValidator
Checked 153 log files, 37 edm output root files, 36 DQM output files

slava77 · 2020-12-15T16:48:33Z

@nvoytish
please make a PR for 11_2_X release as well.
Thank you.

slava77 · 2020-12-15T16:53:01Z

+1

for #32442 2fdd9dc

code changes are in line with the PR description
jenkins tests pass and comparisons with the baseline show rather small differences that start in csc segments and occasionally propagate downstream.

cmsbuild · 2020-12-15T16:53:23Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-12-15T18:21:53Z

+1

PR required by RECO conveners cms-sw#32442 (comment)

Update CSCMake2DRecHit.cc

2fdd9dc

Fix of issue cms-sw#32274 caused by changes in PR cms-sw#32052

cmsbuild added this to the CMSSW_11_3_X milestone Dec 10, 2020

cmsbuild added code-checks-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Dec 10, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 10, 2020

cmsbuild added tests-started and removed tests-pending labels Dec 10, 2020

cmsbuild added tests-pending and removed tests-started labels Dec 10, 2020

cmsbuild added tests-started and removed tests-pending labels Dec 10, 2020

cmsbuild added tests-rejected and removed tests-started labels Dec 11, 2020

cmsbuild added tests-started and removed tests-rejected labels Dec 11, 2020

cmsbuild added tests-approved and removed tests-started labels Dec 11, 2020

Dr15Jones mentioned this pull request Dec 13, 2020

Out of bounds write in TauNNId::compute #32460

Closed

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Dec 15, 2020

cmsbuild added orp-approved and removed orp-pending labels Dec 15, 2020

cmsbuild merged commit e2fd126 into cms-sw:master Dec 15, 2020

This was referenced Dec 16, 2020

Add and use preprocessors macros for loop unrolling #32499

Merged

[Do not merge] For testing bot commit statuses #32496

Closed

nvoytish added a commit to nvoytish/cmssw that referenced this pull request Dec 16, 2020

Update CSCMake2DRecHit.cc

c3ceff4

PR required by RECO conveners cms-sw#32442 (comment)

nvoytish mentioned this pull request Dec 16, 2020

Update CSCMake2DRecHit.cc #32507

Merged

slava77 mentioned this pull request Dec 17, 2020

ASAN problem in CSCXonStrip_MatchGatti #32274

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update CSCMake2DRecHit.cc #32442

Update CSCMake2DRecHit.cc #32442

nvoytish commented Dec 10, 2020

cmsbuild commented Dec 10, 2020

cmsbuild commented Dec 10, 2020

slava77 commented Dec 10, 2020

slava77 commented Dec 10, 2020

slava77 commented Dec 10, 2020

slava77 commented Dec 10, 2020

cmsbuild commented Dec 11, 2020

slava77 commented Dec 11, 2020

slava77 commented Dec 11, 2020

cmsbuild commented Dec 11, 2020

cmsbuild commented Dec 11, 2020

slava77 commented Dec 15, 2020

slava77 commented Dec 15, 2020

cmsbuild commented Dec 15, 2020

silviodonato commented Dec 15, 2020

Update CSCMake2DRecHit.cc #32442

Update CSCMake2DRecHit.cc #32442

Conversation

nvoytish commented Dec 10, 2020

PR description:

cmsbuild commented Dec 10, 2020

cmsbuild commented Dec 10, 2020

slava77 commented Dec 10, 2020

slava77 commented Dec 10, 2020

slava77 commented Dec 10, 2020

slava77 commented Dec 10, 2020

cmsbuild commented Dec 11, 2020

slava77 commented Dec 11, 2020

slava77 commented Dec 11, 2020

cmsbuild commented Dec 11, 2020

cmsbuild commented Dec 11, 2020

slava77 commented Dec 15, 2020

slava77 commented Dec 15, 2020

cmsbuild commented Dec 15, 2020

silviodonato commented Dec 15, 2020