Add low-pT electrons to MINIAOD, update ID, improve end user experience (back port of 31220)

[bainbrid]

PR description:

This PR relies on the following PR: cms-data/RecoEgamma-ElectronIdentification#17 (UPDATED!)

• Adds low-pT electrons to MINIAOD by default
• Updates the ID ("2020Sept15" from BParking studies)
• Keeps only a subset of low-pT electrons (BDT score>1.5, mistag ~10%, efficiency ~90%)
• Embed informations in the pat::Electron, and drops RECO collections
• Stores GBRForest object (for ID) in ROOT file format rather than XML, fixes this issue
• Uses the run2_miniAOD_UL modifier to run PAT on existing RECO/AOD samples

PR validation:

• Tested locally with wfs ()
• Tested with a standalone "unit test" module.
• Tested against PR Add low-pT electrons to MINIAOD, update ID, improve end user experience #31220 to ensure consistent output.

if this PR is a backport please specify the original PR and why you need to backport that PR:

• This PR is a back port of LowPtElectrons: updated BDT model and code base for ID #31080
• These developments will be used as part of the re-miniAOD UltraLegacy campaign.

@slava77 @guitargeek @crovelli @afiqaize @SohamBhattacharya @jpata @jainshilpi @lsoffi

[cmsbuild]

A new Pull Request was created by @bainbrid for CMSSW_10_6_X.

It involves the following packages:

CommonTools/MVAUtils
DataFormats/PatCandidates
PhysicsTools/PatAlgos
RecoEgamma/Configuration
RecoEgamma/EgammaElectronProducers
RecoEgamma/EgammaTools

@perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @jainshilpi, @hatakeyamak, @emilbols, @varuns23, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @lgray, @jdolen, @ferencek, @Sam-Harper, @cbernet, @rovere, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @clelange, @JyothsnaKomaragiri, @sobhatta, @lecriste, @afiqaize, @gpetruc, @mariadalfonso, @ram1123 this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test with cms-data/RecoEgamma-ElectronIdentification#15

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-data/RecoEgamma-ElectronIdentification#15

• CMSSW_10_6_X_2020-12-02-1100/slc7_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11281/console Started: 2020/12/02 22:12
• CMSSW_10_6_X_2020-12-03-1100/slc7_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11310/console Started: 2020/12/03 14:59
• CMSSW_10_6_X_2020-12-05-1100/slc7_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11349/console Started: 2020/12/06 21:10
• CMSSW_10_6_X_2020-12-06-2300/slc7_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11405/console Started: 2020/12/08 00:37
• CMSSW_10_6_X_2020-12-07-2300/slc7_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11424/console Started: 2020/12/08 14:27
• CMSSW_10_6_X_2020-12-08-1100/slc7_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11437/console Started: 2020/12/08 18:00
• CMSSW_10_6_X_2020-12-08-1100/slc7_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11440/console Started: 2020/12/08 21:18

[cmsbuild]

-1

Tested at: fbac9e3

CMSSW: CMSSW_10_6_X_2020-12-02-1100
SCRAM_ARCH: slc7_amd64_gcc700
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b858b/11281/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following workflows:
135.4 step3

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step3_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

[slava77]

When I ran the RelVals I found an error in the following workflows:
135.4 step3

   [5] Calling method for module PATElectronProducer/'patLowPtElectrons'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: edm::ValueMap<float>
Looking for module label: rekeyLowPtGsfElectronSeedValueMaps
Looking for productInstanceName: ptbiased

looks related.
Something is not (un)setup right for the fastsim case.

[cmsbuild]

Pull request #32372 was updated. @perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please check and sign again.

[bainbrid]

In respose to #32372 (comment).

The FastSim-related config is unchanged.

In 11_X, the rekeyLowPtGsfElectronSeedValueMaps collection is present in the step1.root file.
While for 10_6_X it is not. Hence the failed step3 test.

After some digging, I realised that the structure of RecoEgamma_EventContent_cff.py has changed. In 11_X, I added the rekeyLowPtGsfElectronSeedValueMaps collection to the RecoEgammaAOD list, which is then cloned and extended by RecoEgammaRECO and RecoEgammaFEVT. In 10_6_X, the latter two are defined independently of RecoEgammaAOD and my back port didn't account for this.

Now corrected with the latest commit. Tested locally with wf 135.4.

[slava77]

test parameters:

• pull_request = LowPtElectrons: latest BDT model for ID (ROOT file format) cms-data/RecoEgamma-ElectronIdentification#15
• workflows = 136.898,1304.181

[slava77]

@cmsbuild please test

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b858b/11310/summary.html
CMSSW: CMSSW_10_6_X_2020-12-03-1100
SCRAM_ARCH: slc7_amd64_gcc700

[cmsbuild]

Comparison results are now available
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b858b/11310/summary.html
CMSSW: CMSSW_10_6_X_2020-12-03-1100
SCRAM_ARCH: slc7_amd64_gcc700

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-9b858b/136.898_RunParkingBPH2018B+RunParkingBPH2018B+HLTDR2_2018+RECODR2_2018reHLT_skimParkingBPH_Offline+HARVEST2018

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 28 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 3214712
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3214376
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 140 log files, 29 edm output root files, 34 DQM output files

[slava77]

@smuzaffar
I'm confused about the tests status labels.
From the messages above, I think that the tests are done and the comparisons are available in #32372 (comment)
Please check why the labels are still in "tests-started"
Thank you.

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c62746/11440/summary.html
CMSSW: CMSSW_10_6_X_2020-12-08-1100
SCRAM_ARCH: slc7_amd64_gcc700

[cmsbuild]

Comparison results are now available
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c62746/11440/summary.html
CMSSW: CMSSW_10_6_X_2020-12-08-1100
SCRAM_ARCH: slc7_amd64_gcc700

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-c62746/136.898_RunParkingBPH2018B+RunParkingBPH2018B+HLTDR2_2018+RECODR2_2018reHLT_skimParkingBPH_Offline+HARVEST2018

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 3214712
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3214377
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 140 log files, 29 edm output root files, 34 DQM output files

[slava77]

+1

for #32372 541fb89

• code changes are in line with the PR description and the follow up review; see the notes below on the congruence of this PR with the master
• jenkins (and some local) tests pass and comparisons with the baseline show expected/acceptable differences
  • slimmedLowPtElectrons now shows up in the UL re-miniAOD workflow 136.88811; this is the primary target of this PR
  • the bParking workflows (1304.181 and 136.898) have a change in electronIDs variables in slimmedLowPtElectrons; this is somewhat acceptable Add low-pT electrons to MINIAOD, update ID, improve end user experience (back port of 31220) #32372 (comment)

this PR includes partial or complete backports of the following:

• Fix in TauAnalysis/MCEmbeddingTools/python/customisers.py (lowPtGsfElectronTask) #32400 : complete (TauAnalysis/MCEmbeddingTools/python/customisers.py)
• Add low-pT electrons to MINIAOD, update ID, improve end user experience #31220 (the main source of this PR) : close to complete
  • using edm::View in RecoEgamma/EgammaElectronProducers/plugins/LowPtGsfElectronIDProducer.cc was not backported
• LowPtElectrons: updated BDT model and code base for ID #31080 (PR preceding Add low-pT electrons to MINIAOD, update ID, improve end user experience #31220) is partial: changes in LowPtGsfElectronFeatures.{h,cc} , what's not superseded in Add low-pT electrons to MINIAOD, update ID, improve end user experience #31220, are not backported, related mainly to the method(s) in namespace lowptgsfeleseed {
• Running code-format for analysis-reconstruction #27169 and Running code-format for reconstruction #27344 (clang-format PRs): only modifications in files relevant to Add low-pT electrons to MINIAOD, update ID, improve end user experience #31220 are here
• RecoEgamma/EgammaElectronProducers cleanup #27477 , No need for GsfElectronCoreBaseProducer and merging .h and .cc files for EgammaElectronProducers #28746, Adapt EgammaHadTower and ElectronHcalHelper classes to use ESGetToken #31700 (various egamma refactoring PRs) contributed to LowPtGsfElectronSeedValueMapsProducer.{h,cc}

Small discrepancies are present here compared to the master:

• somewhat trivial differences in imported files in PhysicsTools/PatAlgos/python/slimming/slimmedLowPtElectrons_cff.py is rectified in sync up with #32372: remove unnecessary include in PhysicsTools/PatAlgos slimmedLowPtElectrons_cff.py #32426
• additional 106X specific updates were made to maintain the no-change policy; this does not need a sync with the master

[qliphy]

@cms-sw/simulation-l2 @cms-sw/analysis-l2 Would you please have a look? This is urgently needed for re-MiniAOD.

[qliphy]

urgent

[civanch]

+1

[silviodonato]

merge

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will be automatically merged.