Running code-format for analysis-reconstruction #27169
Conversation
|
please test |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27169/10319
|
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @cmsbuild for master. It involves the following packages: PhysicsTools/PatAlgos @perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
| for (size_t j = 0; j < sv.numberOfDaughters(); j++) { | ||
| TrackRef r; | ||
| if (sv.daughterPtr(j).id() == cands.id()) { | ||
| r = TrackRef(oh, |
There was a problem hiding this comment.
This can be fixed by moving the comment above the line of code
| trackKeys[sv.daughterPtr(j).key()]); // use trackKeys because cand->track has gaps from neutral | ||
| } else { | ||
| // std::cout << "vertex " << i << " using lost Track " << sv.daughterPtr(j).key() << " " << offsetAdd+sv.daughterPtr(j).key() << std::endl; | ||
| r = TrackRef(oh, |
There was a problem hiding this comment.
This can be fixed by moving the comment above the line of code
(Even better if we profit of it and remove the commented out L128)
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1
|
|
+1 |
cmsbuild
added
analysis-approved
fully-signed
and removed
analysis-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Applying code-format for CMSSW category analysis,reconstruction.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/384//console
cms-bot has successfully run the following: