Update CSCMake2DRecHit.cc

[nvoytish]

PR required by RECO conveners
#32442 (comment)

It turned out that we need to keep the omitted "if"
7501f0c#diff-89c0bedb1d5ff71760f4a99102f4c06386cdac66bb8527527d41a7fe28e5dab8L160
We forgot that there is a difference in detid for wires in simulation and real
data. For real data all wires are labelled as ME11B. This "if" does not allow for a strip from ME11A to be assembled with a wire that geometrically is outside the ME11A sensitive area.

[cmsbuild]

A new Pull Request was created by @nvoytish for CMSSW_11_2_X.

It involves the following packages:

RecoLocalMuon/CSCRecHitD

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@ptcox, @bellan, @abbiendi, @jhgoh this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Update CSCMake2DRecHit.cc #32442

[perrotta]

backport of #32442

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2fce07/11749/summary.html
CMSSW: CMSSW_11_2_X_2020-12-16-1100/slc7_amd64_gcc900

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 1107 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2529619
• DQMHistoTests: Total failures: 3192
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2526405
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 148 log files, 37 edm output root files, 35 DQM output files

[slava77]

type bugfix

[slava77]

+1

for #32507 c3ceff4

• code changes are in line with the PR description; the backport is identical in the code line changes as the master branch version Update CSCMake2DRecHit.cc #32442
  • the bug was introduced in CMSSW_11_2_0_pre10 together with somewhat large algorithm updates in CSC RecHit Builder updates #32052
• jenkins tests pass and comparisons with the baseline show differences starting from CSC segments (the count of differences is roughly the same as in the master version)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1