[DD4hep] evaluate all numeric parameters in tracker detector description #32371

ianna · 2020-12-02T17:17:48Z

PR description:

A follow up to the thread-safety issue reported by @Dr15Jones that was addressed in #32339:
all numeric constants should be evaluated.

Both step1 and step2 run to completion.

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

ianna · 2020-12-02T17:18:34Z

please test

cmsbuild · 2020-12-02T17:24:06Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32371/20218

This PR adds an extra 28KB to repository

cmsbuild · 2020-12-02T17:24:27Z

The tests are being triggered in jenkins.

CMSSW_11_3_X_2020-12-01-2300/slc7_amd64_gcc900: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11279/console Started: 2020/12/02 18:25
CMSSW_11_3_X_2020-12-02-2300/slc7_amd64_gcc900: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11304/console Started: 2020/12/03 12:12
CMSSW_11_3_X_2020-12-02-2300/slc7_amd64_gcc900: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11308/console Started: 2020/12/03 14:13

cmsbuild · 2020-12-02T17:24:29Z

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

Geometry/TrackerCommonData
Geometry/TrackerGeometryBuilder
Geometry/TrackerNumberingBuilder

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@vargasa, @makortel, @JanFSchulte, @VinInn, @ebrondol, @ghugo83, @mtosi, @fabiocos, @venturia this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2020-12-02T18:59:15Z

+1
Tested at: 5677282
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b81db0/11279/summary.html
CMSSW: CMSSW_11_3_X_2020-12-01-2300
SCRAM_ARCH: slc7_amd64_gcc900

cmsbuild · 2020-12-02T20:16:00Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b81db0/11279/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2529593
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2529570
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 148 log files, 37 edm output root files, 35 DQM output files

cvuosalo · 2020-12-02T20:56:16Z

+1

cmsbuild · 2020-12-02T20:56:36Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-12-02T21:18:00Z

+1

ianna · 2020-12-03T08:56:12Z

@silviodonato and @cvuosalo - which IB workflows are dd4hep based? Thanks

silviodonato · 2020-12-03T10:53:00Z

@ianna 11624.911 and 11642.91 (see #32096)

ianna · 2020-12-03T11:10:31Z

please test workflow 11624.911, 11642.91

cmsbuild · 2020-12-03T11:40:11Z

-1

CMSSW: CMSSW_11_3_X_2020-12-02-2300
SCRAM_ARCH: slc7_amd64_gcc900
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b81db0/11304/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

ianna · 2020-12-03T13:08:47Z

Hmm...

ValueError: Undefined workflows: 11642.91

ianna · 2020-12-03T13:12:05Z

please test workflow 11624.911

cmsbuild · 2020-12-03T14:39:40Z

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b81db0/11308/summary.html
CMSSW: CMSSW_11_3_X_2020-12-02-2300
SCRAM_ARCH: slc7_amd64_gcc900

ianna · 2020-12-03T15:58:02Z

@cvuosalo and @civanch - it looks like the dd4hep workflows finished successfully even though the label was not updated :-)

cmsbuild · 2020-12-03T15:58:47Z

Comparison results are now available
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b81db0/11308/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2529593
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2529570
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 148 log files, 37 edm output root files, 35 DQM output files

silviodonato · 2020-12-03T17:17:15Z

@ianna usually we see the crash of the DD4HEP workflows only in the IB test. The PR tests are single thread and "often" run without errors. The good news is that we don't see the two failing workflows in CMSSW_11_3_X_2020-12-02-2300 IB tests (https://cmssdt.cern.ch/SDT/html/cmssdt-ib/#/ib/CMSSW_11_3_X)

qliphy · 2020-12-04T00:21:55Z

@ianna usually we see the crash of the DD4HEP workflows only in the IB test. The PR tests are single thread and "often" run without errors. The good news is that we don't see the two failing workflows in CMSSW_11_3_X_2020-12-02-2300 IB tests (https://cmssdt.cern.ch/SDT/html/cmssdt-ib/#/ib/CMSSW_11_3_X)

@ianna As @silviodonato mentioned this seems to fix the IB issue for the two failing DD4hep workflows 11642.911 and 11624.911. Would you please backport #32371 and #32339 to 11_2_X? In 11_2_X IB, we still see the issues.
https://cmssdt.cern.ch/SDT/html/cmssdt-ib/#/relVal/CMSSW_11_2/2020-12-01-2300?selectedArchs=cc8_amd64_gcc9&selectedFlavors=X&selectedStatus=failed

ianna · 2020-12-04T11:48:43Z

@ianna usually we see the crash of the DD4HEP workflows only in the IB test. The PR tests are single thread and "often" run without errors. The good news is that we don't see the two failing workflows in CMSSW_11_3_X_2020-12-02-2300 IB tests (https://cmssdt.cern.ch/SDT/html/cmssdt-ib/#/ib/CMSSW_11_3_X)

@ianna As @silviodonato mentioned this seems to fix the IB issue for the two failing DD4hep workflows 11642.911 and 11624.911. Would you please backport #32371 and #32339 to 11_2_X? In 11_2_X IB, we still see the issues.
https://cmssdt.cern.ch/SDT/html/cmssdt-ib/#/relVal/CMSSW_11_2/2020-12-01-2300?selectedArchs=cc8_amd64_gcc9&selectedFlavors=X&selectedStatus=failed

ok, will do it asap

evaluate all numeric parameters in tracker detector description

5677282

cmsbuild added this to the CMSSW_11_3_X milestone Dec 2, 2020

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures tests-pending labels Dec 2, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 2, 2020

cmsbuild added tests-started and removed tests-pending labels Dec 2, 2020

cmsbuild added tests-approved and removed tests-started labels Dec 2, 2020

cmsbuild added comparison-available and removed comparison-pending labels Dec 2, 2020

cmsbuild added fully-signed geometry-approved and removed geometry-pending pending-signatures labels Dec 2, 2020

cmsbuild removed the orp-pending label Dec 2, 2020

cmsbuild added the orp-approved label Dec 2, 2020

cmsbuild merged commit 2f11ea5 into cms-sw:master Dec 2, 2020

cmsbuild added tests-started and removed comparison-available tests-approved labels Dec 3, 2020

cmsbuild added tests-rejected and removed tests-started labels Dec 3, 2020

cmsbuild added tests-started and removed tests-rejected labels Dec 3, 2020

cmsbuild added tests-approved and removed tests-started labels Dec 3, 2020

This was referenced Dec 4, 2020

Two relvals failing in Geometry #32181

Closed

Readd 1624.911, #2021 DD4hep from short matrix #32385

Merged

ianna mentioned this pull request Dec 4, 2020

[DD4hep] backport of 32339 and 32371 to assure thread-safe dd4hep workflow #32388

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DD4hep] evaluate all numeric parameters in tracker detector description #32371

[DD4hep] evaluate all numeric parameters in tracker detector description #32371

ianna commented Dec 2, 2020

ianna commented Dec 2, 2020

cmsbuild commented Dec 2, 2020

cmsbuild commented Dec 2, 2020 •

edited

Loading

cmsbuild commented Dec 2, 2020

cmsbuild commented Dec 2, 2020

cmsbuild commented Dec 2, 2020

cvuosalo commented Dec 2, 2020

cmsbuild commented Dec 2, 2020

silviodonato commented Dec 2, 2020

ianna commented Dec 3, 2020

silviodonato commented Dec 3, 2020

ianna commented Dec 3, 2020

cmsbuild commented Dec 3, 2020

ianna commented Dec 3, 2020

ianna commented Dec 3, 2020

cmsbuild commented Dec 3, 2020

ianna commented Dec 3, 2020

cmsbuild commented Dec 3, 2020

silviodonato commented Dec 3, 2020

qliphy commented Dec 4, 2020

ianna commented Dec 4, 2020

[DD4hep] evaluate all numeric parameters in tracker detector description #32371

[DD4hep] evaluate all numeric parameters in tracker detector description #32371

Conversation

ianna commented Dec 2, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

ianna commented Dec 2, 2020

cmsbuild commented Dec 2, 2020

cmsbuild commented Dec 2, 2020 • edited Loading

cmsbuild commented Dec 2, 2020

cmsbuild commented Dec 2, 2020

cmsbuild commented Dec 2, 2020

cvuosalo commented Dec 2, 2020

cmsbuild commented Dec 2, 2020

silviodonato commented Dec 2, 2020

ianna commented Dec 3, 2020

silviodonato commented Dec 3, 2020

ianna commented Dec 3, 2020

cmsbuild commented Dec 3, 2020

ianna commented Dec 3, 2020

ianna commented Dec 3, 2020

cmsbuild commented Dec 3, 2020

ianna commented Dec 3, 2020

cmsbuild commented Dec 3, 2020

silviodonato commented Dec 3, 2020

qliphy commented Dec 4, 2020

ianna commented Dec 4, 2020

cmsbuild commented Dec 2, 2020 •

edited

Loading