-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DD4hep Run 3 workflows 11624.911 and 11642.91 to PR/IB tests #32096
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32096/19740
|
A new Pull Request was created by @cvuosalo (Carl Vuosalo) for master. It involves the following packages: Configuration/PyReleaseValidation @chayanit, @cmsbuild, @wajidalikhan, @kpedro88, @jordan-martins can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@kpedro88 I added the workflow numbers as you instructed, but I don't see any indication in the PR test results that the new tests were run. |
@cvuosalo I misread your question and my instructions only added the workflows to IBs. If you want them to run by default in PRs (rather than on demand), you should also add them to:
|
+1 |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
Thanks. @cms-sw/upgrade-l2 @cms-sw/pdmv-l2 do you have comments? I tend to agree with Fabio about having only one additional workflow in the limited matrix (ie. keep only ttbar). Of course we can add more workflows in the extended matrix. |
+upgrade |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
As we are in the process of completing the DD4hep migration for Run 3, it would be helpful to have DD4hep workflows running in the PR/IB tests to make sure that new PRs don't break DD4hep-related functionality. The two added workflows are:
11624.911 2021_DD4hep+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+Reco+HARVEST+ALCA
11642.911 2021_DD4hep+ZMM_13TeV_TuneCUETP8M1_GenSim+Digi+Reco+HARVEST+ALCA
At the present time, the physics results of these workflows may not be entirely correct, but they do run to completion.
These workflows test GenSim, so they do not use pre-generated samples. Changes were required to allow these workflows to perform GenSim even while the other workflows were running with recycled samples.
PR validation:
The PR tests for this PR will show if the workflows have been added correctly.
No backport is desired.