Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readd 1624.911, #2021 DD4hep from short matrix #32385

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

silviodonato
Copy link
Contributor

Reverts #32313

After having merged #32371 , #32181 is solved. So I think we should try to readd 1624.911 in the PR tests. @cms-sw/reconstruction-l2 @cms-sw/simulation-l2 what do you think?

@silviodonato
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32385/20251

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2020

A new Pull Request was created by @silviodonato (Silvio Donato) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@chayanit, @wajidalikhan, @kpedro88, @jordan-martins can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2020

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d4983/11331/summary.html
CMSSW: CMSSW_11_3_X_2020-12-03-2300
SCRAM_ARCH: slc7_amd64_gcc900

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2020

Comparison results are now available
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d4983/11331/summary.html
CMSSW: CMSSW_11_3_X_2020-12-03-2300
SCRAM_ARCH: slc7_amd64_gcc900

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2529593
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2529567
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 148 log files, 37 edm output root files, 35 DQM output files

@slava77
Copy link
Contributor

slava77 commented Dec 4, 2020

After having merged #32371 , #32181 is solved. So I think we should try to readd 1624.911 in the PR tests. @cms-sw/reconstruction-l2 @cms-sw/simulation-l2 what do you think?

CMSSW_11_3_X_2020-12-03-2300 and 1100 look clean; so it should be OK to re-add then

@kpedro88
Copy link
Contributor

kpedro88 commented Dec 4, 2020

+upgrade

@chayanit
Copy link

chayanit commented Dec 4, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Dec 4, 2020

+1

@cmsbuild cmsbuild merged commit 6a9dd6a into master Dec 4, 2020
@smuzaffar smuzaffar deleted the revert-32313-patch-85 branch January 13, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants