Revert "Revert "CSJet update for fastjet-contrib 1.044""

[mseidel42]

This reverts #30838

Needs cms-sw/cmsdist#6209

Multi-stream problems fixed in #30888

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31355/18138

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @intrepid42 (Markus Seidel) for master.

It involves the following packages:

GeneratorInterface/RivetInterface
RecoJets/JetProducers

@SiewYan, @perrotta, @mkirsano, @cmsbuild, @jpata, @agrohsje, @slava77, @alberto-sanchez, @qliphy, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@rappoccio, @mkirsano, @jdolen, @yslai, @jdamgov, @ahinzmann, @nhanvtran, @agrohsje, @clelange, @schoef, @alberto-sanchez, @gkasieczka, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#6209

• CMSSW_11_2_X_2020-09-03-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9107/console Started: 2020/09/03 19:01

[cmsbuild]

+1
Tested at: f4aabea
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d86e10/9107/summary.html
CMSSW: CMSSW_11_2_X_2020-09-03-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d86e10/9107/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2609667
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2609644
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[agrohsje]

+1

[perrotta]

@intrepid42 did you test this PR and the attached external with (e.g.) wf 1302.18 multithread?
Please confirm that it runs now without errors, after #30888 has been merged

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#6209

• CMSSW_11_2_X_2020-09-05-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9142/console Started: 2020/09/05 15:31
• CMSSW_11_2_X_2020-09-05-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9143/console Started: 2020/09/05 16:20

[cmsbuild]

+1
Tested at: f4aabea
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d86e10/9143/summary.html
CMSSW: CMSSW_11_2_X_2020-09-05-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d86e10/9143/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2609667
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2609638
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[mseidel42]

@intrepid42 did you test this PR and the attached external with (e.g.) wf 1302.18 multithread?
Please confirm that it runs now without errors, after #30888 has been merged

Hi @perrotta , yes, I verified this locally. Is it possible to have multithreaded unit tests? If yes I can add one, so that we spot this kind of error easier

[perrotta]

+1

• Identical to CSJet update for fastjet-contrib 1.044 #30590, already merged and then reverted because of failures in multithread jobs
• Multi-stream issues were in Rivet, now fixed by Rivet ParticleLevelProducer and HTXS multi-threading #30888: this PR can then get re-merged now
• Technical for reco (true is the default input value for set_do_mass_subtraction() )
• Jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1